Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signalr / webpubsub - upgrade API version to 2024-03-01 #28940

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

sreallymatt
Copy link
Collaborator

@sreallymatt sreallymatt commented Mar 3, 2025

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)
image image

2 test failures unrelated and fixed in #28941

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sreallymatt LGTM!

@sreallymatt sreallymatt merged commit f8f8c30 into main Mar 4, 2025
32 checks passed
@sreallymatt sreallymatt deleted the mp/signalr-api-upgrade branch March 4, 2025 14:28
@github-actions github-actions bot added this to the v4.22.0 milestone Mar 4, 2025
sreallymatt added a commit that referenced this pull request Mar 4, 2025
joshvito pushed a commit to joshvito/terraform-provider-azurerm that referenced this pull request Mar 5, 2025
jackofallops added a commit that referenced this pull request Mar 7, 2025
* Update CHANGELOG.md #28843

* Update CHANGELOG.md for #28748

* Update CHANGELOG.md for #28881

* Update CHANGELOG.md for #28909

* Update CHANGELOG.md fold in patch release and expand starred entry correctly

* Update CHANGELOG.md remove duplicate entry for 28843

* Update CHANGELOG.md #28066

* Update CHANGELOG.md for #28902 and fix ordering

* Update CHANGELOG.md for #28848

* Update CHANGELOG.md #27622

* Update CHANGELOG.md for #28271

* Update CHANGELOG.md update format

* Update CHANGELOG.md #28934

* Update for #28619 #28598

* Update CHANGELOG.md #28940

* Update CHANGELOG.md for #28880

* Update CHANGELOG.md for #28617

* Update CHANGELOG.md #28721

* Update CHANGELOG.md #28949

* Update previous entry for 4.16.0

* Update CHANGELOG.md for #28834

* prep for release

---------

Co-authored-by: Matthew Frahry <[email protected]>
Co-authored-by: jackofallops <[email protected]>
Co-authored-by: catriona-m <[email protected]>
Co-authored-by: stephybun <[email protected]>
Co-authored-by: Wodans Son <[email protected]>
Co-authored-by: jackofallops <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants