Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_mssql_server - check if administrator_login is not nil #28909

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

stephybun
Copy link
Member

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_mssql_server - prevent panic by checking if administrator_login exists in the raw config map [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #28906

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@stephybun stephybun requested a review from a team as a code owner February 28, 2025 07:18
@github-actions github-actions bot added bug service/mssql Microsoft SQL Server size/XS labels Feb 28, 2025
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stephybun - LGTM 🐶

@jackofallops jackofallops merged commit e74f64f into main Feb 28, 2025
30 checks passed
@jackofallops jackofallops deleted the bug/fix-panic-in-mssql-server branch February 28, 2025 08:16
@github-actions github-actions bot added this to the v4.22.0 milestone Feb 28, 2025
jackofallops added a commit that referenced this pull request Feb 28, 2025
@bouweceunen-reform
Copy link

Just a small question since I'm having this issue, I'm I correct that this fix will be released in v4.22.0 due by March 06, 2025?

@stephybun
Copy link
Member Author

@bouweceunen-reform we'll be releasing a patch for this shortly

@stephybun stephybun modified the milestones: v4.22.0, v4.21.1 Feb 28, 2025
jackofallops added a commit that referenced this pull request Mar 7, 2025
* Update CHANGELOG.md #28843

* Update CHANGELOG.md for #28748

* Update CHANGELOG.md for #28881

* Update CHANGELOG.md for #28909

* Update CHANGELOG.md fold in patch release and expand starred entry correctly

* Update CHANGELOG.md remove duplicate entry for 28843

* Update CHANGELOG.md #28066

* Update CHANGELOG.md for #28902 and fix ordering

* Update CHANGELOG.md for #28848

* Update CHANGELOG.md #27622

* Update CHANGELOG.md for #28271

* Update CHANGELOG.md update format

* Update CHANGELOG.md #28934

* Update for #28619 #28598

* Update CHANGELOG.md #28940

* Update CHANGELOG.md for #28880

* Update CHANGELOG.md for #28617

* Update CHANGELOG.md #28721

* Update CHANGELOG.md #28949

* Update previous entry for 4.16.0

* Update CHANGELOG.md for #28834

* prep for release

---------

Co-authored-by: Matthew Frahry <[email protected]>
Co-authored-by: jackofallops <[email protected]>
Co-authored-by: catriona-m <[email protected]>
Co-authored-by: stephybun <[email protected]>
Co-authored-by: Wodans Son <[email protected]>
Co-authored-by: jackofallops <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provider version 4.21.0 crashing due to "panic: value is unknown"
3 participants