-
Notifications
You must be signed in to change notification settings - Fork 890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename deprecated argument (temporal_ensemble_momentum) #490
Merged
Cadene
merged 1 commit into
huggingface:main
from
myEverybot:rename-deprecated-config-argument
Nov 25, 2024
Merged
Rename deprecated argument (temporal_ensemble_momentum) #490
Cadene
merged 1 commit into
huggingface:main
from
myEverybot:rename-deprecated-config-argument
Nov 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cadene
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
DomThePorcupine
pushed a commit
to DomThePorcupine/lerobot
that referenced
this pull request
Dec 2, 2024
villekuosmanen
added a commit
to villekuosmanen/lerobot
that referenced
this pull request
Dec 30, 2024
* feat: enable to use multiple rgb encoders per camera in diffusion policy (huggingface#484) Co-authored-by: Alexander Soare <[email protected]> * Fix config file (huggingface#495) * fix: broken images and a few minor typos in README (huggingface#499) Signed-off-by: ivelin <[email protected]> * Add support for Windows (huggingface#494) * bug causes error uploading to huggingface, unicode issue on windows. (huggingface#450) * Add distinction between two unallowed cases in name check "eval_" (huggingface#489) * Rename deprecated argument (temporal_ensemble_momentum) (huggingface#490) * Dataset v2.0 (huggingface#461) Co-authored-by: Remi <[email protected]> * Refactor OpenX (huggingface#505) * Fix missing local_files_only in record/replay (huggingface#540) Co-authored-by: Simon Alibert <[email protected]> * Control simulated robot with real leader (huggingface#514) Co-authored-by: Remi <[email protected]> * Update 7_get_started_with_real_robot.md (huggingface#559) * LerobotDataset pushable to HF from any folder (huggingface#563) * Fix example 6 (huggingface#572) * fixing typo from 'teloperation' to 'teleoperation' (huggingface#566) * [vizualizer] for LeRobodDataset V2 (huggingface#576) * Fix broken `create_lerobot_dataset_card` (huggingface#590) * feat(act): support training end of episode token to ACT model * changes * feat(arx): add arx arm (#2) * feat(arx): support arx arm * changes * changes * changes * changes * pass pipes explicitly * changes * us ndarray over a pipe * changes * changes * replay basically works * patch arx sdk * changes * support cameras in arx5 * rename to arx5 * kind of works * changes * changes * changes * various changes * changes * revert a few changes * changes * changes * changes * changes * changes * changes * changes * changes * changes * remove TODO * allow multiple tasks --------- Signed-off-by: ivelin <[email protected]> Co-authored-by: Hirokazu Ishida <[email protected]> Co-authored-by: Alexander Soare <[email protected]> Co-authored-by: Arsen Ohanyan <[email protected]> Co-authored-by: Ivelin Ivanov <[email protected]> Co-authored-by: Daniel Ritchie <[email protected]> Co-authored-by: resolver101757 <[email protected]> Co-authored-by: Jannik Grothusen <[email protected]> Co-authored-by: KasparSLT <[email protected]> Co-authored-by: Simon Alibert <[email protected]> Co-authored-by: Remi <[email protected]> Co-authored-by: Michel Aractingi <[email protected]> Co-authored-by: Simon Alibert <[email protected]> Co-authored-by: berjaoui <[email protected]> Co-authored-by: Claudio Coppola <[email protected]> Co-authored-by: s1lent4gnt <[email protected]> Co-authored-by: Mishig <[email protected]> Co-authored-by: Eugene Mironov <[email protected]>
villekuosmanen
added a commit
to villekuosmanen/lerobot
that referenced
this pull request
Jan 10, 2025
* feat: enable to use multiple rgb encoders per camera in diffusion policy (huggingface#484) Co-authored-by: Alexander Soare <[email protected]> * Fix config file (huggingface#495) * fix: broken images and a few minor typos in README (huggingface#499) Signed-off-by: ivelin <[email protected]> * Add support for Windows (huggingface#494) * bug causes error uploading to huggingface, unicode issue on windows. (huggingface#450) * Add distinction between two unallowed cases in name check "eval_" (huggingface#489) * Rename deprecated argument (temporal_ensemble_momentum) (huggingface#490) * Dataset v2.0 (huggingface#461) Co-authored-by: Remi <[email protected]> * Refactor OpenX (huggingface#505) * Fix missing local_files_only in record/replay (huggingface#540) Co-authored-by: Simon Alibert <[email protected]> * Control simulated robot with real leader (huggingface#514) Co-authored-by: Remi <[email protected]> * Update 7_get_started_with_real_robot.md (huggingface#559) * LerobotDataset pushable to HF from any folder (huggingface#563) * Fix example 6 (huggingface#572) * fixing typo from 'teloperation' to 'teleoperation' (huggingface#566) * [vizualizer] for LeRobodDataset V2 (huggingface#576) * Fix broken `create_lerobot_dataset_card` (huggingface#590) * Update README.md (huggingface#612) * Fix Quality workflow (huggingface#622) * fix(docs): typos in benchmark readme.md (huggingface#614) Co-authored-by: Simon Alibert <[email protected]> * fix(visualise): use correct language description for each episode id (huggingface#604) Co-authored-by: Simon Alibert <[email protected]> * typo fix: batch_convert_dataset_v1_to_v2.py (huggingface#615) Co-authored-by: Simon Alibert <[email protected]> * [viz] Fixes & updates to html visualizer (huggingface#617) * fixes to SO-100 readme (huggingface#600) Co-authored-by: Philip Fung <no@one> Co-authored-by: Simon Alibert <[email protected]> --------- Signed-off-by: ivelin <[email protected]> Co-authored-by: Hirokazu Ishida <[email protected]> Co-authored-by: Alexander Soare <[email protected]> Co-authored-by: Arsen Ohanyan <[email protected]> Co-authored-by: Ivelin Ivanov <[email protected]> Co-authored-by: Daniel Ritchie <[email protected]> Co-authored-by: resolver101757 <[email protected]> Co-authored-by: Jannik Grothusen <[email protected]> Co-authored-by: KasparSLT <[email protected]> Co-authored-by: Simon Alibert <[email protected]> Co-authored-by: Remi <[email protected]> Co-authored-by: Michel Aractingi <[email protected]> Co-authored-by: Simon Alibert <[email protected]> Co-authored-by: berjaoui <[email protected]> Co-authored-by: Claudio Coppola <[email protected]> Co-authored-by: s1lent4gnt <[email protected]> Co-authored-by: Mishig <[email protected]> Co-authored-by: Eugene Mironov <[email protected]> Co-authored-by: CharlesCNorton <[email protected]> Co-authored-by: Philip Fung <[email protected]> Co-authored-by: Philip Fung <no@one>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
Renamed deprecated argument in Hydra config files to match torch implementation.
Should have been fixed here #319 (where act config was changed)
How it was tested
Renamed argument and checked that training converges with policy act_so100_real on own dataset.
How to checkout & try? (for the reviewer)
DATA_DIR=data python lerobot/scripts/train.py \ dataset_repo_id=${HF_USER}/so100_test \ policy=act_so100_real \ env=so100_real \ hydra.run.dir=outputs/train/act_so100_test \ hydra.job.name=act_so100_test \ device=cuda \ wandb.enable=true