Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onBlur handler not called on defocusing the editor? #773

Closed
deep-c opened this issue May 2, 2017 · 2 comments
Closed

onBlur handler not called on defocusing the editor? #773

deep-c opened this issue May 2, 2017 · 2 comments

Comments

@deep-c
Copy link

deep-c commented May 2, 2017

Hi,

Just noticed this, when I hooked slate up to redux-forms and the onBlur event never fired. I think this is a bug?

The onFocus event does get fired but not the onBlur event as seen here fiddle
@tyler-johnson
Copy link
Contributor

Yep, and this was working in the previous version, 0.19.20: https://jsfiddle.net/2zokvrvt/93/

@ianstormtaylor
Copy link
Owner

Thanks for opening this @deep-c. Cutting a release now that fixes this and maintains the new window checking behavior!

oyeanuj added a commit to oyeanuj/slate that referenced this issue May 4, 2017
@oyeanuj
Merge remote-tracking branch 'ianstormtaylor/master' into patch-7
cc1883e 
* ianstormtaylor/master:
  Clarifying insertTextByKey description (ianstormtaylor#778)
  Documenting node's 'getFirstText' & 'getLastText' (ianstormtaylor#779)
  0.19.22
  fix selection handling for changing tabs, and inside embedded inputs, closes ianstormtaylor#749
  fix to restrict window blur/focus handling, closes ianstormtaylor#773
  remove warn throwing since console.warn includes callsites now
  Update defining-custom-block-nodes.md (ianstormtaylor#776)
  0.19.21
  update table example to make scope clearer
  Fixed the link to comparisons, which was broken (ianstormtaylor#769)
  fix error when dragging void nodes without selection, closes ianstormtaylor#757
  fix to depend on prop-types for react 15.5
  fix to maintain focus on switching tabs, closes ianstormtaylor#756
  update issue template
  Add "data-key" to root div for the whole document (ianstormtaylor#759)
  add an issue template
oyeanuj added a commit to oyeanuj/slate that referenced this issue May 4, 2017
@oyeanuj
Merge remote-tracking branch 'ianstormtaylor/master'
af04f23 
* ianstormtaylor/master:
  Clarifying insertTextByKey description (ianstormtaylor#778)
  Documenting node's 'getFirstText' & 'getLastText' (ianstormtaylor#779)
  0.19.22
  fix selection handling for changing tabs, and inside embedded inputs, closes ianstormtaylor#749
  fix to restrict window blur/focus handling, closes ianstormtaylor#773
  remove warn throwing since console.warn includes callsites now
  Update defining-custom-block-nodes.md (ianstormtaylor#776)
  0.19.21
  update table example to make scope clearer
  Fixed the link to comparisons, which was broken (ianstormtaylor#769)
  fix error when dragging void nodes without selection, closes ianstormtaylor#757
  fix to depend on prop-types for react 15.5
  fix to maintain focus on switching tabs, closes ianstormtaylor#756
  update issue template
  Add "data-key" to root div for the whole document (ianstormtaylor#759)
  add an issue template
oyeanuj added a commit to oyeanuj/slate that referenced this issue May 4, 2017
@oyeanuj
Merge remote-tracking branch 'ianstormtaylor/master' into cut-copy-void
57afb7d 
* ianstormtaylor/master: (81 commits)
  Address doc suggestion in ianstormtaylor#644 (ianstormtaylor#760)
  Clarifying insertTextByKey description (ianstormtaylor#778)
  Documenting node's 'getFirstText' & 'getLastText' (ianstormtaylor#779)
  0.19.22
  fix selection handling for changing tabs, and inside embedded inputs, closes ianstormtaylor#749
  fix to restrict window blur/focus handling, closes ianstormtaylor#773
  remove warn throwing since console.warn includes callsites now
  Update defining-custom-block-nodes.md (ianstormtaylor#776)
  0.19.21
  update table example to make scope clearer
  Fixed the link to comparisons, which was broken (ianstormtaylor#769)
  fix error when dragging void nodes without selection, closes ianstormtaylor#757
  fix to depend on prop-types for react 15.5
  fix to maintain focus on switching tabs, closes ianstormtaylor#756
  update issue template
  Add "data-key" to root div for the whole document (ianstormtaylor#759)
  add an issue template
  add note to document documentation (ianstormtaylor#755)
  Fix typo in plugin.md (ianstormtaylor#753)
  update readme
  ...
oyeanuj added a commit to oyeanuj/slate that referenced this issue May 4, 2017
@oyeanuj
Merge remote-tracking branch 'ianstormtaylor/master' into placeholder…
2863446 
…-firstonly

* ianstormtaylor/master:
  Address doc suggestion in ianstormtaylor#644 (ianstormtaylor#760)
  Clarifying insertTextByKey description (ianstormtaylor#778)
  Documenting node's 'getFirstText' & 'getLastText' (ianstormtaylor#779)
  0.19.22
  fix selection handling for changing tabs, and inside embedded inputs, closes ianstormtaylor#749
  fix to restrict window blur/focus handling, closes ianstormtaylor#773
  remove warn throwing since console.warn includes callsites now
  Update defining-custom-block-nodes.md (ianstormtaylor#776)
  0.19.21
  update table example to make scope clearer
  Fixed the link to comparisons, which was broken (ianstormtaylor#769)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tyler-johnson @ianstormtaylor @deep-c