-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed typo in custom block nodes walkthrough #776
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks @briankabiro! |
oyeanuj
added a commit
to oyeanuj/slate
that referenced
this pull request
May 4, 2017
* ianstormtaylor/master: Clarifying insertTextByKey description (ianstormtaylor#778) Documenting node's 'getFirstText' & 'getLastText' (ianstormtaylor#779) 0.19.22 fix selection handling for changing tabs, and inside embedded inputs, closes ianstormtaylor#749 fix to restrict window blur/focus handling, closes ianstormtaylor#773 remove warn throwing since console.warn includes callsites now Update defining-custom-block-nodes.md (ianstormtaylor#776) 0.19.21 update table example to make scope clearer Fixed the link to comparisons, which was broken (ianstormtaylor#769) fix error when dragging void nodes without selection, closes ianstormtaylor#757 fix to depend on prop-types for react 15.5 fix to maintain focus on switching tabs, closes ianstormtaylor#756 update issue template Add "data-key" to root div for the whole document (ianstormtaylor#759) add an issue template
oyeanuj
added a commit
to oyeanuj/slate
that referenced
this pull request
May 4, 2017
* ianstormtaylor/master: Clarifying insertTextByKey description (ianstormtaylor#778) Documenting node's 'getFirstText' & 'getLastText' (ianstormtaylor#779) 0.19.22 fix selection handling for changing tabs, and inside embedded inputs, closes ianstormtaylor#749 fix to restrict window blur/focus handling, closes ianstormtaylor#773 remove warn throwing since console.warn includes callsites now Update defining-custom-block-nodes.md (ianstormtaylor#776) 0.19.21 update table example to make scope clearer Fixed the link to comparisons, which was broken (ianstormtaylor#769) fix error when dragging void nodes without selection, closes ianstormtaylor#757 fix to depend on prop-types for react 15.5 fix to maintain focus on switching tabs, closes ianstormtaylor#756 update issue template Add "data-key" to root div for the whole document (ianstormtaylor#759) add an issue template
No problemo |
oyeanuj
added a commit
to oyeanuj/slate
that referenced
this pull request
May 4, 2017
* ianstormtaylor/master: (81 commits) Address doc suggestion in ianstormtaylor#644 (ianstormtaylor#760) Clarifying insertTextByKey description (ianstormtaylor#778) Documenting node's 'getFirstText' & 'getLastText' (ianstormtaylor#779) 0.19.22 fix selection handling for changing tabs, and inside embedded inputs, closes ianstormtaylor#749 fix to restrict window blur/focus handling, closes ianstormtaylor#773 remove warn throwing since console.warn includes callsites now Update defining-custom-block-nodes.md (ianstormtaylor#776) 0.19.21 update table example to make scope clearer Fixed the link to comparisons, which was broken (ianstormtaylor#769) fix error when dragging void nodes without selection, closes ianstormtaylor#757 fix to depend on prop-types for react 15.5 fix to maintain focus on switching tabs, closes ianstormtaylor#756 update issue template Add "data-key" to root div for the whole document (ianstormtaylor#759) add an issue template add note to document documentation (ianstormtaylor#755) Fix typo in plugin.md (ianstormtaylor#753) update readme ...
oyeanuj
added a commit
to oyeanuj/slate
that referenced
this pull request
May 4, 2017
…-firstonly * ianstormtaylor/master: Address doc suggestion in ianstormtaylor#644 (ianstormtaylor#760) Clarifying insertTextByKey description (ianstormtaylor#778) Documenting node's 'getFirstText' & 'getLastText' (ianstormtaylor#779) 0.19.22 fix selection handling for changing tabs, and inside embedded inputs, closes ianstormtaylor#749 fix to restrict window blur/focus handling, closes ianstormtaylor#773 remove warn throwing since console.warn includes callsites now Update defining-custom-block-nodes.md (ianstormtaylor#776) 0.19.21 update table example to make scope clearer Fixed the link to comparisons, which was broken (ianstormtaylor#769)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sentence read "'renderer" instead of "rendered"