Address doc suggestion in #644 #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @oyeanuj this section refers to the data model, so I think the bit about containing DOM elements is strange? |
|
Yea, I agree. Maybe I'll move it to FAQs and add more details. In general, I feel like a lot of the questions that come up here or on Slack could be answered in a new section called 'Recipes' or maybe added to FAQs. Thoughts? |
|
Adding things to FAQs works for me. I'd also be down to have a |
* ianstormtaylor/master: Clarifying insertTextByKey description (ianstormtaylor#778) Documenting node's 'getFirstText' & 'getLastText' (ianstormtaylor#779) 0.19.22 fix selection handling for changing tabs, and inside embedded inputs, closes ianstormtaylor#749 fix to restrict window blur/focus handling, closes ianstormtaylor#773 remove warn throwing since console.warn includes callsites now Update defining-custom-block-nodes.md (ianstormtaylor#776) 0.19.21 update table example to make scope clearer Fixed the link to comparisons, which was broken (ianstormtaylor#769) fix error when dragging void nodes without selection, closes ianstormtaylor#757 fix to depend on prop-types for react 15.5 fix to maintain focus on switching tabs, closes ianstormtaylor#756 update issue template Add "data-key" to root div for the whole document (ianstormtaylor#759) add an issue template
|
I've moved this to FAQ, reverting the model documentation to what it was. I'll keep in mind the patterns page and create one when I am confident of a few patterns that I am using or seeing floating around. |
|
Perfect! Thank you @oyeanuj 😄 |
oyeanuj
added a commit
to oyeanuj/slate
that referenced
this pull request
May 4, 2017
…-in-node * ianstormtaylor/master: Address doc suggestion in ianstormtaylor#644 (ianstormtaylor#760)
oyeanuj
added a commit
to oyeanuj/slate
that referenced
this pull request
May 4, 2017
* ianstormtaylor/master: (81 commits) Address doc suggestion in ianstormtaylor#644 (ianstormtaylor#760) Clarifying insertTextByKey description (ianstormtaylor#778) Documenting node's 'getFirstText' & 'getLastText' (ianstormtaylor#779) 0.19.22 fix selection handling for changing tabs, and inside embedded inputs, closes ianstormtaylor#749 fix to restrict window blur/focus handling, closes ianstormtaylor#773 remove warn throwing since console.warn includes callsites now Update defining-custom-block-nodes.md (ianstormtaylor#776) 0.19.21 update table example to make scope clearer Fixed the link to comparisons, which was broken (ianstormtaylor#769) fix error when dragging void nodes without selection, closes ianstormtaylor#757 fix to depend on prop-types for react 15.5 fix to maintain focus on switching tabs, closes ianstormtaylor#756 update issue template Add "data-key" to root div for the whole document (ianstormtaylor#759) add an issue template add note to document documentation (ianstormtaylor#755) Fix typo in plugin.md (ianstormtaylor#753) update readme ...
oyeanuj
added a commit
to oyeanuj/slate
that referenced
this pull request
May 4, 2017
…-firstonly * ianstormtaylor/master: Address doc suggestion in ianstormtaylor#644 (ianstormtaylor#760) Clarifying insertTextByKey description (ianstormtaylor#778) Documenting node's 'getFirstText' & 'getLastText' (ianstormtaylor#779) 0.19.22 fix selection handling for changing tabs, and inside embedded inputs, closes ianstormtaylor#749 fix to restrict window blur/focus handling, closes ianstormtaylor#773 remove warn throwing since console.warn includes callsites now Update defining-custom-block-nodes.md (ianstormtaylor#776) 0.19.21 update table example to make scope clearer Fixed the link to comparisons, which was broken (ianstormtaylor#769)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small edit that we discussed in #644.