New macros to help with filter google-test in some platforms #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
🏰 citadel
j-rivero
force-pushed
the
add_test_macros_ign_cmake2
branch
from
b0bd4c7 to
a432891
Compare
azeey
reviewed
Jul 10, 2020
|
The ABI checker failed, I think |
j-rivero
force-pushed
the
add_test_macros_ign_cmake2
branch
from
18a8c78 to
cc88cd1
Compare
azeey
approved these changes
Jul 24, 2020
The new file provides macros that help with filtering googletest on some of the platforms. Signed-off-by: Jose Luis Rivero <[email protected]> Signed-off-by: Louise Poubel <[email protected]>
chapulina
force-pushed
the
add_test_macros_ign_cmake2
branch
from
75a07e1 to
4255cdd
Compare
chapulina
approved these changes
Aug 3, 2020
There was a problem hiding this comment.
LGTM, I'd just like to see a successful round of CI for gazebosim/gz-gui#76 before merging this, but that will be tough without an ign-cmake2 release.
|
This run on Windows check these changes together with ign-gui support: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Across the ignition software we have many cases where tests are not prepared to work on Windows, Mac or both. This PR implements a header providing two macros to be used instead of
TESTmacro from google test:IGN_UTILS_TEST_DISABLED_ON_WIN32creates a google test that will not be run on Windows (although it will be compiled).IGN_UTILS_TEST_ENABLE_ONLY_LINUXcreates a google test that will only be run on Linux (although it will be compiled on all platforms).Testing: using this PR together with ign-gui in:
(needs more test filtering but already disabled most of the failures).