Update SdfGenerator to save link and sensor data to file #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
iche033
added
the
needs upstream release
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
This was referenced Nov 16, 2021
Signed-off-by: Ian Chen <[email protected]>
7 tasks
nkoenig
removed
the
needs upstream release
nkoenig
reviewed
Nov 29, 2021
Signed-off-by: Nate Koenig <[email protected]>
* save lights Signed-off-by: Ian Chen <[email protected]> * fix doc Signed-off-by: Ian Chen <[email protected]> * use updated api Signed-off-by: Ian Chen <[email protected]> * Update SdfGenerator to save joint data to file (#1220) * save joints Signed-off-by: Ian Chen <[email protected]> * use joinPaths Signed-off-by: Ian Chen <[email protected]> * Only output thread_pitch for screw joints Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]>
nkoenig
approved these changes
Nov 30, 2021
mjcarroll
approved these changes
Nov 30, 2021
added 2 commits
December 1, 2021 08:47
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo6 #1201 +/- ##
===============================================
+ Coverage 61.92% 62.25% +0.33%
===============================================
Files 275 275
Lines 22457 22710 +253
===============================================
+ Hits 13906 14138 +232
- Misses 8551 8572 +21
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
depends on:
Summary
Currently the SdfGenerator only write out models and link poses to SDF file. This PR updates the class to pull more data out from ECM and save them to file. This is needed for saving changes to SDF after models are edited by the model editor
Specifically, these new SDF elements are now being updated when the world is saved:
<inertial>and<wind_mode>elements<sensor>element - currently supports only sensor types listed in Add function to convert Sensor DOM to sdf::ElementPtr sdformat#753Test it
sensors_demo.sdforsensorsworldSave world as...Browsebutton or manually input the output sdf file path.OKto saveChecklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge