Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(compogen): improve Title Case capitalization #757

Merged
merged 3 commits into from
Oct 18, 2024
Merged

feat(compogen): improve Title Case capitalization #757

merged 3 commits into from
Oct 18, 2024

Conversation

jvallesm
Copy link
Collaborator

@jvallesm jvallesm commented Oct 18, 2024 •
edited
Loading

Because

This commit

  • Uses Title Case for property titles, too
  • Extends lowercase dictionary
  • Extends uppercase dictionary
  • Respects capitalization of lowercase words if at the end of the title
  • Respects capitalization of uppercase words if pluralized
  • Adds unchanged words
  • Moves dash (-) and underscore (_) replacement to anchor generation

@jvallesm
feat(compogen): use title case for field properties
88c21d0
@jvallesm
feat(compogen): extend Title Case lowercased words
e35adf6 
- Extend lowercase words
- Extend uppercase words
- Respect capitalization of lowercase words if at the end of the title
- Respect capitalization of uppercase words if pluralized
- Add unchanged words
- Move dash (-) and underscore (_) replacement to anchor generation
@jvallesm
chore: regenerate docs
d08bbf2
@jvallesm jvallesm self-assigned this Oct 18, 2024
@jvallesm jvallesm marked this pull request as ready for review October 18, 2024 08:29
@jvallesm
Copy link
Collaborator Author

cc @pinglin

@codecov Codecov
Copy link

codecov bot commented Oct 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.70%. Comparing base (710e4a1) to head (d08bbf2).
Report is 10 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #757      +/-   ##
==========================================
- Coverage   19.76%   19.70%   -0.07%     
==========================================
  Files         321      321              
  Lines       64499    64852     +353     
==========================================
+ Hits        12750    12776      +26     
- Misses      49843    50167     +324     
- Partials     1906     1909       +3
Flag Coverage Δ
unittests 19.70% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jvallesm jvallesm merged commit f956ead into main Oct 18, 2024
19 checks passed
@jvallesm jvallesm deleted the jvalles/feat-improve-title-case branch October 18, 2024 09:28
@droplet-bot droplet-bot mentioned this pull request Oct 18, 2024
Merged
donch1989 pushed a commit that referenced this pull request Oct 22, 2024
@droplet-bot
chore(main): release 0.44.0-beta (#747)
b496f2a 
🤖 I have created a release *beep* *boop*
---


##
[0.44.0-beta](v0.43.2-beta...v0.44.0-beta)
(2024-10-22)


### Features

* **collection:** add concat
([#748](#748))
([04d1467](04d1467))
* **compogen:** improve Title Case capitalization
([#757](#757))
([f956ead](f956ead))
* **component:** update documentation URL to component ID
([#749](#749))
([d4083c2](d4083c2))
* **instillmodel:** implement instill model embedding
([#727](#727))
([17d88bc](17d88bc))
* **run:** run logging data list by requester API
([#730](#730))
([e1e844b](e1e844b))
* **slack:** enable OAuth 2.0 integration
([#758](#758))
([8043dc5](8043dc5))
* standardize the tag naming convention
([#767](#767))
([fd0500f](fd0500f))
* **web:** refactor web operator
([#753](#753))
([700805f](700805f))


### Bug Fixes

* **groq:** use credential-supported model in example
([#752](#752))
([fc90435](fc90435))
* **run:** not return minio error in list pipeline run
([#744](#744))
([4d0afa1](4d0afa1))
* **whatsapp:** fix dir name
([#763](#763))
([029aef9](029aef9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
jvallesm pushed a commit that referenced this pull request Oct 29, 2024
@droplet-bot @jvallesm
chore(main): release 0.44.0-beta (#747)
802117d 
🤖 I have created a release *beep* *boop*
---


##
[0.44.0-beta](v0.43.2-beta...v0.44.0-beta)
(2024-10-22)


### Features

* **collection:** add concat
([#748](#748))
([04d1467](04d1467))
* **compogen:** improve Title Case capitalization
([#757](#757))
([f956ead](f956ead))
* **component:** update documentation URL to component ID
([#749](#749))
([d4083c2](d4083c2))
* **instillmodel:** implement instill model embedding
([#727](#727))
([17d88bc](17d88bc))
* **run:** run logging data list by requester API
([#730](#730))
([e1e844b](e1e844b))
* **slack:** enable OAuth 2.0 integration
([#758](#758))
([8043dc5](8043dc5))
* standardize the tag naming convention
([#767](#767))
([fd0500f](fd0500f))
* **web:** refactor web operator
([#753](#753))
([700805f](700805f))


### Bug Fixes

* **groq:** use credential-supported model in example
([#752](#752))
([fc90435](fc90435))
* **run:** not return minio error in list pipeline run
([#744](#744))
([4d0afa1](4d0afa1))
* **whatsapp:** fix dir name
([#763](#763))
([029aef9](029aef9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgeWilliamStrong GeorgeWilliamStrong Awaiting requested review from GeorgeWilliamStrong GeorgeWilliamStrong is a code owner

@donch1989 donch1989 Awaiting requested review from donch1989 donch1989 is a code owner

@chuang8511 chuang8511 Awaiting requested review from chuang8511

Assignees

@jvallesm jvallesm

Labels
instill component instill vdp
Projects
No open projects
🔮 Instill Core
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jvallesm @droplet-bot