-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable all tests from test_debug.py
on XPU
#2755
Comments
@arunjose696 you can take this issue if you want :) |
This issue is related to a pytorch crash in xpu backend. A issue(pytorch/pytorch#142135) has been raised in pytorch with reproducer. Pytorch team has asked for SYCL compiler to help handle this scenario. The only possible way of a temporary fix to enable the test(test_assert) would be using subprocess as mentioned in this issues first comment
However the subprocess fix would require the kernels (@triton.jit) to be duplicated in a new file for the failing tests as it is not possible to pass jit_function as argument to subprocess.run() . |
This is the last PR to improve UT pass rate for PVC rolling driver. There are 21 remaining failures, which are tracked in #2755 and #2968. Before: ``` debug: passed: 28, failed: 0, skipped: 20, xfailed: 0, total: 48, fixme: 0, pass rate (w/o xfailed): 58.33% interpreter: passed: 6364, failed: 0, skipped: 1, xfailed: 697, total: 7062, fixme: 0, pass rate (w/o xfailed): 99.98% all: passed: 18671, failed: 0, skipped: 23, xfailed: 1309, total: 20003, fixme: 48, pass rate (w/o xfailed): 99.88% ``` After: ``` debug: passed: 28, failed: 0, skipped: 19, xfailed: 0, total: 47, fixme: 0, pass rate (w/o xfailed): 59.57% interpreter: passed: 6365, failed: 0, skipped: 0, xfailed: 697, total: 7062, fixme: 0, pass rate (w/o xfailed): 100.0% all: passed: 18672, failed: 0, skipped: 21, xfailed: 1309, total: 20002, fixme: 48, pass rate (w/o xfailed): 99.89% ``` Signed-off-by: Whitney Tsang <[email protected]>
This comes from #2754
It looks like
abort
is expected here (for XPU), but the Python code is expectingRuntimeError
, which doesn't work right now for some reason.Docs:
Example of a error:
It looks like we can only enable these tests using the previous approach with a subprocess and output analysis (like it was before triton-lang/triton@c54f988#diff-927d321ba6d63660e521f3b604ed7420f27c385efce7b9942183b5152db7b481)
The text was updated successfully, but these errors were encountered: