-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UT] Fix failed cases for tl.dot_scaled
#2968
Comments
This issue is not critical, moving to work on #2961 and see if it still exists with the dot layout implementation. |
This was referenced Dec 11, 2024
LiyangLingIntel
changed the title
[UT] Fix
[UT] Fix failed cases for Jan 3, 2025
test_scaled_dot[128-128-64-False-False-True-e4m3-bf16-4-16-1]
tl.dot_scaled
whitneywhtsang
pushed a commit
that referenced
this issue
Jan 8, 2025
This pull request support dot layout codegen for upcast_mxfp operation, which could be more efficient than previous blocked layout implementation. The 2 skipped tests are failed for L0 runtime error, they will be addressed in a seperate PR #2968.
The failed cases are caused by that after LLVM optimization passes, in the output module, kernel name cannot be recognized by IGC. |
Merged
whitneywhtsang
added a commit
that referenced
this issue
Jan 9, 2025
This is the last PR to improve UT pass rate for PVC rolling driver. There are 21 remaining failures, which are tracked in #2755 and #2968. Before: ``` debug: passed: 28, failed: 0, skipped: 20, xfailed: 0, total: 48, fixme: 0, pass rate (w/o xfailed): 58.33% interpreter: passed: 6364, failed: 0, skipped: 1, xfailed: 697, total: 7062, fixme: 0, pass rate (w/o xfailed): 99.98% all: passed: 18671, failed: 0, skipped: 23, xfailed: 1309, total: 20003, fixme: 48, pass rate (w/o xfailed): 99.88% ``` After: ``` debug: passed: 28, failed: 0, skipped: 19, xfailed: 0, total: 47, fixme: 0, pass rate (w/o xfailed): 59.57% interpreter: passed: 6365, failed: 0, skipped: 0, xfailed: 697, total: 7062, fixme: 0, pass rate (w/o xfailed): 100.0% all: passed: 18672, failed: 0, skipped: 21, xfailed: 1309, total: 20002, fixme: 48, pass rate (w/o xfailed): 99.89% ``` Signed-off-by: Whitney Tsang <[email protected]>
The failed cases changed to these 2 on agama 1057:
|
This issue is pending on feedback from IGC team. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
These are the skiped cases for
tl.dot_scaled
.They failed for "Error during Intel loadBinary: Triton Error [ZE]: 0x78000011", which is ZE_RESULT_ERROR_INVALID_KERNEL_NAME: kernel name is not found in the module.
These cases are tested on agama 1032.
The text was updated successfully, but these errors were encountered: