Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UT pass rate #3130

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Improve UT pass rate #3130

merged 1 commit into from
Jan 9, 2025

Conversation

whitneywhtsang
Copy link
Contributor

@whitneywhtsang whitneywhtsang commented Jan 9, 2025

This is the last PR to improve UT pass rate for PVC rolling driver.
There are 21 remaining failures, which are tracked in #2755 and #2968.

Before:

debug: passed: 28, failed: 0, skipped: 20, xfailed: 0, total: 48, fixme: 0, pass rate (w/o xfailed): 58.33%
interpreter: passed: 6364, failed: 0, skipped: 1, xfailed: 697, total: 7062, fixme: 0, pass rate (w/o xfailed): 99.98%
all: passed: 18671, failed: 0, skipped: 23, xfailed: 1309, total: 20003, fixme: 48, pass rate (w/o xfailed): 99.88%

After:

debug: passed: 28, failed: 0, skipped: 19, xfailed: 0, total: 47, fixme: 0, pass rate (w/o xfailed): 59.57%
interpreter: passed: 6365, failed: 0, skipped: 0, xfailed: 697, total: 7062, fixme: 0, pass rate (w/o xfailed): 100.0%
all: passed: 18672, failed: 0, skipped: 21, xfailed: 1309, total: 20002, fixme: 48, pass rate (w/o xfailed): 99.89%

Signed-off-by: Whitney Tsang <[email protected]>
@whitneywhtsang whitneywhtsang self-assigned this Jan 9, 2025
@@ -1,4 +1,4 @@
https://github.com/intel/intel-xpu-backend-for-triton/issues/2755
# https://github.com/intel/intel-xpu-backend-for-triton/issues/2755
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If not commented out, it would be counted as one skipped UT.

@whitneywhtsang whitneywhtsang marked this pull request as ready for review January 9, 2025 22:08
@whitneywhtsang whitneywhtsang merged commit 3197668 into main Jan 9, 2025
5 checks passed
@whitneywhtsang whitneywhtsang deleted the whitneywhtsang/ut branch January 9, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants