Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pull] master from chromium:master #45

Merged
merged 68 commits into from
Sep 22, 2021
Merged

[pull] master from chromium:master #45

merged 68 commits into from
Sep 22, 2021
+3,069 −2,419

Conversation

pull[bot]
Copy link

@pull pull bot commented Sep 22, 2021 •
edited
Loading

See Commits and Changes for more details.

Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

Prameet Shah and others added 30 commits September 22, 2021 08:13
[Sharesheet] Call CloseCallback after the bubble has closed.
f50ae42 
In SharesheetBubbleView, run CloseCallback after the bubble has fully
closed. Previously, CloseCallback ran before the bubble closed, where
SharesheetBubbleViewDelegate::IsBubbleVisible() could return true.

BUG=b:197588898,b:184720732
TEST=Using Photos, verified that CloseCallback is called after the
     Nearby Share bubble is closed

Change-Id: I26c5175224edbdf7deec7259fa11bcff6ce8507e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3160813
Auto-Submit: Prameet Shah <[email protected]>
Commit-Queue: Melissa Zhang <[email protected]>
Reviewed-by: Melissa Zhang <[email protected]>
Reviewed-by: Alan Ding <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923770}
Add davidbienvenu and jessemckenna as owners of shell_util*
3260637 
Change-Id: I00c0b74a5c7cadc1bc4c441fddd2c1ad88156c2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3174491
Reviewed-by: Greg Thompson <[email protected]>
Commit-Queue: Greg Thompson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923771}
@fergus-dall
Revert "[IntentHandling] Register Chrome app file_handlers"
926d1a4 
This reverts commit 4b04418.

Reason for revert: Broke tast test pita.OpenWith

Original change's description:
> [IntentHandling] Register Chrome app file_handlers
>
> Create IntentFilters for Chrome app file_handlers that allow them
> to show up in GetAppsForIntent() for Intents with files.
>
> Add some functionality to the Intent system like matching against
> directories, which is needed for the include_directories option
> for Chrome app file_handlers which does not exist for SWAs/PWAs.
>
> We add is_directory to IntentFile, rather than try to guess based
> on URL, because we actually have this information in
> FindAppServiceTasks() - the EntryInfo for each file has an
> is_directory field, and this info is from the file system so is
> much more trustworthy.
>
> Change GetAppsForFiles() to accept a list of IntentFiles directly,
> as we would otherwise need to add an array of is_directory bools
> anyway, which is getting a bit cumbersome.
>
> Move behaviour from IsGoodMatchFileHandler() in file_tasks.cc into
> FindAppServiceTasks(). This deals with finding the "best" handler
> within a single app for the given intent - based on product
> decisions. We can't do this in post-processing because we only
> return one handler per app. This allows us to return
> is_generic_file_handler in each IntentLaunchInfo.
>
> Ignore all Chrome app handlers with verbs other than "open_with".
> In Files app, we were already ignoring these handlers and there
> was no way to see them or use them from the UI. This CL extends
> that into the FindAllTasks API, which requires changing a few
> tests which expected handlers for other verbs to be returned.
> This allows a simpler implementation and has no user-visible
> effects.
>
> Drive-by fix a bug in FilterIsForFileExtensions() where we didn't
> account for kAction conditions.
>
> Bug: 1240018
> Change-Id: I170a0597c2c81d1123772c8f3035dc814e6384c1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3153013
> Reviewed-by: Asanka Herath <[email protected]>
> Reviewed-by: Dominick Ng <[email protected]>
> Reviewed-by: Luciano Pacheco <[email protected]>
> Reviewed-by: Maggie Cai <[email protected]>
> Reviewed-by: Lei Zhang <[email protected]>
> Reviewed-by: Erik Chen <[email protected]>
> Commit-Queue: Peter Marshall <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#923217}

Bug: 1240018
No-Presubmit: true
Change-Id: I321457aca8ed57a0dd0cc44cd819cb8dbded8b6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3174622
Commit-Queue: Rubber Stamper <[email protected]>
Owners-Override: Fergus Dall <[email protected]>
Auto-Submit: Fergus Dall <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923772}
Revert "Temporary verbose logs in StatisticsProvider"
fa962de 
This reverts commit 6de6a6a.

Reason for revert: The original issue that motivated this extra
logging is fixed now. So no need to spam the logs with the
details of the statistics provider.

Original change's description:
> Temporary verbose logs in StatisticsProvider
>
> Add temporary verbose logging into implementation of StatisticsProvider
> and related files, in order to be able to track down issues on
> non-dev-mode Chrome OS devices.
>
> Example log snippet after this CL:
>
>   [WARNING:name_value_pairs_parser.cc(128)] Statistics wpsw_cur mentioned in /usr/bin/crossystem: 777073775F637572202020202020202020202020202020203D203120202020202020202020202020202020202020202020202020202020202023205B524F2F696E745D204669726D776172652077726974652070726F74656374206861726477617265207377697463682063757272656E7420706F736974696F6E
>   [WARNING:statistics_provider.cc(321)] Finished loading statistics.
>   [WARNING:device_status_collector.cc(2071)] Statistics wpsw_cur: 1
>   [INFO:status_uploader.cc(216)] Starting status upload: has_device_status = 1 write_protect_switch = 1
>
> This CL will need to be reverted once the root cause of the associated
> bug (b/158252688) is found.
>
> Bug: 1123153
> Change-Id: If718299a8aa8fa7b991168f8a46cccf0bd24f45d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382751
> Commit-Queue: Maksim Ivanov <[email protected]>
> Reviewed-by: Pavol Marko <[email protected]>
> Reviewed-by: Igor <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#804187}

Bug: 1123153
Change-Id: If5e0c3abb5e5ebc0aabd6cb5ac86cb837468b320
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3172693
Commit-Queue: Maksim Ivanov <[email protected]>
Reviewed-by: Pavol Marko <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923773}
@chikamune-cr
Add BFCachePerformanceManagerPolicy to fieldtrial_testing_config.json
f1a56af 
This CL adds BFCachePerformanceManagerPolicy to
BackForwardCacheDesktop before we use it on the stable channel.

Bug: 1171298
Change-Id: Ib94f050030037c8ebcba565f913f6a0098d49e82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3168972
Reviewed-by: Fergal Daly <[email protected]>
Commit-Queue: Minoru Chikamune <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923774}
@freshp86
Settings TypeScript: Migrate languages_page/ folder, part 1.
53572fe 
Migrating all files that are not shared with CrOS Settings. Also adding
TypeScript definitions for the chrome.languageSettingsPrivate API.

Bug: 1234307
Change-Id: I573daad28ad8fead1e779816d9d2c84dbf26836c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3167042
Auto-Submit: dpapad <[email protected]>
Commit-Queue: dpapad <[email protected]>
Reviewed-by: Rebekah Potter <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923775}
Roll Chrome Win32 PGO Profile
4fea540 
Roll Chrome Win32 PGO profile from chrome-win32-main-1632279442-e119a820a19f6d33d16600e5a677626800a516ae.profdata to chrome-win32-main-1632287417-37a9acf8c959dc1213c7a459d9c24c7a474020a8.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: I15d322fd594cce7c454feed0be7ef98ddb41a48a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3174037
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923776}
Roll Chrome Win64 PGO Profile
819c4b2 
Roll Chrome Win64 PGO profile from chrome-win64-main-1632279442-56f2d6d458ac4516b976e38482c24a9afd4e35dd.profdata to chrome-win64-main-1632287417-8daa1a02cbf7f863d5c6903942202cf800abcee7.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I0dcd067873b3da43926414e04092ce371079ffe4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3173956
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923777}
CORS: Make PreflightLoader live longer
d4ca074 
So far, PreflightLoader was deleted once it handles the response header.
And only when the request was not with its headers, PreflightLoader
handles the response body.
This CL makes PreflightLoader live longer and handle the response body
every time.

Change-Id: I969d2065bb8950207b461b579e377f9e9b57142e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3168428
Reviewed-by: Takashi Toyoshima <[email protected]>
Commit-Queue: Ai Nozaki <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923778}
Roll WebRTC from 2d0e82e4cfa7 to 7a9aa356d3b8 (3 revisions)
d3c0ca9 
https://webrtc.googlesource.com/src.git/+log/2d0e82e4cfa7..7a9aa356d3b8

2021-09-22 [email protected] Update WebRTC code version (2021-09-22T04:04:23).
2021-09-22 [email protected] Roll chromium_revision a6f6c26..a9952c3 (923534:923654)
2021-09-21 [email protected] Roll chromium_revision e682171..a6f6c26 (923422:923534)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: [email protected]
Change-Id: I7eb9b149242d7ee7047df712d0dbc29462539fae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3175261
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923779}
Roll abseil_revision b2dc72c17a..de71511109
2fc8815 
Change Log:
https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/b2dc72c17a..de71511109
Full diff:
https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/b2dc72c17a..de71511109

Bug: None
Change-Id: Ic3cf2a0b7e9559867f8694142beddae65596dc49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3173136
Reviewed-by: Danil Chapovalov <[email protected]>
Commit-Queue: Mirko Bonadei <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923780}
Roll androidx from 9NWqy0Mwy... to zzVIaEA3u...
fc938c2 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/androidx-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: [email protected],[email protected]
Change-Id: I9d26b6a2df25f461f704d97d22f09300b28969a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3174755
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923781}
[iOS] Update RequestDesktop flag
2fc86ca 
As the feature won't be launching, this CL updates the code using the
current flag to request MOBILE by default but leaving the architecture
in place if we want to reuse it in the future.

This CL makes the flag refactoring only.
It also removes mobile-google-srp as it is no longer needed.

Bug: 1251138
Change-Id: I0f5f1f4433cfdad4d884e21974dbcd3d57fb75eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3171060
Reviewed-by: Ali Juma <[email protected]>
Commit-Queue: Gauthier Ambard <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923782}
@mfalken
service worker: Simplify ServiceWorkerVersionBrowserTest.
2a9d2f8 
* Make more use of lambdas for callbacks.
* Pass the results to callbacks instead of having separate out_params
  and a `done` closure.
* Make functions return a value rather than the caller passing an
  expected value.
* Remove unnecessary usage of RunOrPostTaskOnThread() now that the
  "service worker core thread" is the UI thread.

Bug: 1138155
Change-Id: I45918f41a20feaba8ad737ad729583a0a802eabe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3168427
Reviewed-by: Asami Doi <[email protected]>
Commit-Queue: Matt Falkenhagen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923783}
@danilsomsikov
Preserve console message category when recreating message in LocalDOM…
8b14317 
…Window

Bug: 1251176
Change-Id: Ibbbfc8161bbcbf2de7a78e273bf28e271767c5ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3172515
Commit-Queue: Danil Somsikov <[email protected]>
Reviewed-by: Nate Chapin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923784}
@wdzierzanowski
Teach WebUIURLLoaderFactory to respect Range header
5138948 
If a WebUI renders a video file, the renderer will issue range requests
when fetching media data. WebUIURLLoaderFactory must respect the Range
header or the loader will not return the correct data.

Bug: 1250387
Change-Id: I7c8ddd8ae50463ffd337964f48f241a73d3e86ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3165712
Reviewed-by: dpapad <[email protected]>
Reviewed-by: Tommy Li <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Reviewed-by: Łukasz Anforowicz <[email protected]>
Commit-Queue: Wojciech Dzierżanowski <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923785}
@nico
blink: Include v8-forward.h in v8_interface_bridge_base.h
eabe8f3 
The file is included in over 1000 TUs.

Bug: 242216
Change-Id: Ifb5e21a11154495ef52b4fc2f736a4215b029d15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3173412
Auto-Submit: Nico Weber <[email protected]>
Commit-Queue: Hans Wennborg <[email protected]>
Reviewed-by: Hans Wennborg <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923786}
@andruud
[mq-4] Implement representation of <mq-range> features
8f8e08e 
This CL makes it possible to internally represent range features,
such as (width > 10px). Such ranges are not yet produced by the
parser, and hence are only reachable from unit tests.

Bug: 1034465
Change-Id: I6b1dc5055c5b2bddd71350b45f1520d059e60009
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3168878
Commit-Queue: Anders Hartvoll Ruud <[email protected]>
Reviewed-by: Kevin Babbitt <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923787}
Roll DevTools Frontend from 0afb0b4f1ea2 to ea86e9e1b101 (4 revisions)
e123ce0 
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0afb0b4f1ea2..ea86e9e1b101

2021-09-22 [email protected] Use type-safe events for DatabaseModel.
2021-09-22 [email protected] Reland "Improve stepping with source maps"
2021-09-22 [email protected] Use type-safe events for IndexedDBModel.
2021-09-22 [email protected] Use type-safe events in WebAudioModel

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: chromium:1228674
Tbr: [email protected]
Change-Id: I5e3b575433724cdcfe44a8827503d429f137dd16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3175222
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923788}
@bmeurer
[DevTools] Rebaseline test expectation after https://crrev.com/c/3099011
ed4f566 


This was previously blocked on making V8 more deterministic.

Bug: chromium:1199701, chromium:1249961
Change-Id: If6f460c7be2561ebc2018f686f9ca91129e67c34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3168633
Auto-Submit: Benedikt Meurer <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Benedikt Meurer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923789}
@tkent-google
Triage new tests in wpt/css/css-ruby/
2811817 
They test ruby-specific display keywords.
This CL has no behavior changes.


Bug: 27659
Change-Id: Id3b682b7a692eb8e706d7905472aa95c3efcee38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3173006
Commit-Queue: Kent Tamura <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Auto-Submit: Kent Tamura <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923790}
[MPArch] Verify that CSP headers are maintained in prerender activation
35bdb4b 
In Prerender activation, FrameTreeNodes are swapped between the primary
and prerendered pages. As such, we need to make sure the relevant parts
of the prerendered FrameTreeNodes are maintained after the swap.

Bug: 1181763
Change-Id: Id4508dce8c4de9e602f2bf17f25c159deae27f19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3075105
Commit-Queue: Harkiran Bolaria <[email protected]>
Reviewed-by: Alexander Timin <[email protected]>
Reviewed-by: Hiroki Nakagawa <[email protected]>
Reviewed-by: Matt Falkenhagen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923791}
Roll src-internal from d5f6874f5f07 to 093dc4735ab8 (6 revisions)
eb2cf17 
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d5f6874f5f07..093dc4735ab8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: I651c6ba84ef0b21c8c3d0610f419c5a184a322ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3175035
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#923792}
Roll Perfetto from df2e9fecdfb2 to c4a2b1fa2b96 (1 revision)
ed23997 
https://android.googlesource.com/platform/external/perfetto.git/+log/df2e9fecdfb2..c4a2b1fa2b96

2021-09-22 [email protected] Merge "ui: Clear search bar when loading a new trace"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: [email protected]
Change-Id: I954847ce0f5d4c36c0a799cacabadd036b03c74f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3174855
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923793}
Roll FreeType from 61903609674f to b4dddd8244fb (3 revisions)
0219226 
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/61903609674f..b4dddd8244fb

2021-09-22 [email protected] [base] Initialize stream memory earlier.
2021-09-22 [email protected] [builds/windows] Revert back to `CreateFileA` only.
2021-09-21 [email protected] * src/bdf/bdflib.c (_bdf_parse_{start,glyphs}): Use appropriate scanner.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/freetype-chromium
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10.20h2-blink-rel;luci.chromium.try:win7-blink-rel
Tbr: [email protected],[email protected],[email protected]
Change-Id: I7f0c058ff0ac47eecd97ea7fb534095583cfcf30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3174513
Commit-Queue: chromium-autoroll <[email protected]>
Commit-Queue: Dominik Röttsches <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Reviewed-by: Dominik Röttsches <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923794}
Update Incognito containment allowlist for ChromeOS.
f082f58 
ChromeOS writes to both |/Default| and |/test-user| folders in tests.
IncognitoProfileContainmentTest is updated to consider this in its
platform independent allow list.

Bug: 1234755
Change-Id: I9fd7a8635a34bb8c2cc85c13cb62f807d01fd141
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3172519
Commit-Queue: Ramin Halavati <[email protected]>
Reviewed-by: David Roger <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923795}
Extension of MultiWorldsV8Reference class
460970a 
Extended MultiWorldsV8Reference class to support v8::Value type as well as v8::Object type.

Change-Id: Ib2b8d9ac8645f5c855ca1dc9a10d86aa1d3b817a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3173580
Reviewed-by: Yuki Shiino <[email protected]>
Commit-Queue: Nono Ohara <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923796}
@sadym-chromium
Reland "[chromedriver] Distinguish between stale element and no element"
f082ba7 
This is a reland of f55edca

Original change's description:
> [chromedriver] Distinguish between stale element and no element
>
> Add a new NO_SUCH_ELEMENT code in call_function.js, and throw
> the new error when the key is missing in the cache.
> Modify test to reflect the change.
>
> Bug: chromedriver:3742
> Change-Id: Ie09fd6cf5a3004b03db08dd6c81ae7f19adf2474
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2700793
> Reviewed-by: John Chen <[email protected]>
> Commit-Queue: Shengfa Lin <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#855037}

Bug: 1249864
Change-Id: If93184fc78a5e9d4b881f21c693be639af814581
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3172796
Auto-Submit: Maksim Sadym <[email protected]>
Commit-Queue: Maksim Sadym <[email protected]>
Reviewed-by: Mathias Bynens <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923797}
Roll Projector App from 7y9MRIzWl... to IBU8QLtkS...
6fab982 
Release_Notes: http://go/projector_app-x20/relnotes/Main/projector_app_nightly_202109220100_RC00.html

https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/projector_app/app/+/IBU8QLtkSw-VH1bf4vgWHEQrgj01kjHDXYlKrPg-2WQC

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/projector-app-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chrome.try:linux-chromeos-chrome
Bug: b/199945656
Tbr: [email protected]
Change-Id: Ie1219f1ce7df54e87668e05cbcc433af7ed604b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3174854
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#923798}
prerender: Dont start prerender when trigger is already in the backgr…
39aaced 
…ound

This CL modifies PrerenderHostRegistry::CreateAndStartHost to stop
prerender from starting when the trigger is already in the background,
and adds a test to verify the behavior.

Bug: 1225142
Change-Id: I6b1cbdc812abc6a7145f87fb33298534489ace74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3168731
Reviewed-by: Hiroki Nakagawa <[email protected]>
Reviewed-by: Lingqi Chi <[email protected]>
Commit-Queue: Huanpo Lin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923799}
chromium-autoroll and others added 25 commits September 22, 2021 11:28
Roll Chrome Win32 PGO Profile
9022033 
Roll Chrome Win32 PGO profile from chrome-win32-main-1632287417-37a9acf8c959dc1213c7a459d9c24c7a474020a8.profdata to chrome-win32-main-1632301116-7516e67a3ba13d4ff4ef2684a73a7674fc47d6d6.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: I4e95405bc04940a372c3f3915c08acb6e471ebb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3175037
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923813}
Roll Perfetto Trace Processor Linux from df2e9fecdfb2 to c4a2b1fa2b96
4ada6ad 
https://android.googlesource.com/platform/external/perfetto.git/+log/df2e9fecdfb2..c4a2b1fa2b96

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: [email protected]
Change-Id: I4960cb77632fa7266428a737d985624c74d035bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3175224
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923814}
[iOS] Launch incognito reauth
1b95bb5 
This CL launches the incognito reauth feature to 100%.

Launch bug: crbug.com/1126916.

Fixed: 1251595
Change-Id: I35a8ba3d28c3f9cdbfa5408a0e65b359166e62ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3172841
Reviewed-by: Olivier Robin <[email protected]>
Reviewed-by: David Jean <[email protected]>
Auto-Submit: Gauthier Ambard <[email protected]>
Commit-Queue: Gauthier Ambard <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923815}
Roll Perfetto Trace Processor Win from df2e9fecdfb2 to c4a2b1fa2b96
19ba888 
https://android.googlesource.com/platform/external/perfetto.git/+log/df2e9fecdfb2..c4a2b1fa2b96

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: [email protected]
Change-Id: Ie7988422b8e6795c9923f9543c1ec6a9044bc584
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3174657
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923816}
Roll DevTools Frontend from de4d15e955d6 to 574cf2dc1914 (2 revisions)
1803bda 
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/de4d15e955d6..574cf2dc1914

2021-09-22 [email protected] Remove default 'any' from EventTargetEvent
2021-09-22 [email protected] [cleanup] Remove unused event parameters from listeners

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: chromium:1228674
Tbr: [email protected]
Change-Id: I1d621e5b314ff0af12fe98760ddabd27be491b64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3175460
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923817}
[iOS] Add metric for incognito reauth success
9473e36 
Logs the result of the biometric reauth for incognito.

Fixed: 1251597
Change-Id: I0b9fa3de137e86a1bde76833ad852c0541e9332a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3172875
Auto-Submit: Gauthier Ambard <[email protected]>
Reviewed-by: Olivier Robin <[email protected]>
Commit-Queue: Gauthier Ambard <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923818}
@thiemonagel
Revert "Reland "[chromedriver] Distinguish between stale element and …
c1e79df 
…no element""

This reverts commit f082ba7.

Reason for revert: Likely culprit of webdriver_tests_suite failures in https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel

https://ci.chromium.org/ui/p/chromium/builders/ci/linux-trusty-rel/28251

expand_more
error
external/wpt/webdriver/tests/element_click/stale.py>>test_is_stale
ID: ninja://:webdriver_wpt_tests/external/wpt/webdriver/tests/element_click/stale.py>>test_is_stale | builder linux-trusty-rel test_suite webdriver_tests_suite os Ubuntu-14.04
expand_more
N/A run #1 unexpectedly failed in task: 5625e2c4f8c93e11
expand_more
Tags:
json_format_status:	FAIL
orig_format:	chromium_json_test_results
step_name:	webdriver_tests_suite on Ubuntu-14.04
test_name:	external/wpt/webdriver/tests/element_click/stale.py>>test_is_stale
expand_more
error
external/wpt/webdriver/tests/element_send_keys/send_keys.py>>test_stale_element
ID: ninja://:webdriver_wpt_tests/external/wpt/webdriver/tests/element_send_keys/send_keys.py>>test_stale_element
content_copy | builder linux-trusty-rel test_suite webdriver_tests_suite os Ubuntu-14.04
expand_more
N/A run #1 unexpectedly failed in task: 5625e2c37643c011
expand_more
Tags:
json_format_status:	FAIL
orig_format:	chromium_json_test_results
step_name:	webdriver_tests_suite on Ubuntu-14.04
test_name:	external/wpt/webdriver/tests/element_send_keys/send_keys.py>>test_stale_element

Original change's description:
> Reland "[chromedriver] Distinguish between stale element and no element"
>
> This is a reland of f55edca
>
> Original change's description:
> > [chromedriver] Distinguish between stale element and no element
> >
> > Add a new NO_SUCH_ELEMENT code in call_function.js, and throw
> > the new error when the key is missing in the cache.
> > Modify test to reflect the change.
> >
> > Bug: chromedriver:3742
> > Change-Id: Ie09fd6cf5a3004b03db08dd6c81ae7f19adf2474
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2700793
> > Reviewed-by: John Chen <[email protected]>
> > Commit-Queue: Shengfa Lin <[email protected]>
> > Cr-Commit-Position: refs/heads/master@{#855037}
>
> Bug: 1249864
> Change-Id: If93184fc78a5e9d4b881f21c693be639af814581
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3172796
> Auto-Submit: Maksim Sadym <[email protected]>
> Commit-Queue: Maksim Sadym <[email protected]>
> Reviewed-by: Mathias Bynens <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#923797}

Bug: 1249864
Change-Id: Ib7dd9ad25890fe9ff816294d496b07409de71bec
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3172849
Bot-Commit: Rubber Stamper <[email protected]>
Owners-Override: Thiemo Nagel <[email protected]>
Auto-Submit: Thiemo Nagel <[email protected]>
Commit-Queue: Thiemo Nagel <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923819}
Update V8 to version 9.6.79.
ad553ae 
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/499c3489..b923dba8

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

[email protected],[email protected],[email protected]

Change-Id: I832df07b5fb21fac2f28f3006a275a4ec431a67e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3175365
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#923820}
Roll WebRTC from f72c06419fe8 to 070dbe13d104 (1 revision)
48d1e4a 
https://webrtc.googlesource.com/src.git/+log/f72c06419fe8..070dbe13d104

2021-09-22 [email protected] Roll chromium_revision a9952c3..39bb5dc (923654:923768)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: [email protected]
Change-Id: I15c2e451e184699a170ff1ff455a9ee25c64bd25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3174858
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923821}
Roll src-internal from 0ef0fa39e726 to 36ebb13c47bd (3 revisions)
037fac0 
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0ef0fa39e726..36ebb13c47bd

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1227330
Tbr: [email protected]
Change-Id: I60c1387254f3bb6491b8e4bf33a962ebe1f1aaa4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3175500
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#923822}
@thiemonagel
[Sheriff] Disable broken ash file manager tests
59b2215 
Disabling checkImportCrostiniImageDisabled and
checkInstallWithLinuxDisabledForDebianFile.

Bug: 1251932
Change-Id: I4765277b1bb904b13a847aed7f11e378e9a585cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3172643
Reviewed-by: Christian Dullweber <[email protected]>
Commit-Queue: Thiemo Nagel <[email protected]>
Owners-Override: Thiemo Nagel <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923823}
[iOS][Passwords] Move Add button in toolbar to SettingsRootTableViewC…
8d4ce74 
…ontroller

This CL moves the code for adding "Add" and "Edit" button in the toolbar
to the SettingsRootTableViewController. It would be used to render
toolbar items in the Payments, Address, Search Engine and Languages
settings.

Bug: 1226006
Change-Id: I78042193f173ffc44538dda2797df547fa58c0c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3172614
Reviewed-by: Gauthier Ambard <[email protected]>
Commit-Queue: Vidhan Jain <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923824}
@andruud
[mq-4] Implement ranged evaluation
9783405 
We need to support all of these forms (using < as a stand-in for
any valid operator):

  (feature)
  (feature: value)
  (feature < value)
  (value < feature)
  (value1 < feature < value2)

For (value < feature), we effectively convert it to the same
expression but with the feature on the left side, and then evaluate
normally.

For (value1 < feature < value2), we simply call the feature evaluation
function twice.

Bug: 1034465
Change-Id: If57bc994e2a3c860265d54e0e7afcd06b85f51df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3168637
Commit-Queue: Anders Hartvoll Ruud <[email protected]>
Reviewed-by: Kevin Babbitt <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923825}
[iOS][Passwords] Move Edit to toolbar for Payments Settings
de22f9b 
This CL utilizes the logic of "Add" and "Edit" in the toolbar from the
SettingsRootTableViewController instead of add button created in
AutofillCreditCardTableViewController. The new positioning is valid only
when the password_manager::features::kSupportForAddPasswordsInSettings
is enabled.

Mocks: https://docs.google.com/presentation/d/1X79wp1xX9QTwCiqnHingswAfaiwmdysNTI7VZ313IJA/edit?resourcekey=0--WwLl01uAB8RlH1aIixU6A#slide=id.ge3009aec57_0_2

Bug: 1226006
Change-Id: I155d8a9a7940d8535e3a47482af1ce6942ad77bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3172517
Reviewed-by: Gauthier Ambard <[email protected]>
Commit-Queue: Vidhan Jain <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923826}
@phuang
cc::PaintOpBuffer: make Deserialize() do not overwrite
8dff88d 
RasterDecoder may call cc::PaintOpBuffer::Deserialize() multiple
times before using the content, so we need PaintOpBuffer::Deserialize()
do not overwrite.

Bug: 1237140
Change-Id: I96b8e50023390d67b2104e21f5f0d959550f2e52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3173694
Auto-Submit: Peng Huang <[email protected]>
Commit-Queue: Vasiliy Telezhnikov <[email protected]>
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923827}
@mysteryDate
Remove "region" from the mouse event and touch idls
5d3f03b 
Now that the Canvas HitRegions feature has been removed, these are
dead code.
crrev.com/c/3166851

Bug: 1249855
Change-Id: I04120699f669db1ffdcb1501c1fe2080ccd55a64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3170063
Reviewed-by: Justin Novosad <[email protected]>
Reviewed-by: Aaron Krajeski <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Dave Tapuska <[email protected]>
Commit-Queue: Aaron Krajeski <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923828}
@maxlgu
[BasicCardDeprecation] Add about flag for basic-card
ad63b07 
Add a "enable-payment-request-basic-card" flag to about://flags, enabled
by default. This is to make it easier for developers to test a
environment without the basic-card payment method, in preparation of the
upcoming deprecation.

Bug: 1251421
Change-Id: Id1f56283fe782965505a8c8c11b9b716f630c929
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3170060
Auto-Submit: Liquan (Max) Gu <[email protected]>
Commit-Queue: Rouslan Solomakhin <[email protected]>
Reviewed-by: Rouslan Solomakhin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923829}
Migrate ChromeShelfController from SplitSettingsSync
03f6cdf 
Replaces SplitSettingsSync with SyncSettingsCategorization in
chrome_shelf_prefs.cc and the ChromeShelfController tests.
* Old ChromeShelfControllerTest is renamed to
  ChromeShelfControllerTestBase. It is used as a base class by other
  test fixtures, but doesn't have any tests itself.
* New ChromeShelfControllerTest is added. This test fixture is
  a subclass of ChromeShelfControllerTestBase and has a boolean
  parameter to test with SyncSettingsCategorization enabled/disabled.
* ChromeShelfControllerSplitSettingsSyncTest is renamed to
  ChromeShelfControllerSyncConsentOptionalTest and enables both
  SyncSettingsCategorization and SyncConsentOptional, since this test
  checks the flow where OS sync is off.

Bug: 1227693, 1085597
Change-Id: I77d32c7f531a69d128642e8ae8ea77a86c0b9063
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3162282
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Roman Sorokin [CET] <[email protected]>
Commit-Queue: Boris Sazonov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923830}
@ArthurSonzogni
Fix compilation of font_loader_unittest.cc on x86 CPU.
7a34e55 
When compiled with target_cpu=x86 on Linux, the following error appears:
```
../../components/services/font/font_loader_unittest.cc:51:29: error:
non-constant-expression cannot be narrowed from type 'int64_t' (aka
'long long') to 'FT_Long' (aka 'long') in initializer list
[-Wc++11-narrowing]
```
        file_size};
        ^~~~~~~~~

../../components/services/font/font_loader_unittest.cc:51:29: note:
insert an explicit cast to silence this issue

        file_size};
        ^~~~~~~~~
        static_cast<FT_Long>( )
```

This patch follows compiler's suggestion, silencing the warning.

Bug: None
Change-Id: Ib907b9ebd40eabd0c659c95d6bcd663adbacd8b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3173226
Commit-Queue: Arthur Sonzogni <[email protected]>
Auto-Submit: Arthur Sonzogni <[email protected]>
Reviewed-by: Dominik Röttsches <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923831}
[ios] Update disabled header/footer item text color
8bdeab0 
Changed from secondary to quaternary.

Bug: 1251606
Change-Id: Ifd468a78ac89bbb441d5aa917e1e844ef80d7f94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3172522
Auto-Submit: David Jean <[email protected]>
Commit-Queue: Gauthier Ambard <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923832}
@junov
Add a crash key for PaintOp deserialization errors
0d71d6d 
BUG=1245368, 1019634

Change-Id: I2dd0e3bf1fdddc16809696cecf946908d712a664
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3173873
Reviewed-by: Robert Sesek <[email protected]>
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Commit-Queue: Justin Novosad <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923833}
Clear page end time in page load tracker when restoring from BFCache.
b948f17 
The previous page end time is no longer relevant to the restored page.
Bug: 1247570

Change-Id: I1f80035c9c90265d66f38fd63375eb59d1be09d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3173572
Reviewed-by: Nicolás Peña Moreno <[email protected]>
Commit-Queue: Darren W <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923834}
@dtapuska
Rewrite more usages of GetAllFrames
217f04d 
- The rest of tests now use ChildFrameAt() or ForEachRenderFrameHost
where appropriate.

BUG=1208438

Change-Id: I8f2b2ebb1a893beb69ba56708b4d49fa7d55e81d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3169111
Commit-Queue: Dave Tapuska <[email protected]>
Reviewed-by: Colin Blundell <[email protected]>
Reviewed-by: Wez <[email protected]>
Reviewed-by: Karan Bhatia <[email protected]>
Reviewed-by: Kevin McNee <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923835}
@thiemonagel
[Sheriff] Disable flaky extension test ClickingContextMenuButton
529a991 
Disabling for Linux.

Bug: 1251961
Change-Id: Id80306e92379f4d2ece92e73d4b8342896de5be4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3172644
Commit-Queue: Thiemo Nagel <[email protected]>
Commit-Queue: Theodore Olsauskas-Warren <[email protected]>
Owners-Override: Thiemo Nagel <[email protected]>
Auto-Submit: Thiemo Nagel <[email protected]>
Reviewed-by: Theodore Olsauskas-Warren <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923836}
Roll Chrome Mac PGO Profile
2d3f312 
Roll Chrome Mac PGO profile from chrome-mac-main-1632287417-43f48902caa07e02109bac370cfac87feea03394.profdata to chrome-mac-main-1632311929-e14285d2cfbadc01189fb036e5b9a5705365af76.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: Idc8fea346efc6918046b6efcb6ff4702eeba4d67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3175427
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923837}
@pull pull bot added the ⤵️ pull label Sep 22, 2021
@pull pull bot merged commit 2d3f312 into jamlee-t:master Sep 22, 2021
pull bot pushed a commit that referenced this pull request Sep 25, 2021
Revert "Privatise unnecessarily public current_input_method in"
37ea471 
This reverts commit 77e9679.

Reason for revert:
Likely cause of failure
Step "browser_tests on Ubuntu-18.04" failing on builder "linux-chromeos-chrome"

The failure is a crash in browser_tests.

This failure is fairly but not perfectly consistent.  In three of the last four runs on this bot, browser_tests failed with something in the NativeInputMethodEngineTest.EmojiSuggestion* suite.  It's not always the same test that fails each time.  Nevertheless, this is pretty indicative that nowadays something is wrong in this suite.  This is the obvious candidate, submitted right when the test became mostly-failing.

Here is the first failure as an example:
Retrying 1 test (retry #0)
[ RUN      ] NativeInputMethodEngineTest.EmojiSuggestionDisabledReasonkUrlOrAppNotAllowed
2021-09-24T11:30:01.258384Z WARNING browser_tests[27592:27592]: [audio_manager_linux.cc(60)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized.
[434.616] default_socket.cc:58    /run/perfetto/ exists but cannot be accessed. Falling back on /tmp/  (errno: 13, Permission denied)
2021-09-24T11:30:01.293097Z WARNING browser_tests[27592:27609]: [wallpaper_decoder.cc(29)] Failed reading file
2021-09-24T11:30:01.304548Z ERROR browser_tests[27592:27592]: [print_job_reporting_service_factory.cc(47)] DMToken must be valid
2021-09-24T11:30:01.309314Z ERROR browser_tests[27592:27592]: [proximity_auth_profile_pref_manager.cc(194)] Failed to find local state prefs for current user.
2021-09-24T11:30:01.332070Z WARNING browser_tests[27592:27592]: [remote_commands_service.cc(188)] Client is not registered.
2021-09-24T11:30:01.358975Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB
2021-09-24T11:30:01.359074Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Cache: 0MB
2021-09-24T11:30:01.359110Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.README: 0MB
2021-09-24T11:30:01.359138Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB
2021-09-24T11:30:01.359147Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.WebData: 0MB
2021-09-24T11:30:01.359429Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.CodeCache: 0MB
2021-09-24T11:30:01.359547Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SiteCharacteristicsDatabase: 0MB
2021-09-24T11:30:01.359581Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Favicons: 0MB
2021-09-24T11:30:01.359621Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginDataForAccount: 0MB
2021-09-24T11:30:01.360073Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.GCache: 0MB
2021-09-24T11:30:01.360118Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.History: 0MB
2021-09-24T11:30:01.360147Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB
2021-09-24T11:30:01.360161Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB
2021-09-24T11:30:01.360173Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB
2021-09-24T11:30:01.360234Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB
2021-09-24T11:30:01.360415Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SyncData: 0MB
2021-09-24T11:30:01.361882Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOCK: 0MB
2021-09-24T11:30:01.361936Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginData: 0MB
2021-09-24T11:30:01.361964Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOG: 0MB
2021-09-24T11:30:01.362091Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB
2021-09-24T11:30:01.412518Z ERROR browser_tests[27592:27592]: [plugin_vm_manager_impl.cc(150)] New session has dispatcher unexpected already running. Perhaps Chrome crashed?
2021-09-24T11:30:01.433615Z INFO browser_tests[27592:27592]: [key_permissions_manager_impl.cc(509)] One-time key permissions migration started for token: 0.
2021-09-24T11:30:01.451071Z WARNING browser_tests[27592:27592]: [drivefs_session.cc(65)] DriveFs mount failed with error: 3
2021-09-24T11:30:01.458878Z WARNING browser_tests[27592:27592]: [login_unlock_throughput_recorder.cc(58)] Zero frames expected in login animation throughput data
2021-09-24T11:30:01.464809Z INFO browser_tests[27592:27592]: [android_sms_pairing_state_tracker_impl.cc(71)] No Pairing cookie found
2021-09-24T11:30:01.470495Z INFO browser_tests[27592:27592]: [ui_test_utils.cc(224)] NavigateToURL: chrome://newtab/
2021-09-24T11:30:01.473373Z WARNING browser_tests[27592:27639]: [google_brand_chromeos.cc(40)] Brand code file missing: /opt/oem/etc/BRAND_CODE
2021-09-24T11:30:01.535229Z ERROR browser_tests[27592:27639]: [als_reader.cc(52)] Missing num of als
2021-09-24T11:30:01.535643Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(230)] crbug.com/1216328: Checking Bluetooth availability started. Please report if there is no report that this ends.
2021-09-24T11:30:01.535680Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(233)] crbug.com/1216328: Checking Bluetooth availability ended.
2021-09-24T11:30:01.535688Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(236)] crbug.com/1216328: Checking default browser status started. Please report if there is no report that this ends.
2021-09-24T11:30:01.535695Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(240)] crbug.com/1216328: Checking default browser status ended.
2021-09-24T11:30:01.555145Z INFO browser_tests[27592:27592]: [key_permissions_manager_impl.cc(534)] One-time key permissions migration succeeded for token: 0.
BrowserTestBase received signal: Segmentation fault. Backtrace:
#0 0x556151f72449 base::debug::CollectStackTrace()
#1 0x556151ed9d73 base::debug::StackTrace::StackTrace()
#2 0x5561525e4683 content::(anonymous namespace)::DumpStackTraceSignalHandler()
#3 0x7f7dd56e2040 (/lib/x86_64-linux-gnu/libc-2.27.so+0x3f03f)
#4 0x5561556c8304 ChromeOmniboxNavigationObserver::DidFinishNavigation()
#5 0x5561503c8362 content::WebContentsImpl::WebContentsObserverList::NotifyObservers<>()
#6 0x5561503d05f0 content::WebContentsImpl::DidFinishNavigation()
#7 0x5561502a5093 content::NavigationRequest::~NavigationRequest()
#8 0x5561502a59dc content::NavigationRequest::~NavigationRequest()
#9 0x5561502b8919 content::Navigator::DidNavigate()
#10 0x5561502caeed content::RenderFrameHostImpl::DidCommitNavigationInternal()
#11 0x5561502ca24a content::RenderFrameHostImpl::DidCommitNavigation()
#12 0x5561502e9d60 base::internal::FunctorTraits<>::Invoke<>()
#13 0x5561502e9d0f base::internal::Invoker<>::RunOnce()
#14 0x55614fd53470 content::mojom::NavigationClient_CommitFailedNavigation_ForwardToCallback::Accept()
#15 0x55615301c6e0 mojo::InterfaceEndpointClient::HandleValidatedMessage()
#16 0x5561530201e0 mojo::MessageDispatcher::Accept()
#17 0x55615301d435 mojo::InterfaceEndpointClient::HandleIncomingMessage()
#18 0x5561531dc3e2 IPC::(anonymous namespace)::ChannelAssociatedGroupController::AcceptOnEndpointThread()
#19 0x55615301e323 base::internal::Invoker<>::RunOnce()
#20 0x556151f35f23 base::TaskAnnotator::RunTask()
#21 0x556151f467b3 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl()
#22 0x556151f46569 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork()
#23 0x556151f46b32 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork()
#24 0x556151fa9c4b base::MessagePumpLibevent::Run()
#25 0x556151f46d6d base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run()
#26 0x556151f18c1b base::RunLoop::Run()
#27 0x556151ec159d InProcessBrowserTest::RunUntilBrowserProcessQuits()
#28 0x556151ec207f InProcessBrowserTest::QuitBrowsers()
#29 0x556151ec1fce InProcessBrowserTest::PostRunTestOnMainThread()
#30 0x5561525e3d34 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#31 0x556152012479 ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#32 0x55615201197e ChromeBrowserMainParts::PreMainMessageLoopRun()
#33 0x55614efa9b98 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
#34 0x5561500381cd content::BrowserMainLoop::PreMainMessageLoopRun()
#35 0x5561503a1a9c content::StartupTaskRunner::RunAllTasksNow()
#36 0x556150037e4a content::BrowserMainLoop::CreateStartupTasks()
#37 0x55615003a147 content::BrowserMainRunnerImpl::Initialize()
#38 0x556150036912 content::BrowserMain()
#39 0x556150bf6aed content::RunBrowserProcessMain()
#40 0x556150bf79bd content::ContentMainRunnerImpl::RunBrowser()
#41 0x556150bf752e content::ContentMainRunnerImpl::Run()
#42 0x556150bf5b38 content::RunContentProcess()
#43 0x556150bf5c08 content::ContentMain()
#44 0x5561525e3543 content::BrowserTestBase::SetUp()
#45 0x556151ec12c1 InProcessBrowserTest::SetUp()
#46 0x55614e1c8786 ash::input_method::(anonymous namespace)::NativeInputMethodEngineTest::SetUp()
#47 0x55614f308e8f testing::Test::Run()
#48 0x55614f3097c5 testing::TestInfo::Run()
#49 0x55614f309f21 testing::TestSuite::Run()
#50 0x55614f313798 testing::internal::UnitTestImpl::RunAllTests()
#51 0x55614f31338b testing::UnitTest::Run()
#52 0x556151fd7ff2 base::TestSuite::Run()
#53 0x556151e96409 BrowserTestSuiteRunnerChromeOS::RunTestSuite()
#54 0x556152613c1f content::LaunchTests()
#55 0x556151e98224 LaunchChromeTests()
#56 0x556151e9638b main
#57 0x7f7dd56c4bf7 __libc_start_main
#58 0x55614cca11ea _start
from
https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/17628

Here is the fourth:  (different test in the same suite, different stack trace):
[ RUN      ] NativeInputMethodEngineTest.EmojiSuggestionDisabledReasonkUserSettingsOff
2021-09-24T16:19:05.593039Z WARNING browser_tests[31407:31407]: [audio_manager_linux.cc(60)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized.
[959.207] default_socket.cc:58    /run/perfetto/ exists but cannot be accessed. Falling back on /tmp/  (errno: 13, Permission denied)
2021-09-24T16:19:05.646514Z WARNING browser_tests[31407:31423]: [wallpaper_decoder.cc(29)] Failed reading file
2021-09-24T16:19:05.673272Z ERROR browser_tests[31407:31407]: [print_job_reporting_service_factory.cc(47)] DMToken must be valid
2021-09-24T16:19:05.678360Z ERROR browser_tests[31407:31407]: [proximity_auth_profile_pref_manager.cc(194)] Failed to find local state prefs for current user.
2021-09-24T16:19:05.728926Z WARNING browser_tests[31407:31407]: [remote_commands_service.cc(188)] Client is not registered.
2021-09-24T16:19:05.763864Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB
2021-09-24T16:19:05.763999Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Cache: 0MB
2021-09-24T16:19:05.764049Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.README: 0MB
2021-09-24T16:19:05.764094Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB
2021-09-24T16:19:05.764120Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.WebData: 0MB
2021-09-24T16:19:05.764270Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.CodeCache: 0MB
2021-09-24T16:19:05.764446Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SiteCharacteristicsDatabase: 0MB
2021-09-24T16:19:05.765718Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Favicons: 0MB
2021-09-24T16:19:05.765751Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginDataForAccount: 0MB
2021-09-24T16:19:05.766067Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.GCache: 0MB
2021-09-24T16:19:05.766094Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.History: 0MB
2021-09-24T16:19:05.766115Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB
2021-09-24T16:19:05.766123Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB
2021-09-24T16:19:05.766131Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB
2021-09-24T16:19:05.766199Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB
2021-09-24T16:19:05.766336Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LocalStorage: 0MB
2021-09-24T16:19:05.766472Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SyncData: 0MB
2021-09-24T16:19:05.766498Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOCK: 0MB
2021-09-24T16:19:05.766524Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginData: 0MB
2021-09-24T16:19:05.766552Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOG: 0MB
2021-09-24T16:19:05.766909Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB
2021-09-24T16:19:05.880798Z ERROR browser_tests[31407:31407]: [plugin_vm_manager_impl.cc(150)] New session has dispatcher unexpected already running. Perhaps Chrome crashed?
2021-09-24T16:19:05.921761Z INFO browser_tests[31407:31407]: [key_permissions_manager_impl.cc(509)] One-time key permissions migration started for token: 0.
2021-09-24T16:19:05.932877Z WARNING browser_tests[31407:31407]: [drivefs_session.cc(65)] DriveFs mount failed with error: 3
2021-09-24T16:19:05.951965Z WARNING browser_tests[31407:31407]: [login_unlock_throughput_recorder.cc(58)] Zero frames expected in login animation throughput data
2021-09-24T16:19:05.973007Z INFO browser_tests[31407:31407]: [android_sms_pairing_state_tracker_impl.cc(71)] No Pairing cookie found
2021-09-24T16:19:05.977396Z WARNING browser_tests[31407:31428]: [google_brand_chromeos.cc(40)] Brand code file missing: /opt/oem/etc/BRAND_CODE
2021-09-24T16:19:05.981581Z INFO browser_tests[31407:31407]: [ui_test_utils.cc(224)] NavigateToURL: chrome://newtab/
2021-09-24T16:19:06.072941Z ERROR browser_tests[31407:31457]: [als_reader.cc(52)] Missing num of als
2021-09-24T16:19:06.073283Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(230)] crbug.com/1216328: Checking Bluetooth availability started. Please report if there is no report that this ends.
2021-09-24T16:19:06.073310Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(233)] crbug.com/1216328: Checking Bluetooth availability ended.
2021-09-24T16:19:06.073337Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(236)] crbug.com/1216328: Checking default browser status started. Please report if there is no report that this ends.
2021-09-24T16:19:06.073358Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(240)] crbug.com/1216328: Checking default browser status ended.
2021-09-24T16:19:06.085536Z INFO browser_tests[31407:31407]: [key_permissions_manager_impl.cc(534)] One-time key permissions migration succeeded for token: 0.
BrowserTestBase received signal: Segmentation fault. Backtrace:
#0 0x564f24b8af29 base::debug::CollectStackTrace()
#1 0x564f24af2843 base::debug::StackTrace::StackTrace()
#2 0x564f251fd373 content::(anonymous namespace)::DumpStackTraceSignalHandler()
#3 0x7f03d338d040 (/lib/x86_64-linux-gnu/libc-2.27.so+0x3f03f)
#4 0x564f282e0d94 ChromeOmniboxNavigationObserver::DidFinishNavigation()
#5 0x564f22fe1042 content::WebContentsImpl::WebContentsObserverList::NotifyObservers<>()
#6 0x564f22fe92d0 content::WebContentsImpl::DidFinishNavigation()
#7 0x564f22ebdd73 content::NavigationRequest::~NavigationRequest()
#8 0x564f22ebe6bc content::NavigationRequest::~NavigationRequest()
#9 0x564f22ed15f9 content::Navigator::DidNavigate()
#10 0x564f22ee3bcd content::RenderFrameHostImpl::DidCommitNavigationInternal()
#11 0x564f22ee2f2a content::RenderFrameHostImpl::DidCommitNavigation()
#12 0x564f22f02a40 base::internal::FunctorTraits<>::Invoke<>()
#13 0x564f22f029ef base::internal::Invoker<>::RunOnce()
#14 0x564f2296c430 content::mojom::NavigationClient_CommitFailedNavigation_ForwardToCallback::Accept()
#15 0x564f25c35100 mojo::InterfaceEndpointClient::HandleValidatedMessage()
#16 0x564f25c38c00 mojo::MessageDispatcher::Accept()
#17 0x564f25c35e55 mojo::InterfaceEndpointClient::HandleIncomingMessage()
#18 0x564f25df4e02 IPC::(anonymous namespace)::ChannelAssociatedGroupController::AcceptOnEndpointThread()
#19 0x564f25c36d43 base::internal::Invoker<>::RunOnce()
#20 0x564f24b4ea03 base::TaskAnnotator::RunTask()
#21 0x564f24b5f293 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl()
#22 0x564f24b5f049 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork()
#23 0x564f24b5f612 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork()
#24 0x564f24bc28cb base::MessagePumpLibevent::Run()
#25 0x564f24b5f84d base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run()
#26 0x564f24b316fb base::RunLoop::Run()
#27 0x564f22f433f3 content::BrowserTaskExecutor::RunAllPendingTasksOnThreadForTesting()
#28 0x564f2522df45 content::RunAllPendingInMessageLoop()
#29 0x564f24adaa96 InProcessBrowserTest::PostRunTestOnMainThread()
#30 0x564f251fca24 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#31 0x564f24c2b0f9 ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#32 0x564f24c2a5fe ChromeBrowserMainParts::PreMainMessageLoopRun()
#33 0x564f21bc1f38 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
#34 0x564f22c510ed content::BrowserMainLoop::PreMainMessageLoopRun()
#35 0x564f22fba77c content::StartupTaskRunner::RunAllTasksNow()
#36 0x564f22c50d6a content::BrowserMainLoop::CreateStartupTasks()
#37 0x564f22c53067 content::BrowserMainRunnerImpl::Initialize()
#38 0x564f22c4f832 content::BrowserMain()
#39 0x564f2380f5bd content::RunBrowserProcessMain()
#40 0x564f2381048d content::ContentMainRunnerImpl::RunBrowser()
#41 0x564f2380fffe content::ContentMainRunnerImpl::Run()
#42 0x564f2380e608 content::RunContentProcess()
#43 0x564f2380e6d8 content::ContentMain()
#44 0x564f251fc233 content::BrowserTestBase::SetUp()
#45 0x564f24ad9d91 InProcessBrowserTest::SetUp()
#46 0x564f20de0a86 ash::input_method::(anonymous namespace)::NativeInputMethodEngineTest::SetUp()
#47 0x564f21f21e4f testing::Test::Run()
#48 0x564f21f22785 testing::TestInfo::Run()
#49 0x564f21f22ee1 testing::TestSuite::Run()
#50 0x564f21f2c758 testing::internal::UnitTestImpl::RunAllTests()
#51 0x564f21f2c34b testing::UnitTest::Run()
#52 0x564f24bf0c72 base::TestSuite::Run()
#53 0x564f24aaeed9 BrowserTestSuiteRunnerChromeOS::RunTestSuite()
#54 0x564f2522c62f content::LaunchTests()
#55 0x564f24ab0cf4 LaunchChromeTests()
#56 0x564f24aaee5b main
#57 0x7f03d336fbf7 __libc_start_main
#58 0x564f1f8b94ea _start
from
https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/17631

Original change's description:
> Privatise unnecessarily public current_input_method in
> InputMethodManagerImpl::StateImpl.
>
> This involves replacing some direct pokes of current_input_method
> with public GetCurrentInputMethod() that employs a fallback onto
> InputMethodUtil::GetFallbackInputMethodDescriptor() when ID is
> blank. This should be more reasonable and consistent.
>
> Bug: 1134465
> Change-Id: I2c423a58547cc7249efdf8056624623998765aba
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3177760
> Commit-Queue: Bao-Duy Tran <[email protected]>
> Reviewed-by: Keith Lee <[email protected]>
> Reviewed-by: Curtis McMullan <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#924702}

Bug: 1134465
Change-Id: I6144a0ebd7472f31d4b937d9e99b6a6c8bc0eee1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3182806
Auto-Submit: Mark Pearson <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Mark Pearson <[email protected]>
Owners-Override: Mark Pearson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#924810}
pull bot pushed a commit that referenced this pull request Sep 27, 2021
Reland "Privatise unnecessarily public current_input_method in"
5d7a9d2 
This reverts commit 37ea471.

Reason for revert: Reverted CL is unrelated to the cited "reason for revert".

Original change's description:
> Revert "Privatise unnecessarily public current_input_method in"
>
> This reverts commit 77e9679.
>
> Reason for revert:
> Likely cause of failure
> Step "browser_tests on Ubuntu-18.04" failing on builder "linux-chromeos-chrome"
>
> The failure is a crash in browser_tests.
>
> This failure is fairly but not perfectly consistent.  In three of the last four runs on this bot, browser_tests failed with something in the NativeInputMethodEngineTest.EmojiSuggestion* suite.  It's not always the same test that fails each time.  Nevertheless, this is pretty indicative that nowadays something is wrong in this suite.  This is the obvious candidate, submitted right when the test became mostly-failing.
>
> Here is the first failure as an example:
> Retrying 1 test (retry #0)
> [ RUN      ] NativeInputMethodEngineTest.EmojiSuggestionDisabledReasonkUrlOrAppNotAllowed
> 2021-09-24T11:30:01.258384Z WARNING browser_tests[27592:27592]: [audio_manager_linux.cc(60)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized.
> [434.616] default_socket.cc:58    /run/perfetto/ exists but cannot be accessed. Falling back on /tmp/  (errno: 13, Permission denied)
> 2021-09-24T11:30:01.293097Z WARNING browser_tests[27592:27609]: [wallpaper_decoder.cc(29)] Failed reading file
> 2021-09-24T11:30:01.304548Z ERROR browser_tests[27592:27592]: [print_job_reporting_service_factory.cc(47)] DMToken must be valid
> 2021-09-24T11:30:01.309314Z ERROR browser_tests[27592:27592]: [proximity_auth_profile_pref_manager.cc(194)] Failed to find local state prefs for current user.
> 2021-09-24T11:30:01.332070Z WARNING browser_tests[27592:27592]: [remote_commands_service.cc(188)] Client is not registered.
> 2021-09-24T11:30:01.358975Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB
> 2021-09-24T11:30:01.359074Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Cache: 0MB
> 2021-09-24T11:30:01.359110Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.README: 0MB
> 2021-09-24T11:30:01.359138Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB
> 2021-09-24T11:30:01.359147Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.WebData: 0MB
> 2021-09-24T11:30:01.359429Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.CodeCache: 0MB
> 2021-09-24T11:30:01.359547Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SiteCharacteristicsDatabase: 0MB
> 2021-09-24T11:30:01.359581Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Favicons: 0MB
> 2021-09-24T11:30:01.359621Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginDataForAccount: 0MB
> 2021-09-24T11:30:01.360073Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.GCache: 0MB
> 2021-09-24T11:30:01.360118Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.History: 0MB
> 2021-09-24T11:30:01.360147Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB
> 2021-09-24T11:30:01.360161Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB
> 2021-09-24T11:30:01.360173Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB
> 2021-09-24T11:30:01.360234Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB
> 2021-09-24T11:30:01.360415Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SyncData: 0MB
> 2021-09-24T11:30:01.361882Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOCK: 0MB
> 2021-09-24T11:30:01.361936Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginData: 0MB
> 2021-09-24T11:30:01.361964Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOG: 0MB
> 2021-09-24T11:30:01.362091Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB
> 2021-09-24T11:30:01.412518Z ERROR browser_tests[27592:27592]: [plugin_vm_manager_impl.cc(150)] New session has dispatcher unexpected already running. Perhaps Chrome crashed?
> 2021-09-24T11:30:01.433615Z INFO browser_tests[27592:27592]: [key_permissions_manager_impl.cc(509)] One-time key permissions migration started for token: 0.
> 2021-09-24T11:30:01.451071Z WARNING browser_tests[27592:27592]: [drivefs_session.cc(65)] DriveFs mount failed with error: 3
> 2021-09-24T11:30:01.458878Z WARNING browser_tests[27592:27592]: [login_unlock_throughput_recorder.cc(58)] Zero frames expected in login animation throughput data
> 2021-09-24T11:30:01.464809Z INFO browser_tests[27592:27592]: [android_sms_pairing_state_tracker_impl.cc(71)] No Pairing cookie found
> 2021-09-24T11:30:01.470495Z INFO browser_tests[27592:27592]: [ui_test_utils.cc(224)] NavigateToURL: chrome://newtab/
> 2021-09-24T11:30:01.473373Z WARNING browser_tests[27592:27639]: [google_brand_chromeos.cc(40)] Brand code file missing: /opt/oem/etc/BRAND_CODE
> 2021-09-24T11:30:01.535229Z ERROR browser_tests[27592:27639]: [als_reader.cc(52)] Missing num of als
> 2021-09-24T11:30:01.535643Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(230)] crbug.com/1216328: Checking Bluetooth availability started. Please report if there is no report that this ends.
> 2021-09-24T11:30:01.535680Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(233)] crbug.com/1216328: Checking Bluetooth availability ended.
> 2021-09-24T11:30:01.535688Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(236)] crbug.com/1216328: Checking default browser status started. Please report if there is no report that this ends.
> 2021-09-24T11:30:01.535695Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(240)] crbug.com/1216328: Checking default browser status ended.
> 2021-09-24T11:30:01.555145Z INFO browser_tests[27592:27592]: [key_permissions_manager_impl.cc(534)] One-time key permissions migration succeeded for token: 0.
> BrowserTestBase received signal: Segmentation fault. Backtrace:
> #0 0x556151f72449 base::debug::CollectStackTrace()
> #1 0x556151ed9d73 base::debug::StackTrace::StackTrace()
> #2 0x5561525e4683 content::(anonymous namespace)::DumpStackTraceSignalHandler()
> #3 0x7f7dd56e2040 (/lib/x86_64-linux-gnu/libc-2.27.so+0x3f03f)
> #4 0x5561556c8304 ChromeOmniboxNavigationObserver::DidFinishNavigation()
> #5 0x5561503c8362 content::WebContentsImpl::WebContentsObserverList::NotifyObservers<>()
> #6 0x5561503d05f0 content::WebContentsImpl::DidFinishNavigation()
> #7 0x5561502a5093 content::NavigationRequest::~NavigationRequest()
> #8 0x5561502a59dc content::NavigationRequest::~NavigationRequest()
> #9 0x5561502b8919 content::Navigator::DidNavigate()
> #10 0x5561502caeed content::RenderFrameHostImpl::DidCommitNavigationInternal()
> #11 0x5561502ca24a content::RenderFrameHostImpl::DidCommitNavigation()
> #12 0x5561502e9d60 base::internal::FunctorTraits<>::Invoke<>()
> #13 0x5561502e9d0f base::internal::Invoker<>::RunOnce()
> #14 0x55614fd53470 content::mojom::NavigationClient_CommitFailedNavigation_ForwardToCallback::Accept()
> #15 0x55615301c6e0 mojo::InterfaceEndpointClient::HandleValidatedMessage()
> #16 0x5561530201e0 mojo::MessageDispatcher::Accept()
> #17 0x55615301d435 mojo::InterfaceEndpointClient::HandleIncomingMessage()
> #18 0x5561531dc3e2 IPC::(anonymous namespace)::ChannelAssociatedGroupController::AcceptOnEndpointThread()
> #19 0x55615301e323 base::internal::Invoker<>::RunOnce()
> #20 0x556151f35f23 base::TaskAnnotator::RunTask()
> #21 0x556151f467b3 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl()
> #22 0x556151f46569 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork()
> #23 0x556151f46b32 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork()
> #24 0x556151fa9c4b base::MessagePumpLibevent::Run()
> #25 0x556151f46d6d base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run()
> #26 0x556151f18c1b base::RunLoop::Run()
> #27 0x556151ec159d InProcessBrowserTest::RunUntilBrowserProcessQuits()
> #28 0x556151ec207f InProcessBrowserTest::QuitBrowsers()
> #29 0x556151ec1fce InProcessBrowserTest::PostRunTestOnMainThread()
> #30 0x5561525e3d34 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
> #31 0x556152012479 ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
> #32 0x55615201197e ChromeBrowserMainParts::PreMainMessageLoopRun()
> #33 0x55614efa9b98 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
> #34 0x5561500381cd content::BrowserMainLoop::PreMainMessageLoopRun()
> #35 0x5561503a1a9c content::StartupTaskRunner::RunAllTasksNow()
> #36 0x556150037e4a content::BrowserMainLoop::CreateStartupTasks()
> #37 0x55615003a147 content::BrowserMainRunnerImpl::Initialize()
> #38 0x556150036912 content::BrowserMain()
> #39 0x556150bf6aed content::RunBrowserProcessMain()
> #40 0x556150bf79bd content::ContentMainRunnerImpl::RunBrowser()
> #41 0x556150bf752e content::ContentMainRunnerImpl::Run()
> #42 0x556150bf5b38 content::RunContentProcess()
> #43 0x556150bf5c08 content::ContentMain()
> #44 0x5561525e3543 content::BrowserTestBase::SetUp()
> #45 0x556151ec12c1 InProcessBrowserTest::SetUp()
> #46 0x55614e1c8786 ash::input_method::(anonymous namespace)::NativeInputMethodEngineTest::SetUp()
> #47 0x55614f308e8f testing::Test::Run()
> #48 0x55614f3097c5 testing::TestInfo::Run()
> #49 0x55614f309f21 testing::TestSuite::Run()
> #50 0x55614f313798 testing::internal::UnitTestImpl::RunAllTests()
> #51 0x55614f31338b testing::UnitTest::Run()
> #52 0x556151fd7ff2 base::TestSuite::Run()
> #53 0x556151e96409 BrowserTestSuiteRunnerChromeOS::RunTestSuite()
> #54 0x556152613c1f content::LaunchTests()
> #55 0x556151e98224 LaunchChromeTests()
> #56 0x556151e9638b main
> #57 0x7f7dd56c4bf7 __libc_start_main
> #58 0x55614cca11ea _start
> from
> https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/17628
>
> Here is the fourth:  (different test in the same suite, different stack trace):
> [ RUN      ] NativeInputMethodEngineTest.EmojiSuggestionDisabledReasonkUserSettingsOff
> 2021-09-24T16:19:05.593039Z WARNING browser_tests[31407:31407]: [audio_manager_linux.cc(60)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized.
> [959.207] default_socket.cc:58    /run/perfetto/ exists but cannot be accessed. Falling back on /tmp/  (errno: 13, Permission denied)
> 2021-09-24T16:19:05.646514Z WARNING browser_tests[31407:31423]: [wallpaper_decoder.cc(29)] Failed reading file
> 2021-09-24T16:19:05.673272Z ERROR browser_tests[31407:31407]: [print_job_reporting_service_factory.cc(47)] DMToken must be valid
> 2021-09-24T16:19:05.678360Z ERROR browser_tests[31407:31407]: [proximity_auth_profile_pref_manager.cc(194)] Failed to find local state prefs for current user.
> 2021-09-24T16:19:05.728926Z WARNING browser_tests[31407:31407]: [remote_commands_service.cc(188)] Client is not registered.
> 2021-09-24T16:19:05.763864Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB
> 2021-09-24T16:19:05.763999Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Cache: 0MB
> 2021-09-24T16:19:05.764049Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.README: 0MB
> 2021-09-24T16:19:05.764094Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB
> 2021-09-24T16:19:05.764120Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.WebData: 0MB
> 2021-09-24T16:19:05.764270Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.CodeCache: 0MB
> 2021-09-24T16:19:05.764446Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SiteCharacteristicsDatabase: 0MB
> 2021-09-24T16:19:05.765718Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Favicons: 0MB
> 2021-09-24T16:19:05.765751Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginDataForAccount: 0MB
> 2021-09-24T16:19:05.766067Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.GCache: 0MB
> 2021-09-24T16:19:05.766094Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.History: 0MB
> 2021-09-24T16:19:05.766115Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB
> 2021-09-24T16:19:05.766123Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB
> 2021-09-24T16:19:05.766131Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB
> 2021-09-24T16:19:05.766199Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB
> 2021-09-24T16:19:05.766336Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LocalStorage: 0MB
> 2021-09-24T16:19:05.766472Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SyncData: 0MB
> 2021-09-24T16:19:05.766498Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOCK: 0MB
> 2021-09-24T16:19:05.766524Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginData: 0MB
> 2021-09-24T16:19:05.766552Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOG: 0MB
> 2021-09-24T16:19:05.766909Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB
> 2021-09-24T16:19:05.880798Z ERROR browser_tests[31407:31407]: [plugin_vm_manager_impl.cc(150)] New session has dispatcher unexpected already running. Perhaps Chrome crashed?
> 2021-09-24T16:19:05.921761Z INFO browser_tests[31407:31407]: [key_permissions_manager_impl.cc(509)] One-time key permissions migration started for token: 0.
> 2021-09-24T16:19:05.932877Z WARNING browser_tests[31407:31407]: [drivefs_session.cc(65)] DriveFs mount failed with error: 3
> 2021-09-24T16:19:05.951965Z WARNING browser_tests[31407:31407]: [login_unlock_throughput_recorder.cc(58)] Zero frames expected in login animation throughput data
> 2021-09-24T16:19:05.973007Z INFO browser_tests[31407:31407]: [android_sms_pairing_state_tracker_impl.cc(71)] No Pairing cookie found
> 2021-09-24T16:19:05.977396Z WARNING browser_tests[31407:31428]: [google_brand_chromeos.cc(40)] Brand code file missing: /opt/oem/etc/BRAND_CODE
> 2021-09-24T16:19:05.981581Z INFO browser_tests[31407:31407]: [ui_test_utils.cc(224)] NavigateToURL: chrome://newtab/
> 2021-09-24T16:19:06.072941Z ERROR browser_tests[31407:31457]: [als_reader.cc(52)] Missing num of als
> 2021-09-24T16:19:06.073283Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(230)] crbug.com/1216328: Checking Bluetooth availability started. Please report if there is no report that this ends.
> 2021-09-24T16:19:06.073310Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(233)] crbug.com/1216328: Checking Bluetooth availability ended.
> 2021-09-24T16:19:06.073337Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(236)] crbug.com/1216328: Checking default browser status started. Please report if there is no report that this ends.
> 2021-09-24T16:19:06.073358Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(240)] crbug.com/1216328: Checking default browser status ended.
> 2021-09-24T16:19:06.085536Z INFO browser_tests[31407:31407]: [key_permissions_manager_impl.cc(534)] One-time key permissions migration succeeded for token: 0.
> BrowserTestBase received signal: Segmentation fault. Backtrace:
> #0 0x564f24b8af29 base::debug::CollectStackTrace()
> #1 0x564f24af2843 base::debug::StackTrace::StackTrace()
> #2 0x564f251fd373 content::(anonymous namespace)::DumpStackTraceSignalHandler()
> #3 0x7f03d338d040 (/lib/x86_64-linux-gnu/libc-2.27.so+0x3f03f)
> #4 0x564f282e0d94 ChromeOmniboxNavigationObserver::DidFinishNavigation()
> #5 0x564f22fe1042 content::WebContentsImpl::WebContentsObserverList::NotifyObservers<>()
> #6 0x564f22fe92d0 content::WebContentsImpl::DidFinishNavigation()
> #7 0x564f22ebdd73 content::NavigationRequest::~NavigationRequest()
> #8 0x564f22ebe6bc content::NavigationRequest::~NavigationRequest()
> #9 0x564f22ed15f9 content::Navigator::DidNavigate()
> #10 0x564f22ee3bcd content::RenderFrameHostImpl::DidCommitNavigationInternal()
> #11 0x564f22ee2f2a content::RenderFrameHostImpl::DidCommitNavigation()
> #12 0x564f22f02a40 base::internal::FunctorTraits<>::Invoke<>()
> #13 0x564f22f029ef base::internal::Invoker<>::RunOnce()
> #14 0x564f2296c430 content::mojom::NavigationClient_CommitFailedNavigation_ForwardToCallback::Accept()
> #15 0x564f25c35100 mojo::InterfaceEndpointClient::HandleValidatedMessage()
> #16 0x564f25c38c00 mojo::MessageDispatcher::Accept()
> #17 0x564f25c35e55 mojo::InterfaceEndpointClient::HandleIncomingMessage()
> #18 0x564f25df4e02 IPC::(anonymous namespace)::ChannelAssociatedGroupController::AcceptOnEndpointThread()
> #19 0x564f25c36d43 base::internal::Invoker<>::RunOnce()
> #20 0x564f24b4ea03 base::TaskAnnotator::RunTask()
> #21 0x564f24b5f293 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl()
> #22 0x564f24b5f049 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork()
> #23 0x564f24b5f612 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork()
> #24 0x564f24bc28cb base::MessagePumpLibevent::Run()
> #25 0x564f24b5f84d base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run()
> #26 0x564f24b316fb base::RunLoop::Run()
> #27 0x564f22f433f3 content::BrowserTaskExecutor::RunAllPendingTasksOnThreadForTesting()
> #28 0x564f2522df45 content::RunAllPendingInMessageLoop()
> #29 0x564f24adaa96 InProcessBrowserTest::PostRunTestOnMainThread()
> #30 0x564f251fca24 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
> #31 0x564f24c2b0f9 ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
> #32 0x564f24c2a5fe ChromeBrowserMainParts::PreMainMessageLoopRun()
> #33 0x564f21bc1f38 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
> #34 0x564f22c510ed content::BrowserMainLoop::PreMainMessageLoopRun()
> #35 0x564f22fba77c content::StartupTaskRunner::RunAllTasksNow()
> #36 0x564f22c50d6a content::BrowserMainLoop::CreateStartupTasks()
> #37 0x564f22c53067 content::BrowserMainRunnerImpl::Initialize()
> #38 0x564f22c4f832 content::BrowserMain()
> #39 0x564f2380f5bd content::RunBrowserProcessMain()
> #40 0x564f2381048d content::ContentMainRunnerImpl::RunBrowser()
> #41 0x564f2380fffe content::ContentMainRunnerImpl::Run()
> #42 0x564f2380e608 content::RunContentProcess()
> #43 0x564f2380e6d8 content::ContentMain()
> #44 0x564f251fc233 content::BrowserTestBase::SetUp()
> #45 0x564f24ad9d91 InProcessBrowserTest::SetUp()
> #46 0x564f20de0a86 ash::input_method::(anonymous namespace)::NativeInputMethodEngineTest::SetUp()
> #47 0x564f21f21e4f testing::Test::Run()
> #48 0x564f21f22785 testing::TestInfo::Run()
> #49 0x564f21f22ee1 testing::TestSuite::Run()
> #50 0x564f21f2c758 testing::internal::UnitTestImpl::RunAllTests()
> #51 0x564f21f2c34b testing::UnitTest::Run()
> #52 0x564f24bf0c72 base::TestSuite::Run()
> #53 0x564f24aaeed9 BrowserTestSuiteRunnerChromeOS::RunTestSuite()
> #54 0x564f2522c62f content::LaunchTests()
> #55 0x564f24ab0cf4 LaunchChromeTests()
> #56 0x564f24aaee5b main
> #57 0x7f03d336fbf7 __libc_start_main
> #58 0x564f1f8b94ea _start
> from
> https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/17631
>
> Original change's description:
> > Privatise unnecessarily public current_input_method in
> > InputMethodManagerImpl::StateImpl.
> >
> > This involves replacing some direct pokes of current_input_method
> > with public GetCurrentInputMethod() that employs a fallback onto
> > InputMethodUtil::GetFallbackInputMethodDescriptor() when ID is
> > blank. This should be more reasonable and consistent.
> >
> > Bug: 1134465
> > Change-Id: I2c423a58547cc7249efdf8056624623998765aba
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3177760
> > Commit-Queue: Bao-Duy Tran <[email protected]>
> > Reviewed-by: Keith Lee <[email protected]>
> > Reviewed-by: Curtis McMullan <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#924702}
>
> Bug: 1134465
> Change-Id: I6144a0ebd7472f31d4b937d9e99b6a6c8bc0eee1
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3182806
> Auto-Submit: Mark Pearson <[email protected]>
> Bot-Commit: Rubber Stamper <[email protected]>
> Commit-Queue: Mark Pearson <[email protected]>
> Owners-Override: Mark Pearson <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#924810}

Bug: 1134465
Change-Id: I358d66835e54d67d8d151e3da38da9a8f33d83bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184801
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Darren Shen <[email protected]>
Commit-Queue: Bao-Duy Tran <[email protected]>
Cr-Commit-Position: refs/heads/main@{#925158}
pull bot pushed a commit that referenced this pull request Oct 26, 2024
Revert "Prerender: first impl to dry run painting on prerendering page"
e61f478 
This reverts commit ecb74d5.

Reason for revert:

A series of bots such as "Linux Tests (dbg)(1)", "Linux ASan LSan Tests (1)" started failing consistently in browser_tests for these two tests:
PreviewBrowserTest.ErrorOnNonHttpsUrl
PreviewBrowserTest.ErrorOnRedirectionToNonHttpsUrl
after this change was submitted.

More complete bot list is below [1].

Both of those tests are both prerender-related.  This is the only prerender-related change on the blamelist.

The former somtimes fails with
vector.h(1305): Check failed: i < size() (0 vs. 0)
See full stack trace below [2].

The latter sometimes fails with
preview_manager.cc(73): Check failed: tab_.
See full stack trace below [3].

I have also seen the former fail with the "Check failed: tab_." error message.

And on some bots I have also seen a full-blown crash (unexpected abort).

Also, on some both I have seen other PreviewBrowserTest failures at this time, such as PreviewBrowserTest.MojoCapabilityControl, with similar errors.


[1] bots that fail:
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ASan%20LSan%20Tests%20(1)/128871/blamelist
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/61153/blamelist
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/47171/blamelist
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20MSan%20Tests/51450/blamelist
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/122977/blamelist
https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-dbg/37765/blamelist

[2]
PreviewBrowserTest.ErrorOnNonHttpsUrl
[ RUN      ] PreviewBrowserTest.ErrorOnNonHttpsUrl
[292860:292860:1025/041435.600171:WARNING:field_trial_util.cc(106)] Field trial config study skipped: LinkPreview.EnabledAltClick (some of its features are already overridden)
[292860:292860:1025/041435.613074:WARNING:field_trial_util.cc(106)] Field trial config study skipped: PreconnectToSearchDesktop.EnabledWithStartupDelayForegroundOnly (some of its features are already overridden)
[292947:292947:1025/041436.521543:WARNING:gpu_memory_buffer_support_x11.cc(49)] dri3 extension not supported.
[292947:292947:1025/041436.577861:WARNING:sandbox_linux.cc(430)] InitializeSandbox() called with multiple threads in process gpu-process.
[292947:292947:1025/041436.602554:WARNING:viz_main_impl.cc(85)] VizNullHypothesis is disabled (not a warning)
[292948:292979:1025/041438.220989:WARNING:simple_synchronous_entry.cc(1449)] Could not open platform files for entry.
[292860:292860:1025/041439.058422:WARNING:idle_linux.cc(110)] None of the known D-Bus ScreenSaver services could be used.
[292860:293018:1025/041439.668033:WARNING:embedded_test_server.cc(757)] Request not handled. Returning 404: /favicon.ico
[293019:293019:1025/041440.636001:ERROR:html_media_element.cc(4927)] SetError: {code=4, message="MEDIA_ELEMENT_ERROR: Media load rejected by URL safety check"}
[293019:293019:1025/041440.796426:FATAL:vector.h(1305)] Check failed: i < size() (0 vs. 0)
    #0 0x63a93d38d586 in ___interceptor_backtrace /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/asan/../sanitizer_common/sanitizer_common_interceptors.inc:4441:13
    #1 0x63a95f5dc688 in base::debug::CollectStackTrace(base::span<void const*, 18446744073709551615ul, void const**>) ./../../base/debug/stack_trace_posix.cc:1047:7
    #2 0x63a95f593489 in base::debug::StackTrace::StackTrace(unsigned long) ./../../base/debug/stack_trace.cc:245:20
    #3 0x63a95f253ece in logging::LogMessage::Flush() ./../../base/logging.cc:725:29
    #4 0x63a95f25396d in logging::LogMessage::~LogMessage() ./../../base/logging.cc:713:3
    #5 0x63a95f20756b in ~CheckLogMessage ./../../base/check.cc:193:3
    #6 0x63a95f20756b in logging::(anonymous namespace)::CheckLogMessage::~CheckLogMessage() ./../../base/check.cc:190:31
    #7 0x63a95f206f30 in operator() ./../../third_party/libc++/src/include/__memory/unique_ptr.h:75:5
    #8 0x63a95f206f30 in reset ./../../third_party/libc++/src/include/__memory/unique_ptr.h:297:7
    #9 0x63a95f206f30 in logging::NotReachedError::~NotReachedError() ./../../base/check.cc:355:16
    #10 0x63a975d348af in WTF::Vector<blink::PaintChunk, 0u, blink::HeapAllocator>::at(unsigned int) const ./../../third_party/blink/renderer/platform/wtf/vector.h:1305:5
    #11 0x63a975d57f4b in operator[] ./../../third_party/blink/renderer/platform/wtf/vector.h:1310:52
    #12 0x63a975d57f4b in blink::PaintChunkSubset::operator[](unsigned int) const ./../../third_party/blink/renderer/platform/graphics/paint/paint_chunk_subset.h:108:12
    #13 0x63a975d9700d in FirstPaintChunk ./../../third_party/blink/renderer/platform/graphics/compositing/pending_layer.cc:183:10
    #14 0x63a975d9700d in blink::PendingLayer::Matches(blink::PendingLayer const&) const ./../../third_party/blink/renderer/platform/graphics/compositing/pending_layer.cc:196:54
    #15 0x63a975d23989 in Find ./../../third_party/blink/renderer/platform/graphics/compositing/paint_artifact_compositor.cc:73:21
    #16 0x63a975d23989 in blink::PaintArtifactCompositor::Update(blink::PaintArtifact const&, blink::PaintArtifactCompositor::ViewportProperties const&, blink::HeapVector<cppgc::internal::BasicMember<blink::TransformPaintPropertyNode const, cppgc::internal::StrongMemberTag, cppgc::internal::DijkstraWriteBarrierPolicy, cppgc::internal::DisabledCheckingPolicy, cppgc::internal::CompressedPointer>, 32u> const&, WTF::Vector<std::__Cr::unique_ptr<cc::ViewTransitionRequest, std::__Cr::default_delete<cc::ViewTransitionRequest>>, 0u, WTF::PartitionAllocator>) ./../../third_party/blink/renderer/platform/graphics/compositing/paint_artifact_compositor.cc:1006:35
    #17 0x63a9711e76ef in blink::LocalFrameView::PushPaintArtifactToCompositor(bool) ./../../third_party/blink/renderer/core/frame/local_frame_view.cc:3017:31
    #18 0x63a9711de07f in blink::LocalFrameView::RunPaintLifecyclePhase(blink::PaintBenchmarkMode) ./../../third_party/blink/renderer/core/frame/local_frame_view.cc:2677:5
    #19 0x63a9711d825b in blink::LocalFrameView::UpdateLifecyclePhasesInternal(blink::DocumentLifecycle::LifecycleState) ./../../third_party/blink/renderer/core/frame/local_frame_view.cc:2377:3
    #20 0x63a9711cfedd in blink::LocalFrameView::UpdateLifecyclePhases(blink::DocumentLifecycle::LifecycleState, blink::DocumentUpdateReason) ./../../third_party/blink/renderer/core/frame/local_frame_view.cc:2181:3
    #21 0x63a9711ced65 in blink::LocalFrameView::UpdateAllLifecyclePhases(blink::DocumentUpdateReason) ./../../third_party/blink/renderer/core/frame/local_frame_view.cc:1908:54
    #22 0x63a973c8b458 in blink::PageAnimator::UpdateAllLifecyclePhases(blink::LocalFrame&, blink::DocumentUpdateReason) ./../../third_party/blink/renderer/core/page/page_animator.cc:397:9
    #23 0x63a97146de8d in blink::WebFrameWidgetImpl::UpdateLifecycle(blink::WebLifecycleUpdate, blink::DocumentUpdateReason) ./../../third_party/blink/renderer/core/frame/web_frame_widget_impl.cc:1663:14
    #24 0x63a9761f2ce6 in UpdateVisualState ./../../third_party/blink/renderer/platform/widget/widget_base.cc:1027:12
    #25 0x63a9761f2ce6 in non-virtual thunk to blink::WidgetBase::UpdateVisualState() ./../../third_party/blink/renderer/platform/widget/widget_base.cc:0:0
    #26 0x63a9685d7f9e in cc::LayerTreeHost::RequestMainFrameUpdate(bool) ./../../cc/trees/layer_tree_host.cc:386:12
    #27 0x63a968929d27 in cc::ProxyMain::BeginMainFrame(std::__Cr::unique_ptr<cc::BeginMainFrameAndCommitState, std::__Cr::default_delete<cc::BeginMainFrameAndCommitState>>) ./../../cc/trees/proxy_main.cc:296:21
    #28 0x63a96895daca in Invoke<void (cc::ProxyMain::*)(std::__Cr::unique_ptr<cc::BeginMainFrameAndCommitState, std::__Cr::default_delete<cc::BeginMainFrameAndCommitState> >), const base::WeakPtr<cc::ProxyMain> &, std::__Cr::unique_ptr<cc::BeginMainFrameAndCommitState, std::__Cr::default_delete<cc::BeginMainFrameAndCommitState> > > ./../../base/functional/bind_internal.h:738:12
    #29 0x63a96895daca in MakeItSo<void (cc::ProxyMain::*)(std::__Cr::unique_ptr<cc::BeginMainFrameAndCommitState, std::__Cr::default_delete<cc::BeginMainFrameAndCommitState> >), std::__Cr::tuple<base::WeakPtr<cc::ProxyMain>, std::__Cr::unique_ptr<cc::BeginMainFrameAndCommitState, std::__Cr::default_delete<cc::BeginMainFrameAndCommitState> > > > ./../../base/functional/bind_internal.h:954:5
    #30 0x63a96895daca in void base::internal::Invoker<base::internal::FunctorTraits<void (cc::ProxyMain::*&&)(std::__Cr::unique_ptr<cc::BeginMainFrameAndCommitState, std::__Cr::default_delete<cc::BeginMainFrameAndCommitState>>), base::WeakPtr<cc::ProxyMain>&&, std::__Cr::unique_ptr<cc::BeginMainFrameAndCommitState, std::__Cr::default_delete<cc::BeginMainFrameAndCommitState>>&&>, base::internal::BindState<true, true, false, void (cc::ProxyMain::*)(std::__Cr::unique_ptr<cc::BeginMainFrameAndCommitState, std::__Cr::default_delete<cc::BeginMainFrameAndCommitState>>), base::WeakPtr<cc::ProxyMain>, std::__Cr::unique_ptr<cc::BeginMainFrameAndCommitState, std::__Cr::default_delete<cc::BeginMainFrameAndCommitState>>>, void ()>::RunImpl<void (cc::ProxyMain::*)(std::__Cr::unique_ptr<cc::BeginMainFrameAndCommitState, std::__Cr::default_delete<cc::BeginMainFrameAndCommitState>>), std::__Cr::tuple<base::WeakPtr<cc::ProxyMain>, std::__Cr::unique_ptr<cc::BeginMainFrameAndCommitState, std::__Cr::default_delete<cc::BeginMainFrameAndCommitState>>>, 0ul, 1ul>(void (cc::ProxyMain::*&&)(std::__Cr::unique_ptr<cc::BeginMainFrameAndCommitState, std::__Cr::default_delete<cc::BeginMainFrameAndCommitState>>), std::__Cr::tuple<base::WeakPtr<cc::ProxyMain>, std::__Cr::unique_ptr<cc::BeginMainFrameAndCommitState, std::__Cr::default_delete<cc::BeginMainFrameAndCommitState>>>&&, std::__Cr::integer_sequence<unsigned long, 0ul, 1ul>) ./../../base/functional/bind_internal.h:1067:14
    #31 0x63a93d44d4f8 in base::OnceCallback<void ()>::Run() && ./../../base/functional/callback.h:156:12
    #32 0x63a95f3ccd8c in base::TaskAnnotator::RunTaskImpl(base::PendingTask&) ./../../base/task/common/task_annotator.cc:202:34
    #33 0x63a95f473609 in RunTask<(lambda at ../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:473:11)> ./../../base/task/common/task_annotator.h:98:5
    #34 0x63a95f473609 in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(base::LazyNow*) ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:471:23
    #35 0x63a95f4718ba in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:332:40
    #36 0x63a95f474b5b in non-virtual thunk to base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:0:0
    #37 0x63a95f28090b in base::MessagePumpDefault::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_default.cc:40:55
    #38 0x63a95f475cb8 in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run(bool, base::TimeDelta) ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:641:12
    #39 0x63a95f34b020 in base::RunLoop::Run(base::Location const&) ./../../base/run_loop.cc:133:14
    #40 0x63a97f98da9d in content::RendererMain(content::MainFunctionParams) ./../../content/renderer/renderer_main.cc:361:16
    #41 0x63a95c23b8f7 in content::RunZygote(content::ContentMainDelegate*) ./../../content/app/content_main_runner_impl.cc:700:14
    #42 0x63a95c23cc43 in content::RunOtherNamedProcessTypeMain(std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> const&, content::MainFunctionParams, content::ContentMainDelegate*) ./../../content/app/content_main_runner_impl.cc:804:12
    #43 0x63a95c23fa5f in content::ContentMainRunnerImpl::Run() ./../../content/app/content_main_runner_impl.cc:1164:10
    #44 0x63a95c2397f3 in content::RunContentProcess(content::ContentMainParams, content::ContentMainRunner*) ./../../content/app/content_main.cc:356:36
    #45 0x63a95c23a05c in content::ContentMain(content::ContentMainParams) ./../../content/app/content_main.cc:369:10
    #46 0x63a9625187d6 in content::LaunchTestsInternal(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:385:12
    #47 0x63a962519512 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:504:10
    #48 0x63a96dc8f449 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:338:10
    #49 0x63a95ef8f627 in main ./../../chrome/test/base/browser_tests_main.cc:60:10
    #50 0x780e7da29d90 in __libc_start_call_main ./csu/../sysdeps/nptl/libc_start_call_main.h:58:16
    #51 0x780e7da29e40 in __libc_start_main ./csu/../csu/libc-start.c:392:3
    #52 0x63a93d34702a in _start ??:0:0
Task trace:
    #0 0x63a9689511e6 in cc::ProxyImpl::ScheduledActionSendBeginMainFrame(viz::BeginFrameArgs const&) ./../../cc/trees/proxy_impl.cc:760:7
    #1 0x63a96892e967 in cc::ProxyMain::SendCommitRequestToImplThreadIfNeeded(cc::ProxyMain::CommitPipelineStage) ./../../cc/trees/proxy_main.cc:878:7
    #2 0x63a976caa6c1 in blink::HTMLDocumentParser::SchedulePumpTokenizer(bool) ./../../third_party/blink/renderer/core/html/parser/html_document_parser.cc:890:7
    #3 0x63a976caa6c1 in blink::HTMLDocumentParser::SchedulePumpTokenizer(bool) ./../../third_party/blink/renderer/core/html/parser/html_document_parser.cc:890:7
    #4 0x63a976caa6c1 in blink::HTMLDocumentParser::SchedulePumpTokenizer(bool) ./../../third_party/blink/renderer/core/html/parser/html_document_parser.cc:890:7
Task trace buffer limit hit, update PendingTask::kTaskBacktraceLength to increase.
Crash keys:
... [omitted rest]

[3] PreviewBrowserTest.ErrorOnRedirectionToNonHttpsUrl stack trace:
[ RUN      ] PreviewBrowserTest.ErrorOnRedirectionToNonHttpsUrl
[444109:444109:1025/041553.399357:WARNING:field_trial_util.cc(106)] Field trial config study skipped: LinkPreview.EnabledAltClick (some of its features are already overridden)
[444109:444109:1025/041553.404344:WARNING:field_trial_util.cc(106)] Field trial config study skipped: PreconnectToSearchDesktop.EnabledWithStartupDelayForegroundOnly (some of its features are already overridden)
[444182:444182:1025/041554.079734:WARNING:gpu_memory_buffer_support_x11.cc(49)] dri3 extension not supported.
[444182:444182:1025/041554.104499:WARNING:sandbox_linux.cc(430)] InitializeSandbox() called with multiple threads in process gpu-process.
[444182:444182:1025/041554.121502:WARNING:viz_main_impl.cc(85)] VizNullHypothesis is disabled (not a warning)
[444183:444252:1025/041556.053677:WARNING:simple_synchronous_entry.cc(1449)] Could not open platform files for entry.
[444109:444109:1025/041557.583553:WARNING:idle_linux.cc(110)] None of the known D-Bus ScreenSaver services could be used.
[444109:444362:1025/041558.554846:WARNING:embedded_test_server.cc(757)] Request not handled. Returning 404: /favicon.ico
[444383:444383:1025/041559.563402:ERROR:html_media_element.cc(4927)] SetError: {code=4, message="MEDIA_ELEMENT_ERROR: Media load rejected by URL safety check"}
[444383:444383:1025/041559.590330:ERROR:html_media_element.cc(4927)] SetError: {code=4, message="MEDIA_ELEMENT_ERROR: Media load rejected by URL safety check"}
[444383:444383:1025/041559.591717:ERROR:html_media_element.cc(4927)] SetError: {code=4, message="MEDIA_ELEMENT_ERROR: Media load rejected by URL safety check"}
chrome/browser/preloading/preview/preview_test_util.cc:35: Failure
Failed
RunLoop::Run() timed out. Timeout set at ProxyRunTestOnMainThreadLoop@content/public/test/browser_test_base.cc:862.
Stack trace:
    #0 0x581999742852 in base::test::(anonymous namespace)::TimeoutCallbackWithGtestFailure(base::Location const&, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> ()>, base::Location const&) ./../../base/test/scoped_run_loop_timeout.cc:59:3
    #1 0x581999743998 in Invoke<void (*const &)(const base::Location &, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char> > ()>, const base::Location &), const base::Location &, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char> > ()>, const base::Location &> ./../../base/functional/bind_internal.h:671:12
    #2 0x581999743998 in MakeItSo<void (*const &)(const base::Location &, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char> > ()>, const base::Location &), const std::__Cr::tuple<> &, const base::Location &, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char> > ()>, const base::Location &> ./../../base/functional/bind_internal.h:930:12
    #3 0x581999743998 in RunImpl<void (*const &)(const base::Location &, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char> > ()>, const base::Location &), const std::__Cr::tuple<> &> ./../../base/functional/bind_internal.h:1067:14
    #4 0x581999743998 in base::internal::Invoker<base::internal::FunctorTraits<void (* const&)(base::Location const&, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> ()>, base::Location const&)>, base::internal::BindState<false, true, false, void (*)(base::Location const&, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> ()>, base::Location const&)>, void (base::Location const&, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> ()>, base::Location const&)>::Run(base::internal::BindStateBase*, base::Location const&, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> ()>&&, base::Location const&) ./../../base/functional/bind_internal.h:987:12
    #5 0x58199974311b in base::RepeatingCallback<void (base::Location const&, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> ()>, base::Location const&)>::Run(base::Location const&, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> ()>, base::Location const&) const & ./../../base/functional/callback.h:344:12
    #6 0x581999742dde in Invoke<const base::RepeatingCallback<void (const base::Location &, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char> > ()>, const base::Location &)> &, const base::Location &, const base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char> > ()> &, const base::Location &> ./../../base/functional/bind_internal.h:830:49
    #7 0x581999742dde in MakeItSo<const base::RepeatingCallback<void (const base::Location &, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char> > ()>, const base::Location &)> &, const std::__Cr::tuple<base::Location, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char> > ()> > &, const base::Location &> ./../../base/functional/bind_internal.h:930:12
    #8 0x581999742dde in RunImpl<const base::RepeatingCallback<void (const base::Location &, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char> > ()>, const base::Location &)> &, const std::__Cr::tuple<base::Location, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char> > ()> > &, 0UL, 1UL> ./../../base/functional/bind_internal.h:1067:14
    #9 0x581999742dde in base::internal::Invoker<base::internal::FunctorTraits<base::RepeatingCallback<void (base::Location const&, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> ()>, base::Location const&)> const&, base::Location const&, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> ()> const&>, base::internal::BindState<false, true, true, base::RepeatingCallback<void (base::Location const&, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> ()>, base::Location const&)>, base::Location, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> ()>>, void (base::Location const&)>::Run(base::internal::BindStateBase*, base::Location const&) ./../../base/functional/bind_internal.h:987:12
    #10 0x5819993b1250 in base::OnceCallback<void (base::Location const&)>::Run(base::Location const&) && ./../../base/functional/callback.h:156:12
    #11 0x5819993aa151 in base::(anonymous namespace)::OnRunLoopTimeout(base::RunLoop*, base::Location const&, base::OnceCallback<void (base::Location const&)>) ./../../base/run_loop.cc:40:25
    #12 0x5819993b0c25 in Invoke<void (*)(base::RunLoop *, const base::Location &, base::OnceCallback<void (const base::Location &)>), base::RunLoop *, base::Location, base::RepeatingCallback<void (const base::Location &)> > ./../../base/functional/bind_internal.h:671:12
    #13 0x5819993b0c25 in MakeItSo<void (*)(base::RunLoop *, const base::Location &, base::OnceCallback<void (const base::Location &)>), std::__Cr::tuple<base::internal::UnretainedWrapper<base::RunLoop, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0>, base::Location, base::RepeatingCallback<void (const base::Location &)> > > ./../../base/functional/bind_internal.h:930:12
    #14 0x5819993b0c25 in RunImpl<void (*)(base::RunLoop *, const base::Location &, base::OnceCallback<void (const base::Location &)>), std::__Cr::tuple<base::internal::UnretainedWrapper<base::RunLoop, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0>, base::Location, base::RepeatingCallback<void (const base::Location &)> >, 0UL, 1UL, 2UL> ./../../base/functional/bind_internal.h:1067:14
    #15 0x5819993b0c25 in base::internal::Invoker<base::internal::FunctorTraits<void (*&&)(base::RunLoop*, base::Location const&, base::OnceCallback<void (base::Location const&)>), base::RunLoop*, base::Location&&, base::RepeatingCallback<void (base::Location const&)>&&>, base::internal::BindState<false, true, false, void (*)(base::RunLoop*, base::Location const&, base::OnceCallback<void (base::Location const&)>), base::internal::UnretainedWrapper<base::RunLoop, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0>, base::Location, base::RepeatingCallback<void (base::Location const&)>>, void ()>::RunOnce(base::internal::BindStateBase*) ./../../base/functional/bind_internal.h:980:12
    #16 0x5819774ab4f8 in base::OnceCallback<void ()>::Run() && ./../../base/functional/callback.h:156:12
    #17 0x58197f9e29d4 in void base::internal::CancelableCallbackImpl<base::OnceCallback<void ()>>::ForwardOnce<>() ./../../base/cancelable_callback.h:134:26
    #18 0x58197f9e2f2e in Invoke<void (base::internal::CancelableCallbackImpl<base::OnceCallback<void ()> >::*)(), const base::WeakPtr<base::internal::CancelableCallbackImpl<base::OnceCallback<void ()> > > &> ./../../base/functional/bind_internal.h:738:12
    #19 0x58197f9e2f2e in MakeItSo<void (base::internal::CancelableCallbackImpl<base::OnceCallback<void ()> >::*)(), std::__Cr::tuple<base::WeakPtr<base::internal::CancelableCallbackImpl<base::OnceCallback<void ()> > > > > ./../../base/functional/bind_internal.h:954:5
    #20 0x58197f9e2f2e in void base::internal::Invoker<base::internal::FunctorTraits<void (base::internal::CancelableCallbackImpl<base::OnceCallback<void ()>>::*&&)(), base::WeakPtr<base::internal::CancelableCallbackImpl<base::OnceCallback<void ()>>>&&>, base::internal::BindState<true, true, false, void (base::internal::CancelableCallbackImpl<base::OnceCallback<void ()>>::*)(), base::WeakPtr<base::internal::CancelableCallbackImpl<base::OnceCallback<void ()>>>>, void ()>::RunImpl<void (base::internal::CancelableCallbackImpl<base::OnceCallback<void ()>>::*)(), std::__Cr::tuple<base::WeakPtr<base::internal::CancelableCallbackImpl<base::OnceCallback<void ()>>>>, 0ul>(void (base::internal::CancelableCallbackImpl<base::OnceCallback<void ()>>::*&&)(), std::__Cr::tuple<base::WeakPtr<base::internal::CancelableCallbackImpl<base::OnceCallback<void ()>>>>&&, std::__Cr::integer_sequence<unsigned long, 0ul>) ./../../base/functional/bind_internal.h:1067:14
    #21 0x5819774ab4f8 in base::OnceCallback<void ()>::Run() && ./../../base/functional/callback.h:156:12
    #22 0x58199942ad8c in base::TaskAnnotator::RunTaskImpl(base::PendingTask&) ./../../base/task/common/task_annotator.cc:202:34
    #23 0x5819994d1609 in RunTask<(lambda at ../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:473:11)> ./../../base/task/common/task_annotator.h:98:5
    #24 0x5819994d1609 in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(base::LazyNow*) ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:471:23
    #25 0x5819994cf8ba in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:332:40
    #26 0x5819994d2b5b in non-virtual thunk to base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:0:0
    #27 0x5819996866c3 in base::MessagePumpGlib::HandleDispatch() ./../../base/message_loop/message_pump_glib.cc:649:46
    #28 0x581999689959 in base::(anonymous namespace)::WorkSourceDispatch(_GSource*, int (*)(void*), void*) ./../../base/message_loop/message_pump_glib.cc:274:43
    #29 0x703e1f8f4d3b in g_main_context_dispatch ??:0:0
    #30 0x703e1f94a2b8 in g_io_channel_new_file ??:?
    #31 0x703e1f8f23e3 in g_main_context_iteration ??:0:0
    #32 0x581999686cf0 in base::MessagePumpGlib::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_glib.cc:683:30
    #33 0x5819994d3cb8 in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run(bool, base::TimeDelta) ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:641:12
    #34 0x5819993a9020 in base::RunLoop::Run(base::Location const&) ./../../base/run_loop.cc:133:14
    #35 0x58199909ac37 in Wait ./../../chrome/browser/preloading/preview/preview_test_util.cc:35:17
    #36 0x58199909ac37 in test::PreviewTestHelper::WaitUntilLoadFinished() ./../../chrome/browser/preloading/preview/preview_test_util.cc:90:16
    #37 0x58197f539b56 in PreviewBrowserTest_ErrorOnRedirectionToNonHttpsUrl_Test::RunTestOnMainThread() ./../../chrome/browser/preloading/preview/preview_browsertest.cc:309:12
    #38 0x58199c3a39c1 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:955:9
    #39 0x58199c3a81c4 in Invoke<void (content::BrowserTestBase::*)(), content::BrowserTestBase *> ./../../base/functional/bind_internal.h:738:12
    #40 0x58199c3a81c4 in MakeItSo<void (content::BrowserTestBase::*)(), std::__Cr::tuple<base::internal::UnretainedWrapper<content::BrowserTestBase, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0> > > ./../../base/functional/bind_internal.h:930:12
    #41 0x58199c3a81c4 in RunImpl<void (content::BrowserTestBase::*)(), std::__Cr::tuple<base::internal::UnretainedWrapper<content::BrowserTestBase, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0> >, 0UL> ./../../base/functional/bind_internal.h:1067:14
    #42 0x58199c3a81c4 in base::internal::Invoker<base::internal::FunctorTraits<void (content::BrowserTestBase::*&&)(), content::BrowserTestBase*>, base::internal::BindState<true, true, false, void (content::BrowserTestBase::*)(), base::internal::UnretainedWrapper<content::BrowserTestBase, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0>>, void ()>::RunOnce(base::internal::BindStateBase*) ./../../base/functional/bind_internal.h:980:12
    #43 0x5819774ab4f8 in base::OnceCallback<void ()>::Run() && ./../../base/functional/callback.h:156:12
    #44 0x58198e84361a in InterceptMainMessageLoopRun ./../../content/browser/browser_main_loop.cc:1074:36
    #45 0x58198e84361a in content::BrowserMainLoop::RunMainMessageLoop() ./../../content/browser/browser_main_loop.cc:1086:7
    #46 0x58198e84c18d in content::BrowserMainRunnerImpl::Run() ./../../content/browser/browser_main_runner_impl.cc:156:15
    #47 0x58198e839c99 in content::BrowserMain(content::MainFunctionParams) ./../../content/browser/browser_main.cc:34:28
    #48 0x58199629a625 in content::RunBrowserProcessMain(content::MainFunctionParams, content::ContentMainDelegate*) ./../../content/app/content_main_runner_impl.cc:732:10
    #49 0x58199629e5ed in content::ContentMainRunnerImpl::RunBrowser(content::MainFunctionParams, bool) ./../../content/app/content_main_runner_impl.cc:1311:10
    #50 0x58199629da92 in content::ContentMainRunnerImpl::Run() ./../../content/app/content_main_runner_impl.cc:1162:12
    #51 0x5819962977f3 in content::RunContentProcess(content::ContentMainParams, content::ContentMainRunner*) ./../../content/app/content_main.cc:356:36
    #52 0x58199629805c in content::ContentMain(content::ContentMainParams) ./../../content/app/content_main.cc:369:10
    #53 0x58199c3a1792 in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:622:3
    #54 0x5819991ef1d3 in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:542:20

[444109:444109:1025/041658.647315:FATAL:preview_manager.cc(73)] Check failed: tab_.
    #0 0x5819773eb586 in ___interceptor_backtrace /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/asan/../sanitizer_common/sanitizer_common_interceptors.inc:4441:13
    #1 0x58199963a688 in base::debug::CollectStackTrace(base::span<void const*, 18446744073709551615ul, void const**>) ./../../base/debug/stack_trace_posix.cc:1047:7
    #2 0x5819995f1489 in base::debug::StackTrace::StackTrace(unsigned long) ./../../base/debug/stack_trace.cc:245:20
    #3 0x5819992b1ece in logging::LogMessage::Flush() ./../../base/logging.cc:725:29
    #4 0x5819992b196d in logging::LogMessage::~LogMessage() ./../../base/logging.cc:713:3
    #5 0x58199926556b in ~CheckLogMessage ./../../base/check.cc:193:3
    #6 0x58199926556b in logging::(anonymous namespace)::CheckLogMessage::~CheckLogMessage() ./../../base/check.cc:190:31
    #7 0x581999264f30 in operator() ./../../third_party/libc++/src/include/__memory/unique_ptr.h:75:5
    #8 0x581999264f30 in reset ./../../third_party/libc++/src/include/__memory/unique_ptr.h:297:7
    #9 0x581999264f30 in logging::NotReachedError::~NotReachedError() ./../../base/check.cc:355:16
    #10 0x58199a3afe8f in PreviewManager::GetWebContentsForPreviewTab() ./../../chrome/browser/preloading/preview/preview_manager.cc:73:3
    #11 0x58197f539b87 in PreviewBrowserTest_ErrorOnRedirectionToNonHttpsUrl_Test::RunTestOnMainThread() ./../../chrome/browser/preloading/preview/preview_browsertest.cc:312:16
    #12 0x58199c3a39c1 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:955:9
    #13 0x58199c3a81c4 in Invoke<void (content::BrowserTestBase::*)(), content::BrowserTestBase *> ./../../base/functional/bind_internal.h:738:12
    #14 0x58199c3a81c4 in MakeItSo<void (content::BrowserTestBase::*)(), std::__Cr::tuple<base::internal::UnretainedWrapper<content::BrowserTestBase, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0> > > ./../../base/functional/bind_internal.h:930:12
    #15 0x58199c3a81c4 in RunImpl<void (content::BrowserTestBase::*)(), std::__Cr::tuple<base::internal::UnretainedWrapper<content::BrowserTestBase, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0> >, 0UL> ./../../base/functional/bind_internal.h:1067:14
    #16 0x58199c3a81c4 in base::internal::Invoker<base::internal::FunctorTraits<void (content::BrowserTestBase::*&&)(), content::BrowserTestBase*>, base::internal::BindState<true, true, false, void (content::BrowserTestBase::*)(), base::internal::UnretainedWrapper<content::BrowserTestBase, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0>>, void ()>::RunOnce(base::internal::BindStateBase*) ./../../base/functional/bind_internal.h:980:12
    #17 0x5819774ab4f8 in base::OnceCallback<void ()>::Run() && ./../../base/functional/callback.h:156:12
    #18 0x58198e84361a in InterceptMainMessageLoopRun ./../../content/browser/browser_main_loop.cc:1074:36
    #19 0x58198e84361a in content::BrowserMainLoop::RunMainMessageLoop() ./../../content/browser/browser_main_loop.cc:1086:7
    #20 0x58198e84c18d in content::BrowserMainRunnerImpl::Run() ./../../content/browser/browser_main_runner_impl.cc:156:15
    #21 0x58198e839c99 in content::BrowserMain(content::MainFunctionParams) ./../../content/browser/browser_main.cc:34:28
    #22 0x58199629a625 in content::RunBrowserProcessMain(content::MainFunctionParams, content::ContentMainDelegate*) ./../../content/app/content_main_runner_impl.cc:732:10
    #23 0x58199629e5ed in content::ContentMainRunnerImpl::RunBrowser(content::MainFunctionParams, bool) ./../../content/app/content_main_runner_impl.cc:1311:10
    #24 0x58199629da92 in content::ContentMainRunnerImpl::Run() ./../../content/app/content_main_runner_impl.cc:1162:12
    #25 0x5819962977f3 in content::RunContentProcess(content::ContentMainParams, content::ContentMainRunner*) ./../../content/app/content_main.cc:356:36
    #26 0x58199629805c in content::ContentMain(content::ContentMainParams) ./../../content/app/content_main.cc:369:10
    #27 0x58199c3a1792 in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:622:3
    #28 0x5819991ef1d3 in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:542:20
    #29 0x581996ad3b19 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0
    #30 0x581996ad3b19 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2723:3
    #31 0x581996ad61c2 in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2874:11
    #32 0x581996ad7d64 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:3052:30
    #33 0x581996aff5b5 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5982:44
    #34 0x581996afe64f in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0
    #35 0x581996afe64f in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5561:10
    #36 0x581999761d1c in base::TestSuite::Run() ./../../base/test/test_suite.cc:421:16
    #37 0x5819a7cecba7 in RunTestSuiteInternal ./../../chrome/test/base/chrome_test_launcher.cc:99:22
    #38 0x5819a7cecba7 in ChromeTestSuiteRunner::RunTestSuite(int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:104:10
    #39 0x58199c576a7d in content::LaunchTestsInternal(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:409:31
    #40 0x58199c577512 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:504:10
    #41 0x5819a7ced449 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:338:10
    #42 0x581998fed627 in main ./../../chrome/test/base/browser_tests_main.cc:60:10
    #43 0x703e1da29d90 in __libc_start_call_main ./csu/../sysdeps/nptl/libc_start_call_main.h:58:16
    #44 0x703e1da29e40 in __libc_start_main ./csu/../csu/libc-start.c:392:3
    #45 0x5819773a502a in _start ??:0:0
Crash keys:
... [omitted rest]


Original change's description:
> Prerender: first impl to dry run painting on prerendering page
>
> This CL triggers tree build right after renderer parsed the main DOM
> tree. CHCKEs on the browser side will guard the metric correctness.
> (See Ifd788c4b04f06a6b98caff1bb9df55af5fb8f07a)
> The following CLs will:
> 1. only trigger it for DSE.
> 2. add more metrics on the renderer side to verify the correctness.
>
> Bug: 40240492
> Change-Id: Icd94bad6a6ecfc5e492e4d9c4b4c227741c041d2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5912738
> Reviewed-by: Hiroki Nakagawa <[email protected]>
> Reviewed-by: Taiyo Mizuhashi <[email protected]>
> Commit-Queue: Lingqi Chi <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1373803}

Bug: 40240492
Change-Id: I8729c84b4ceb1a77761c738f96c4c03675dfcdb0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5966495
Commit-Queue: Mark Pearson <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Owners-Override: Mark Pearson <[email protected]>
Auto-Submit: Mark Pearson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1374047}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
⤵️ pull
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet