[pull] master from chromium:master #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
This CL updates the ash version 96.0.4654.0 for Lacros version skew testing. If this CL caused regressions, please revert and stop the autoroller at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller Also please file a bug to OS>LaCrOS>Partner, and CC [email protected], [email protected], [email protected]. [email protected] Bug: None Change-Id: Ie3a1084fd86024aad7681cf9908d0fa0b86e3c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184780 Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/heads/main@{#925088}
Test: trybots Bug: none Change-Id: I3f0d4281db27ad23db7b25877277a42a6effd4e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3183635 Auto-Submit: Sammie Quon <[email protected]> Commit-Queue: Nancy Wang <[email protected]> Reviewed-by: Nancy Wang <[email protected]> Cr-Commit-Position: refs/heads/main@{#925089}
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0c958868..5ffc2828 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel [email protected],[email protected],[email protected] Change-Id: Ie7b5403594d5d7c6f49bea6696c8c89558bf52a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184242 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#925090}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9ffa7a4a05e1..1d1771262535 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Ic9e365f9d63b0f47a9358a667d961b772b645dbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184513 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#925091}
Fix a potential crash in fast_pair_repository_impl.cc, caused by running a once callback twice due to a forgotten "return" in an error handling branch. This issue was found by the bugprone-use-after-move clang-tidy diagnostics: fast_pair_repository_impl.cc:161: 'callback' used after it was moved fast_pair_repository_impl.cc:159: move occurred here Bug: 1122844 Change-Id: I5c989c8eb8adfa64bc0cf429848d33df009de4ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184322 Auto-Submit: Maksim Ivanov <[email protected]> Reviewed-by: Jon Mann <[email protected]> Commit-Queue: Jon Mann <[email protected]> Cr-Commit-Position: refs/heads/main@{#925092}
This CL includes changes to display PWA install message. The following will be added in a separate CLs: - The code to set description and icon - Handlers to react to user interaction (Install button click, message dismiss) BUG=1247374 Change-Id: I62fb7260e947d1ea6bc3fc7a5489f017559bf224 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3169952 Reviewed-by: Lijin Shen <[email protected]> Reviewed-by: Glenn Hartmann <[email protected]> Reviewed-by: Michael Thiessen <[email protected]> Commit-Queue: Pavel Yatsuk <[email protected]> Cr-Commit-Position: refs/heads/main@{#925093}
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202109260800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/VGbkbIQy4l5j2gmve_60OzV-VQA2ZqWVEJDnpLrE7IoC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: [email protected] Change-Id: I76536dcbb9e271f40a871380cf1aa572877be81f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184007 Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#925094}
Change-Id: I54863194fc24bad9c03fb90ebd6d2519acfbbc36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184524 Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#925095}
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:lacros-amd64-generic-chrome [email protected] Change-Id: Ic07ec760407ae2e8f6fff9e5bab21ee4ab34b2d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184243 Commit-Queue: ChromeOS bot <[email protected]> Bot-Commit: ChromeOS bot <[email protected]> Cr-Commit-Position: refs/heads/main@{#925096}
https://skia.googlesource.com/skia.git/+log/aeb5d4daed3a..496b89cb74b3 2021-09-26 [email protected] Update SKP version If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: [email protected] Change-Id: Id8f00a63627518462befb701d2406f66505d2ddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184658 Commit-Queue: chromium-autoroll <[email protected]> Bot-Commit: chromium-autoroll <[email protected]> Cr-Commit-Position: refs/heads/main@{#925097}
Automatic update for 2021-09-26 UTC Change-Id: I478350e1c39ebe07f685f85874d3871ff33f4f88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184899 Commit-Queue: CT Log list updates bot <[email protected]> Bot-Commit: CT Log list updates bot <[email protected]> Cr-Commit-Position: refs/heads/main@{#925098}
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202109260800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/YACky8ppLFM0FXPDau15wHt9xmw-BVM8HKnMLz5HQXgC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: [email protected] Change-Id: I66f734257bd2f23c7533dd7b88a5007565f7bcbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184008 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#925099}
Roll Chrome Linux PGO profile from chrome-linux-main-1632613016-45822416ec7d3bb4f62afb9f5de0d725a1f374f2.profdata to chrome-linux-main-1632625678-22a3e9462cda624da319caab3674327b73205ff0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: [email protected] Change-Id: Ie9616e595c06330f1e2e17643b85a9e5ab6b4ae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184600 Commit-Queue: chromium-autoroll <[email protected]> Bot-Commit: chromium-autoroll <[email protected]> Cr-Commit-Position: refs/heads/main@{#925100}
Bug: b/201197372 Bug: b/192521089 Change-Id: Ib080a637b62c24d47df01b2c244fcdea1cc6aaf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3183920 Owners-Override: Fergus Dall <[email protected]> Auto-Submit: Fergus Dall <[email protected]> Commit-Queue: Joel Hockey <[email protected]> Reviewed-by: Joel Hockey <[email protected]> Cr-Commit-Position: refs/heads/main@{#925101}
This method is required in upcoming tests to control the result of this call. Change-Id: Ie43484d415f448c7f74c1392701b50d3141c4603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3174294 Commit-Queue: Shane Fitzpatrick <[email protected]> Reviewed-by: Jon Mann <[email protected]> Cr-Commit-Position: refs/heads/main@{#925102}
Roll Chrome Win64 PGO profile from chrome-win64-main-1632613016-920ef4b6aad6e1e7efff235e4c1d1606e0a75b61.profdata to chrome-win64-main-1632624887-bf17608289ea3853613e1267b6ecb836a3e78a3a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: [email protected] Change-Id: I0c950870e1a718a7f22542cf9899db074769a841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184481 Commit-Queue: chromium-autoroll <[email protected]> Bot-Commit: chromium-autoroll <[email protected]> Cr-Commit-Position: refs/heads/main@{#925103}
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/10474d9f680f..fdb326ff691d 2021-09-26 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: [email protected] Change-Id: I02485e20e405ac6bffb039d48e87d48a15024135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184640 Commit-Queue: chromium-autoroll <[email protected]> Bot-Commit: chromium-autoroll <[email protected]> Cr-Commit-Position: refs/heads/main@{#925104}
Roll Chrome Mac PGO profile from chrome-mac-main-1632613016-15d316daa5cb0d3ce63998f5bf029971a584b138.profdata to chrome-mac-main-1632625678-7fcb34d1e3b7ddb3fc254057b98705345bcbaad7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: [email protected] Change-Id: Ie238f752846a870bb3a6a321aa5ad70de3025631 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184518 Commit-Queue: chromium-autoroll <[email protected]> Bot-Commit: chromium-autoroll <[email protected]> Cr-Commit-Position: refs/heads/main@{#925105}
https://webrtc.googlesource.com/src.git/+log/b6a73b69233c..96168abfb74c 2021-09-26 [email protected] Update WebRTC code version (2021-09-26T04:03:45). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: [email protected] Change-Id: Id3dcee81cf6f9916f9237200b6b8569cf1cefa3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184649 Commit-Queue: chromium-autoroll <[email protected]> Bot-Commit: chromium-autoroll <[email protected]> Cr-Commit-Position: refs/heads/main@{#925106}
Roll Chrome Win32 PGO profile from chrome-win32-main-1632613016-a73b4e09f16f6a9ecdaeee0578e76a908107f2fc.profdata to chrome-win32-main-1632624887-926c058f916f49344d541360fcf9d6a9e9deac4b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: [email protected] Change-Id: I808977e841dfca5efc83ca771e0801064e3fb8ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184515 Commit-Queue: chromium-autoroll <[email protected]> Bot-Commit: chromium-autoroll <[email protected]> Cr-Commit-Position: refs/heads/main@{#925107}
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: [email protected] Disable-Retries: true Change-Id: I9ecf3bc70e5e75c215cf616d561608877878f4cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184639 Commit-Queue: chromium-autoroll <[email protected]> Bot-Commit: chromium-autoroll <[email protected]> Cr-Commit-Position: refs/heads/main@{#925108}
This is approved in http://shortn/_F1xGHkKSRw Bug: 1143122 Change-Id: Ib258ff76396765d80c9084146a61c1472bb2973d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3180923 Reviewed-by: Fumitoshi Ukai <[email protected]> Commit-Queue: Takuto Ikuta <[email protected]> Cr-Commit-Position: refs/heads/main@{#925109}
Fix a potential issue in browser_app_instance_registry.cc with the same object being used for reading and for std::move()'ing from within the same expression. This is only a potential issue, since currently it's only happening with the base::UnguessableToken object, whose move constructor leaves the moved-from object in the same state as before moving; still, it's a potential bug if this gets changed or other fields become read from. This issue was found by the bugprone-use-after-move clang-tidy diagnostics: browser_app_instance_registry.cc:284: 'update' used after it was moved browser_app_instance_registry.cc:285: move occurred here browser_app_instance_registry.cc:284: the use and move are unsequenced, i.e. there is no guarantee about the order in which they are evaluated Bug: 1122844 Change-Id: Iea34617e57e3981bd7d062092baa631b14c1bb5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184739 Auto-Submit: Maksim Ivanov <[email protected]> Commit-Queue: Dominick Ng <[email protected]> Reviewed-by: Dominick Ng <[email protected]> Cr-Commit-Position: refs/heads/main@{#925110}
Roll Chrome Win64 PGO profile from chrome-win64-main-1632624887-bf17608289ea3853613e1267b6ecb836a3e78a3a.profdata to chrome-win64-main-1632625678-e531df8aa016871399e6678aa3d33807f48febaf.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: [email protected] Change-Id: Ifc5da9504821a39a0829482469707d0c23a9d0d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3183379 Commit-Queue: chromium-autoroll <[email protected]> Bot-Commit: chromium-autoroll <[email protected]> Cr-Commit-Position: refs/heads/main@{#925111}
Roll Chrome Win32 PGO profile from chrome-win32-main-1632624887-926c058f916f49344d541360fcf9d6a9e9deac4b.profdata to chrome-win32-main-1632625678-a947020e084e041a2efb58a847e9b1b657244667.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: [email protected] Change-Id: Icb43e8df1e07b633f2fc10d148a1aaa3a7646a50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184723 Commit-Queue: chromium-autoroll <[email protected]> Bot-Commit: chromium-autoroll <[email protected]> Cr-Commit-Position: refs/heads/main@{#925112}
pull bot
pushed a commit
that referenced
this pull request
Sep 27, 2021
This reverts commit 37ea471. Reason for revert: Reverted CL is unrelated to the cited "reason for revert". Original change's description: > Revert "Privatise unnecessarily public current_input_method in" > > This reverts commit 77e9679. > > Reason for revert: > Likely cause of failure > Step "browser_tests on Ubuntu-18.04" failing on builder "linux-chromeos-chrome" > > The failure is a crash in browser_tests. > > This failure is fairly but not perfectly consistent. In three of the last four runs on this bot, browser_tests failed with something in the NativeInputMethodEngineTest.EmojiSuggestion* suite. It's not always the same test that fails each time. Nevertheless, this is pretty indicative that nowadays something is wrong in this suite. This is the obvious candidate, submitted right when the test became mostly-failing. > > Here is the first failure as an example: > Retrying 1 test (retry #0) > [ RUN ] NativeInputMethodEngineTest.EmojiSuggestionDisabledReasonkUrlOrAppNotAllowed > 2021-09-24T11:30:01.258384Z WARNING browser_tests[27592:27592]: [audio_manager_linux.cc(60)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized. > [434.616] default_socket.cc:58 /run/perfetto/ exists but cannot be accessed. Falling back on /tmp/ (errno: 13, Permission denied) > 2021-09-24T11:30:01.293097Z WARNING browser_tests[27592:27609]: [wallpaper_decoder.cc(29)] Failed reading file > 2021-09-24T11:30:01.304548Z ERROR browser_tests[27592:27592]: [print_job_reporting_service_factory.cc(47)] DMToken must be valid > 2021-09-24T11:30:01.309314Z ERROR browser_tests[27592:27592]: [proximity_auth_profile_pref_manager.cc(194)] Failed to find local state prefs for current user. > 2021-09-24T11:30:01.332070Z WARNING browser_tests[27592:27592]: [remote_commands_service.cc(188)] Client is not registered. > 2021-09-24T11:30:01.358975Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.359074Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Cache: 0MB > 2021-09-24T11:30:01.359110Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.README: 0MB > 2021-09-24T11:30:01.359138Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.359147Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.WebData: 0MB > 2021-09-24T11:30:01.359429Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.CodeCache: 0MB > 2021-09-24T11:30:01.359547Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SiteCharacteristicsDatabase: 0MB > 2021-09-24T11:30:01.359581Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Favicons: 0MB > 2021-09-24T11:30:01.359621Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginDataForAccount: 0MB > 2021-09-24T11:30:01.360073Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.GCache: 0MB > 2021-09-24T11:30:01.360118Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.History: 0MB > 2021-09-24T11:30:01.360147Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.360161Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.360173Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.360234Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.360415Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SyncData: 0MB > 2021-09-24T11:30:01.361882Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOCK: 0MB > 2021-09-24T11:30:01.361936Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginData: 0MB > 2021-09-24T11:30:01.361964Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOG: 0MB > 2021-09-24T11:30:01.362091Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.412518Z ERROR browser_tests[27592:27592]: [plugin_vm_manager_impl.cc(150)] New session has dispatcher unexpected already running. Perhaps Chrome crashed? > 2021-09-24T11:30:01.433615Z INFO browser_tests[27592:27592]: [key_permissions_manager_impl.cc(509)] One-time key permissions migration started for token: 0. > 2021-09-24T11:30:01.451071Z WARNING browser_tests[27592:27592]: [drivefs_session.cc(65)] DriveFs mount failed with error: 3 > 2021-09-24T11:30:01.458878Z WARNING browser_tests[27592:27592]: [login_unlock_throughput_recorder.cc(58)] Zero frames expected in login animation throughput data > 2021-09-24T11:30:01.464809Z INFO browser_tests[27592:27592]: [android_sms_pairing_state_tracker_impl.cc(71)] No Pairing cookie found > 2021-09-24T11:30:01.470495Z INFO browser_tests[27592:27592]: [ui_test_utils.cc(224)] NavigateToURL: chrome://newtab/ > 2021-09-24T11:30:01.473373Z WARNING browser_tests[27592:27639]: [google_brand_chromeos.cc(40)] Brand code file missing: /opt/oem/etc/BRAND_CODE > 2021-09-24T11:30:01.535229Z ERROR browser_tests[27592:27639]: [als_reader.cc(52)] Missing num of als > 2021-09-24T11:30:01.535643Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(230)] crbug.com/1216328: Checking Bluetooth availability started. Please report if there is no report that this ends. > 2021-09-24T11:30:01.535680Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(233)] crbug.com/1216328: Checking Bluetooth availability ended. > 2021-09-24T11:30:01.535688Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(236)] crbug.com/1216328: Checking default browser status started. Please report if there is no report that this ends. > 2021-09-24T11:30:01.535695Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(240)] crbug.com/1216328: Checking default browser status ended. > 2021-09-24T11:30:01.555145Z INFO browser_tests[27592:27592]: [key_permissions_manager_impl.cc(534)] One-time key permissions migration succeeded for token: 0. > BrowserTestBase received signal: Segmentation fault. Backtrace: > #0 0x556151f72449 base::debug::CollectStackTrace() > #1 0x556151ed9d73 base::debug::StackTrace::StackTrace() > #2 0x5561525e4683 content::(anonymous namespace)::DumpStackTraceSignalHandler() > #3 0x7f7dd56e2040 (/lib/x86_64-linux-gnu/libc-2.27.so+0x3f03f) > #4 0x5561556c8304 ChromeOmniboxNavigationObserver::DidFinishNavigation() > #5 0x5561503c8362 content::WebContentsImpl::WebContentsObserverList::NotifyObservers<>() > #6 0x5561503d05f0 content::WebContentsImpl::DidFinishNavigation() > #7 0x5561502a5093 content::NavigationRequest::~NavigationRequest() > #8 0x5561502a59dc content::NavigationRequest::~NavigationRequest() > #9 0x5561502b8919 content::Navigator::DidNavigate() > #10 0x5561502caeed content::RenderFrameHostImpl::DidCommitNavigationInternal() > #11 0x5561502ca24a content::RenderFrameHostImpl::DidCommitNavigation() > #12 0x5561502e9d60 base::internal::FunctorTraits<>::Invoke<>() > #13 0x5561502e9d0f base::internal::Invoker<>::RunOnce() > #14 0x55614fd53470 content::mojom::NavigationClient_CommitFailedNavigation_ForwardToCallback::Accept() > #15 0x55615301c6e0 mojo::InterfaceEndpointClient::HandleValidatedMessage() > #16 0x5561530201e0 mojo::MessageDispatcher::Accept() > #17 0x55615301d435 mojo::InterfaceEndpointClient::HandleIncomingMessage() > #18 0x5561531dc3e2 IPC::(anonymous namespace)::ChannelAssociatedGroupController::AcceptOnEndpointThread() > #19 0x55615301e323 base::internal::Invoker<>::RunOnce() > #20 0x556151f35f23 base::TaskAnnotator::RunTask() > #21 0x556151f467b3 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl() > #22 0x556151f46569 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() > #23 0x556151f46b32 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() > #24 0x556151fa9c4b base::MessagePumpLibevent::Run() > #25 0x556151f46d6d base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() > #26 0x556151f18c1b base::RunLoop::Run() > #27 0x556151ec159d InProcessBrowserTest::RunUntilBrowserProcessQuits() > #28 0x556151ec207f InProcessBrowserTest::QuitBrowsers() > #29 0x556151ec1fce InProcessBrowserTest::PostRunTestOnMainThread() > #30 0x5561525e3d34 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() > #31 0x556152012479 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() > #32 0x55615201197e ChromeBrowserMainParts::PreMainMessageLoopRun() > #33 0x55614efa9b98 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() > #34 0x5561500381cd content::BrowserMainLoop::PreMainMessageLoopRun() > #35 0x5561503a1a9c content::StartupTaskRunner::RunAllTasksNow() > #36 0x556150037e4a content::BrowserMainLoop::CreateStartupTasks() > #37 0x55615003a147 content::BrowserMainRunnerImpl::Initialize() > #38 0x556150036912 content::BrowserMain() > #39 0x556150bf6aed content::RunBrowserProcessMain() > #40 0x556150bf79bd content::ContentMainRunnerImpl::RunBrowser() > #41 0x556150bf752e content::ContentMainRunnerImpl::Run() > #42 0x556150bf5b38 content::RunContentProcess() > #43 0x556150bf5c08 content::ContentMain() > #44 0x5561525e3543 content::BrowserTestBase::SetUp() > #45 0x556151ec12c1 InProcessBrowserTest::SetUp() > #46 0x55614e1c8786 ash::input_method::(anonymous namespace)::NativeInputMethodEngineTest::SetUp() > #47 0x55614f308e8f testing::Test::Run() > #48 0x55614f3097c5 testing::TestInfo::Run() > #49 0x55614f309f21 testing::TestSuite::Run() > #50 0x55614f313798 testing::internal::UnitTestImpl::RunAllTests() > #51 0x55614f31338b testing::UnitTest::Run() > #52 0x556151fd7ff2 base::TestSuite::Run() > #53 0x556151e96409 BrowserTestSuiteRunnerChromeOS::RunTestSuite() > #54 0x556152613c1f content::LaunchTests() > #55 0x556151e98224 LaunchChromeTests() > #56 0x556151e9638b main > #57 0x7f7dd56c4bf7 __libc_start_main > #58 0x55614cca11ea _start > from > https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/17628 > > Here is the fourth: (different test in the same suite, different stack trace): > [ RUN ] NativeInputMethodEngineTest.EmojiSuggestionDisabledReasonkUserSettingsOff > 2021-09-24T16:19:05.593039Z WARNING browser_tests[31407:31407]: [audio_manager_linux.cc(60)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized. > [959.207] default_socket.cc:58 /run/perfetto/ exists but cannot be accessed. Falling back on /tmp/ (errno: 13, Permission denied) > 2021-09-24T16:19:05.646514Z WARNING browser_tests[31407:31423]: [wallpaper_decoder.cc(29)] Failed reading file > 2021-09-24T16:19:05.673272Z ERROR browser_tests[31407:31407]: [print_job_reporting_service_factory.cc(47)] DMToken must be valid > 2021-09-24T16:19:05.678360Z ERROR browser_tests[31407:31407]: [proximity_auth_profile_pref_manager.cc(194)] Failed to find local state prefs for current user. > 2021-09-24T16:19:05.728926Z WARNING browser_tests[31407:31407]: [remote_commands_service.cc(188)] Client is not registered. > 2021-09-24T16:19:05.763864Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.763999Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Cache: 0MB > 2021-09-24T16:19:05.764049Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.README: 0MB > 2021-09-24T16:19:05.764094Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.764120Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.WebData: 0MB > 2021-09-24T16:19:05.764270Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.CodeCache: 0MB > 2021-09-24T16:19:05.764446Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SiteCharacteristicsDatabase: 0MB > 2021-09-24T16:19:05.765718Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Favicons: 0MB > 2021-09-24T16:19:05.765751Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginDataForAccount: 0MB > 2021-09-24T16:19:05.766067Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.GCache: 0MB > 2021-09-24T16:19:05.766094Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.History: 0MB > 2021-09-24T16:19:05.766115Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.766123Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.766131Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.766199Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.766336Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LocalStorage: 0MB > 2021-09-24T16:19:05.766472Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SyncData: 0MB > 2021-09-24T16:19:05.766498Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOCK: 0MB > 2021-09-24T16:19:05.766524Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginData: 0MB > 2021-09-24T16:19:05.766552Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOG: 0MB > 2021-09-24T16:19:05.766909Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.880798Z ERROR browser_tests[31407:31407]: [plugin_vm_manager_impl.cc(150)] New session has dispatcher unexpected already running. Perhaps Chrome crashed? > 2021-09-24T16:19:05.921761Z INFO browser_tests[31407:31407]: [key_permissions_manager_impl.cc(509)] One-time key permissions migration started for token: 0. > 2021-09-24T16:19:05.932877Z WARNING browser_tests[31407:31407]: [drivefs_session.cc(65)] DriveFs mount failed with error: 3 > 2021-09-24T16:19:05.951965Z WARNING browser_tests[31407:31407]: [login_unlock_throughput_recorder.cc(58)] Zero frames expected in login animation throughput data > 2021-09-24T16:19:05.973007Z INFO browser_tests[31407:31407]: [android_sms_pairing_state_tracker_impl.cc(71)] No Pairing cookie found > 2021-09-24T16:19:05.977396Z WARNING browser_tests[31407:31428]: [google_brand_chromeos.cc(40)] Brand code file missing: /opt/oem/etc/BRAND_CODE > 2021-09-24T16:19:05.981581Z INFO browser_tests[31407:31407]: [ui_test_utils.cc(224)] NavigateToURL: chrome://newtab/ > 2021-09-24T16:19:06.072941Z ERROR browser_tests[31407:31457]: [als_reader.cc(52)] Missing num of als > 2021-09-24T16:19:06.073283Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(230)] crbug.com/1216328: Checking Bluetooth availability started. Please report if there is no report that this ends. > 2021-09-24T16:19:06.073310Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(233)] crbug.com/1216328: Checking Bluetooth availability ended. > 2021-09-24T16:19:06.073337Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(236)] crbug.com/1216328: Checking default browser status started. Please report if there is no report that this ends. > 2021-09-24T16:19:06.073358Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(240)] crbug.com/1216328: Checking default browser status ended. > 2021-09-24T16:19:06.085536Z INFO browser_tests[31407:31407]: [key_permissions_manager_impl.cc(534)] One-time key permissions migration succeeded for token: 0. > BrowserTestBase received signal: Segmentation fault. Backtrace: > #0 0x564f24b8af29 base::debug::CollectStackTrace() > #1 0x564f24af2843 base::debug::StackTrace::StackTrace() > #2 0x564f251fd373 content::(anonymous namespace)::DumpStackTraceSignalHandler() > #3 0x7f03d338d040 (/lib/x86_64-linux-gnu/libc-2.27.so+0x3f03f) > #4 0x564f282e0d94 ChromeOmniboxNavigationObserver::DidFinishNavigation() > #5 0x564f22fe1042 content::WebContentsImpl::WebContentsObserverList::NotifyObservers<>() > #6 0x564f22fe92d0 content::WebContentsImpl::DidFinishNavigation() > #7 0x564f22ebdd73 content::NavigationRequest::~NavigationRequest() > #8 0x564f22ebe6bc content::NavigationRequest::~NavigationRequest() > #9 0x564f22ed15f9 content::Navigator::DidNavigate() > #10 0x564f22ee3bcd content::RenderFrameHostImpl::DidCommitNavigationInternal() > #11 0x564f22ee2f2a content::RenderFrameHostImpl::DidCommitNavigation() > #12 0x564f22f02a40 base::internal::FunctorTraits<>::Invoke<>() > #13 0x564f22f029ef base::internal::Invoker<>::RunOnce() > #14 0x564f2296c430 content::mojom::NavigationClient_CommitFailedNavigation_ForwardToCallback::Accept() > #15 0x564f25c35100 mojo::InterfaceEndpointClient::HandleValidatedMessage() > #16 0x564f25c38c00 mojo::MessageDispatcher::Accept() > #17 0x564f25c35e55 mojo::InterfaceEndpointClient::HandleIncomingMessage() > #18 0x564f25df4e02 IPC::(anonymous namespace)::ChannelAssociatedGroupController::AcceptOnEndpointThread() > #19 0x564f25c36d43 base::internal::Invoker<>::RunOnce() > #20 0x564f24b4ea03 base::TaskAnnotator::RunTask() > #21 0x564f24b5f293 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl() > #22 0x564f24b5f049 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() > #23 0x564f24b5f612 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() > #24 0x564f24bc28cb base::MessagePumpLibevent::Run() > #25 0x564f24b5f84d base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() > #26 0x564f24b316fb base::RunLoop::Run() > #27 0x564f22f433f3 content::BrowserTaskExecutor::RunAllPendingTasksOnThreadForTesting() > #28 0x564f2522df45 content::RunAllPendingInMessageLoop() > #29 0x564f24adaa96 InProcessBrowserTest::PostRunTestOnMainThread() > #30 0x564f251fca24 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() > #31 0x564f24c2b0f9 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() > #32 0x564f24c2a5fe ChromeBrowserMainParts::PreMainMessageLoopRun() > #33 0x564f21bc1f38 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() > #34 0x564f22c510ed content::BrowserMainLoop::PreMainMessageLoopRun() > #35 0x564f22fba77c content::StartupTaskRunner::RunAllTasksNow() > #36 0x564f22c50d6a content::BrowserMainLoop::CreateStartupTasks() > #37 0x564f22c53067 content::BrowserMainRunnerImpl::Initialize() > #38 0x564f22c4f832 content::BrowserMain() > #39 0x564f2380f5bd content::RunBrowserProcessMain() > #40 0x564f2381048d content::ContentMainRunnerImpl::RunBrowser() > #41 0x564f2380fffe content::ContentMainRunnerImpl::Run() > #42 0x564f2380e608 content::RunContentProcess() > #43 0x564f2380e6d8 content::ContentMain() > #44 0x564f251fc233 content::BrowserTestBase::SetUp() > #45 0x564f24ad9d91 InProcessBrowserTest::SetUp() > #46 0x564f20de0a86 ash::input_method::(anonymous namespace)::NativeInputMethodEngineTest::SetUp() > #47 0x564f21f21e4f testing::Test::Run() > #48 0x564f21f22785 testing::TestInfo::Run() > #49 0x564f21f22ee1 testing::TestSuite::Run() > #50 0x564f21f2c758 testing::internal::UnitTestImpl::RunAllTests() > #51 0x564f21f2c34b testing::UnitTest::Run() > #52 0x564f24bf0c72 base::TestSuite::Run() > #53 0x564f24aaeed9 BrowserTestSuiteRunnerChromeOS::RunTestSuite() > #54 0x564f2522c62f content::LaunchTests() > #55 0x564f24ab0cf4 LaunchChromeTests() > #56 0x564f24aaee5b main > #57 0x7f03d336fbf7 __libc_start_main > #58 0x564f1f8b94ea _start > from > https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/17631 > > Original change's description: > > Privatise unnecessarily public current_input_method in > > InputMethodManagerImpl::StateImpl. > > > > This involves replacing some direct pokes of current_input_method > > with public GetCurrentInputMethod() that employs a fallback onto > > InputMethodUtil::GetFallbackInputMethodDescriptor() when ID is > > blank. This should be more reasonable and consistent. > > > > Bug: 1134465 > > Change-Id: I2c423a58547cc7249efdf8056624623998765aba > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3177760 > > Commit-Queue: Bao-Duy Tran <[email protected]> > > Reviewed-by: Keith Lee <[email protected]> > > Reviewed-by: Curtis McMullan <[email protected]> > > Cr-Commit-Position: refs/heads/main@{#924702} > > Bug: 1134465 > Change-Id: I6144a0ebd7472f31d4b937d9e99b6a6c8bc0eee1 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3182806 > Auto-Submit: Mark Pearson <[email protected]> > Bot-Commit: Rubber Stamper <[email protected]> > Commit-Queue: Mark Pearson <[email protected]> > Owners-Override: Mark Pearson <[email protected]> > Cr-Commit-Position: refs/heads/main@{#924810} Bug: 1134465 Change-Id: I358d66835e54d67d8d151e3da38da9a8f33d83bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184801 Bot-Commit: Rubber Stamper <[email protected]> Reviewed-by: Darren Shen <[email protected]> Commit-Queue: Bao-Duy Tran <[email protected]> Cr-Commit-Position: refs/heads/main@{#925158}
pull bot
pushed a commit
that referenced
this pull request
Oct 26, 2024
This reverts commit ecb74d5. Reason for revert: A series of bots such as "Linux Tests (dbg)(1)", "Linux ASan LSan Tests (1)" started failing consistently in browser_tests for these two tests: PreviewBrowserTest.ErrorOnNonHttpsUrl PreviewBrowserTest.ErrorOnRedirectionToNonHttpsUrl after this change was submitted. More complete bot list is below [1]. Both of those tests are both prerender-related. This is the only prerender-related change on the blamelist. The former somtimes fails with vector.h(1305): Check failed: i < size() (0 vs. 0) See full stack trace below [2]. The latter sometimes fails with preview_manager.cc(73): Check failed: tab_. See full stack trace below [3]. I have also seen the former fail with the "Check failed: tab_." error message. And on some bots I have also seen a full-blown crash (unexpected abort). Also, on some both I have seen other PreviewBrowserTest failures at this time, such as PreviewBrowserTest.MojoCapabilityControl, with similar errors. [1] bots that fail: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ASan%20LSan%20Tests%20(1)/128871/blamelist https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/61153/blamelist https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/47171/blamelist https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20MSan%20Tests/51450/blamelist https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/122977/blamelist https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-dbg/37765/blamelist [2] PreviewBrowserTest.ErrorOnNonHttpsUrl [ RUN ] PreviewBrowserTest.ErrorOnNonHttpsUrl [292860:292860:1025/041435.600171:WARNING:field_trial_util.cc(106)] Field trial config study skipped: LinkPreview.EnabledAltClick (some of its features are already overridden) [292860:292860:1025/041435.613074:WARNING:field_trial_util.cc(106)] Field trial config study skipped: PreconnectToSearchDesktop.EnabledWithStartupDelayForegroundOnly (some of its features are already overridden) [292947:292947:1025/041436.521543:WARNING:gpu_memory_buffer_support_x11.cc(49)] dri3 extension not supported. [292947:292947:1025/041436.577861:WARNING:sandbox_linux.cc(430)] InitializeSandbox() called with multiple threads in process gpu-process. [292947:292947:1025/041436.602554:WARNING:viz_main_impl.cc(85)] VizNullHypothesis is disabled (not a warning) [292948:292979:1025/041438.220989:WARNING:simple_synchronous_entry.cc(1449)] Could not open platform files for entry. [292860:292860:1025/041439.058422:WARNING:idle_linux.cc(110)] None of the known D-Bus ScreenSaver services could be used. [292860:293018:1025/041439.668033:WARNING:embedded_test_server.cc(757)] Request not handled. Returning 404: /favicon.ico [293019:293019:1025/041440.636001:ERROR:html_media_element.cc(4927)] SetError: {code=4, message="MEDIA_ELEMENT_ERROR: Media load rejected by URL safety check"} [293019:293019:1025/041440.796426:FATAL:vector.h(1305)] Check failed: i < size() (0 vs. 0) #0 0x63a93d38d586 in ___interceptor_backtrace /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/asan/../sanitizer_common/sanitizer_common_interceptors.inc:4441:13 #1 0x63a95f5dc688 in base::debug::CollectStackTrace(base::span<void const*, 18446744073709551615ul, void const**>) ./../../base/debug/stack_trace_posix.cc:1047:7 #2 0x63a95f593489 in base::debug::StackTrace::StackTrace(unsigned long) ./../../base/debug/stack_trace.cc:245:20 #3 0x63a95f253ece in logging::LogMessage::Flush() ./../../base/logging.cc:725:29 #4 0x63a95f25396d in logging::LogMessage::~LogMessage() ./../../base/logging.cc:713:3 #5 0x63a95f20756b in ~CheckLogMessage ./../../base/check.cc:193:3 #6 0x63a95f20756b in logging::(anonymous namespace)::CheckLogMessage::~CheckLogMessage() ./../../base/check.cc:190:31 #7 0x63a95f206f30 in operator() ./../../third_party/libc++/src/include/__memory/unique_ptr.h:75:5 #8 0x63a95f206f30 in reset ./../../third_party/libc++/src/include/__memory/unique_ptr.h:297:7 #9 0x63a95f206f30 in logging::NotReachedError::~NotReachedError() ./../../base/check.cc:355:16 #10 0x63a975d348af in WTF::Vector<blink::PaintChunk, 0u, blink::HeapAllocator>::at(unsigned int) const ./../../third_party/blink/renderer/platform/wtf/vector.h:1305:5 #11 0x63a975d57f4b in operator[] ./../../third_party/blink/renderer/platform/wtf/vector.h:1310:52 #12 0x63a975d57f4b in blink::PaintChunkSubset::operator[](unsigned int) const ./../../third_party/blink/renderer/platform/graphics/paint/paint_chunk_subset.h:108:12 #13 0x63a975d9700d in FirstPaintChunk ./../../third_party/blink/renderer/platform/graphics/compositing/pending_layer.cc:183:10 #14 0x63a975d9700d in blink::PendingLayer::Matches(blink::PendingLayer const&) const ./../../third_party/blink/renderer/platform/graphics/compositing/pending_layer.cc:196:54 #15 0x63a975d23989 in Find ./../../third_party/blink/renderer/platform/graphics/compositing/paint_artifact_compositor.cc:73:21 #16 0x63a975d23989 in blink::PaintArtifactCompositor::Update(blink::PaintArtifact const&, blink::PaintArtifactCompositor::ViewportProperties const&, blink::HeapVector<cppgc::internal::BasicMember<blink::TransformPaintPropertyNode const, cppgc::internal::StrongMemberTag, cppgc::internal::DijkstraWriteBarrierPolicy, cppgc::internal::DisabledCheckingPolicy, cppgc::internal::CompressedPointer>, 32u> const&, WTF::Vector<std::__Cr::unique_ptr<cc::ViewTransitionRequest, std::__Cr::default_delete<cc::ViewTransitionRequest>>, 0u, WTF::PartitionAllocator>) ./../../third_party/blink/renderer/platform/graphics/compositing/paint_artifact_compositor.cc:1006:35 #17 0x63a9711e76ef in blink::LocalFrameView::PushPaintArtifactToCompositor(bool) ./../../third_party/blink/renderer/core/frame/local_frame_view.cc:3017:31 #18 0x63a9711de07f in blink::LocalFrameView::RunPaintLifecyclePhase(blink::PaintBenchmarkMode) ./../../third_party/blink/renderer/core/frame/local_frame_view.cc:2677:5 #19 0x63a9711d825b in blink::LocalFrameView::UpdateLifecyclePhasesInternal(blink::DocumentLifecycle::LifecycleState) ./../../third_party/blink/renderer/core/frame/local_frame_view.cc:2377:3 #20 0x63a9711cfedd in blink::LocalFrameView::UpdateLifecyclePhases(blink::DocumentLifecycle::LifecycleState, blink::DocumentUpdateReason) ./../../third_party/blink/renderer/core/frame/local_frame_view.cc:2181:3 #21 0x63a9711ced65 in blink::LocalFrameView::UpdateAllLifecyclePhases(blink::DocumentUpdateReason) ./../../third_party/blink/renderer/core/frame/local_frame_view.cc:1908:54 #22 0x63a973c8b458 in blink::PageAnimator::UpdateAllLifecyclePhases(blink::LocalFrame&, blink::DocumentUpdateReason) ./../../third_party/blink/renderer/core/page/page_animator.cc:397:9 #23 0x63a97146de8d in blink::WebFrameWidgetImpl::UpdateLifecycle(blink::WebLifecycleUpdate, blink::DocumentUpdateReason) ./../../third_party/blink/renderer/core/frame/web_frame_widget_impl.cc:1663:14 #24 0x63a9761f2ce6 in UpdateVisualState ./../../third_party/blink/renderer/platform/widget/widget_base.cc:1027:12 #25 0x63a9761f2ce6 in non-virtual thunk to blink::WidgetBase::UpdateVisualState() ./../../third_party/blink/renderer/platform/widget/widget_base.cc:0:0 #26 0x63a9685d7f9e in cc::LayerTreeHost::RequestMainFrameUpdate(bool) ./../../cc/trees/layer_tree_host.cc:386:12 #27 0x63a968929d27 in cc::ProxyMain::BeginMainFrame(std::__Cr::unique_ptr<cc::BeginMainFrameAndCommitState, std::__Cr::default_delete<cc::BeginMainFrameAndCommitState>>) ./../../cc/trees/proxy_main.cc:296:21 #28 0x63a96895daca in Invoke<void (cc::ProxyMain::*)(std::__Cr::unique_ptr<cc::BeginMainFrameAndCommitState, std::__Cr::default_delete<cc::BeginMainFrameAndCommitState> >), const base::WeakPtr<cc::ProxyMain> &, std::__Cr::unique_ptr<cc::BeginMainFrameAndCommitState, std::__Cr::default_delete<cc::BeginMainFrameAndCommitState> > > ./../../base/functional/bind_internal.h:738:12 #29 0x63a96895daca in MakeItSo<void (cc::ProxyMain::*)(std::__Cr::unique_ptr<cc::BeginMainFrameAndCommitState, std::__Cr::default_delete<cc::BeginMainFrameAndCommitState> >), std::__Cr::tuple<base::WeakPtr<cc::ProxyMain>, std::__Cr::unique_ptr<cc::BeginMainFrameAndCommitState, std::__Cr::default_delete<cc::BeginMainFrameAndCommitState> > > > ./../../base/functional/bind_internal.h:954:5 #30 0x63a96895daca in void base::internal::Invoker<base::internal::FunctorTraits<void (cc::ProxyMain::*&&)(std::__Cr::unique_ptr<cc::BeginMainFrameAndCommitState, std::__Cr::default_delete<cc::BeginMainFrameAndCommitState>>), base::WeakPtr<cc::ProxyMain>&&, std::__Cr::unique_ptr<cc::BeginMainFrameAndCommitState, std::__Cr::default_delete<cc::BeginMainFrameAndCommitState>>&&>, base::internal::BindState<true, true, false, void (cc::ProxyMain::*)(std::__Cr::unique_ptr<cc::BeginMainFrameAndCommitState, std::__Cr::default_delete<cc::BeginMainFrameAndCommitState>>), base::WeakPtr<cc::ProxyMain>, std::__Cr::unique_ptr<cc::BeginMainFrameAndCommitState, std::__Cr::default_delete<cc::BeginMainFrameAndCommitState>>>, void ()>::RunImpl<void (cc::ProxyMain::*)(std::__Cr::unique_ptr<cc::BeginMainFrameAndCommitState, std::__Cr::default_delete<cc::BeginMainFrameAndCommitState>>), std::__Cr::tuple<base::WeakPtr<cc::ProxyMain>, std::__Cr::unique_ptr<cc::BeginMainFrameAndCommitState, std::__Cr::default_delete<cc::BeginMainFrameAndCommitState>>>, 0ul, 1ul>(void (cc::ProxyMain::*&&)(std::__Cr::unique_ptr<cc::BeginMainFrameAndCommitState, std::__Cr::default_delete<cc::BeginMainFrameAndCommitState>>), std::__Cr::tuple<base::WeakPtr<cc::ProxyMain>, std::__Cr::unique_ptr<cc::BeginMainFrameAndCommitState, std::__Cr::default_delete<cc::BeginMainFrameAndCommitState>>>&&, std::__Cr::integer_sequence<unsigned long, 0ul, 1ul>) ./../../base/functional/bind_internal.h:1067:14 #31 0x63a93d44d4f8 in base::OnceCallback<void ()>::Run() && ./../../base/functional/callback.h:156:12 #32 0x63a95f3ccd8c in base::TaskAnnotator::RunTaskImpl(base::PendingTask&) ./../../base/task/common/task_annotator.cc:202:34 #33 0x63a95f473609 in RunTask<(lambda at ../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:473:11)> ./../../base/task/common/task_annotator.h:98:5 #34 0x63a95f473609 in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(base::LazyNow*) ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:471:23 #35 0x63a95f4718ba in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:332:40 #36 0x63a95f474b5b in non-virtual thunk to base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:0:0 #37 0x63a95f28090b in base::MessagePumpDefault::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_default.cc:40:55 #38 0x63a95f475cb8 in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run(bool, base::TimeDelta) ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:641:12 #39 0x63a95f34b020 in base::RunLoop::Run(base::Location const&) ./../../base/run_loop.cc:133:14 #40 0x63a97f98da9d in content::RendererMain(content::MainFunctionParams) ./../../content/renderer/renderer_main.cc:361:16 #41 0x63a95c23b8f7 in content::RunZygote(content::ContentMainDelegate*) ./../../content/app/content_main_runner_impl.cc:700:14 #42 0x63a95c23cc43 in content::RunOtherNamedProcessTypeMain(std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> const&, content::MainFunctionParams, content::ContentMainDelegate*) ./../../content/app/content_main_runner_impl.cc:804:12 #43 0x63a95c23fa5f in content::ContentMainRunnerImpl::Run() ./../../content/app/content_main_runner_impl.cc:1164:10 #44 0x63a95c2397f3 in content::RunContentProcess(content::ContentMainParams, content::ContentMainRunner*) ./../../content/app/content_main.cc:356:36 #45 0x63a95c23a05c in content::ContentMain(content::ContentMainParams) ./../../content/app/content_main.cc:369:10 #46 0x63a9625187d6 in content::LaunchTestsInternal(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:385:12 #47 0x63a962519512 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:504:10 #48 0x63a96dc8f449 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:338:10 #49 0x63a95ef8f627 in main ./../../chrome/test/base/browser_tests_main.cc:60:10 #50 0x780e7da29d90 in __libc_start_call_main ./csu/../sysdeps/nptl/libc_start_call_main.h:58:16 #51 0x780e7da29e40 in __libc_start_main ./csu/../csu/libc-start.c:392:3 #52 0x63a93d34702a in _start ??:0:0 Task trace: #0 0x63a9689511e6 in cc::ProxyImpl::ScheduledActionSendBeginMainFrame(viz::BeginFrameArgs const&) ./../../cc/trees/proxy_impl.cc:760:7 #1 0x63a96892e967 in cc::ProxyMain::SendCommitRequestToImplThreadIfNeeded(cc::ProxyMain::CommitPipelineStage) ./../../cc/trees/proxy_main.cc:878:7 #2 0x63a976caa6c1 in blink::HTMLDocumentParser::SchedulePumpTokenizer(bool) ./../../third_party/blink/renderer/core/html/parser/html_document_parser.cc:890:7 #3 0x63a976caa6c1 in blink::HTMLDocumentParser::SchedulePumpTokenizer(bool) ./../../third_party/blink/renderer/core/html/parser/html_document_parser.cc:890:7 #4 0x63a976caa6c1 in blink::HTMLDocumentParser::SchedulePumpTokenizer(bool) ./../../third_party/blink/renderer/core/html/parser/html_document_parser.cc:890:7 Task trace buffer limit hit, update PendingTask::kTaskBacktraceLength to increase. Crash keys: ... [omitted rest] [3] PreviewBrowserTest.ErrorOnRedirectionToNonHttpsUrl stack trace: [ RUN ] PreviewBrowserTest.ErrorOnRedirectionToNonHttpsUrl [444109:444109:1025/041553.399357:WARNING:field_trial_util.cc(106)] Field trial config study skipped: LinkPreview.EnabledAltClick (some of its features are already overridden) [444109:444109:1025/041553.404344:WARNING:field_trial_util.cc(106)] Field trial config study skipped: PreconnectToSearchDesktop.EnabledWithStartupDelayForegroundOnly (some of its features are already overridden) [444182:444182:1025/041554.079734:WARNING:gpu_memory_buffer_support_x11.cc(49)] dri3 extension not supported. [444182:444182:1025/041554.104499:WARNING:sandbox_linux.cc(430)] InitializeSandbox() called with multiple threads in process gpu-process. [444182:444182:1025/041554.121502:WARNING:viz_main_impl.cc(85)] VizNullHypothesis is disabled (not a warning) [444183:444252:1025/041556.053677:WARNING:simple_synchronous_entry.cc(1449)] Could not open platform files for entry. [444109:444109:1025/041557.583553:WARNING:idle_linux.cc(110)] None of the known D-Bus ScreenSaver services could be used. [444109:444362:1025/041558.554846:WARNING:embedded_test_server.cc(757)] Request not handled. Returning 404: /favicon.ico [444383:444383:1025/041559.563402:ERROR:html_media_element.cc(4927)] SetError: {code=4, message="MEDIA_ELEMENT_ERROR: Media load rejected by URL safety check"} [444383:444383:1025/041559.590330:ERROR:html_media_element.cc(4927)] SetError: {code=4, message="MEDIA_ELEMENT_ERROR: Media load rejected by URL safety check"} [444383:444383:1025/041559.591717:ERROR:html_media_element.cc(4927)] SetError: {code=4, message="MEDIA_ELEMENT_ERROR: Media load rejected by URL safety check"} chrome/browser/preloading/preview/preview_test_util.cc:35: Failure Failed RunLoop::Run() timed out. Timeout set at ProxyRunTestOnMainThreadLoop@content/public/test/browser_test_base.cc:862. Stack trace: #0 0x581999742852 in base::test::(anonymous namespace)::TimeoutCallbackWithGtestFailure(base::Location const&, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> ()>, base::Location const&) ./../../base/test/scoped_run_loop_timeout.cc:59:3 #1 0x581999743998 in Invoke<void (*const &)(const base::Location &, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char> > ()>, const base::Location &), const base::Location &, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char> > ()>, const base::Location &> ./../../base/functional/bind_internal.h:671:12 #2 0x581999743998 in MakeItSo<void (*const &)(const base::Location &, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char> > ()>, const base::Location &), const std::__Cr::tuple<> &, const base::Location &, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char> > ()>, const base::Location &> ./../../base/functional/bind_internal.h:930:12 #3 0x581999743998 in RunImpl<void (*const &)(const base::Location &, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char> > ()>, const base::Location &), const std::__Cr::tuple<> &> ./../../base/functional/bind_internal.h:1067:14 #4 0x581999743998 in base::internal::Invoker<base::internal::FunctorTraits<void (* const&)(base::Location const&, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> ()>, base::Location const&)>, base::internal::BindState<false, true, false, void (*)(base::Location const&, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> ()>, base::Location const&)>, void (base::Location const&, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> ()>, base::Location const&)>::Run(base::internal::BindStateBase*, base::Location const&, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> ()>&&, base::Location const&) ./../../base/functional/bind_internal.h:987:12 #5 0x58199974311b in base::RepeatingCallback<void (base::Location const&, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> ()>, base::Location const&)>::Run(base::Location const&, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> ()>, base::Location const&) const & ./../../base/functional/callback.h:344:12 #6 0x581999742dde in Invoke<const base::RepeatingCallback<void (const base::Location &, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char> > ()>, const base::Location &)> &, const base::Location &, const base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char> > ()> &, const base::Location &> ./../../base/functional/bind_internal.h:830:49 #7 0x581999742dde in MakeItSo<const base::RepeatingCallback<void (const base::Location &, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char> > ()>, const base::Location &)> &, const std::__Cr::tuple<base::Location, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char> > ()> > &, const base::Location &> ./../../base/functional/bind_internal.h:930:12 #8 0x581999742dde in RunImpl<const base::RepeatingCallback<void (const base::Location &, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char> > ()>, const base::Location &)> &, const std::__Cr::tuple<base::Location, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char> > ()> > &, 0UL, 1UL> ./../../base/functional/bind_internal.h:1067:14 #9 0x581999742dde in base::internal::Invoker<base::internal::FunctorTraits<base::RepeatingCallback<void (base::Location const&, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> ()>, base::Location const&)> const&, base::Location const&, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> ()> const&>, base::internal::BindState<false, true, true, base::RepeatingCallback<void (base::Location const&, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> ()>, base::Location const&)>, base::Location, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> ()>>, void (base::Location const&)>::Run(base::internal::BindStateBase*, base::Location const&) ./../../base/functional/bind_internal.h:987:12 #10 0x5819993b1250 in base::OnceCallback<void (base::Location const&)>::Run(base::Location const&) && ./../../base/functional/callback.h:156:12 #11 0x5819993aa151 in base::(anonymous namespace)::OnRunLoopTimeout(base::RunLoop*, base::Location const&, base::OnceCallback<void (base::Location const&)>) ./../../base/run_loop.cc:40:25 #12 0x5819993b0c25 in Invoke<void (*)(base::RunLoop *, const base::Location &, base::OnceCallback<void (const base::Location &)>), base::RunLoop *, base::Location, base::RepeatingCallback<void (const base::Location &)> > ./../../base/functional/bind_internal.h:671:12 #13 0x5819993b0c25 in MakeItSo<void (*)(base::RunLoop *, const base::Location &, base::OnceCallback<void (const base::Location &)>), std::__Cr::tuple<base::internal::UnretainedWrapper<base::RunLoop, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0>, base::Location, base::RepeatingCallback<void (const base::Location &)> > > ./../../base/functional/bind_internal.h:930:12 #14 0x5819993b0c25 in RunImpl<void (*)(base::RunLoop *, const base::Location &, base::OnceCallback<void (const base::Location &)>), std::__Cr::tuple<base::internal::UnretainedWrapper<base::RunLoop, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0>, base::Location, base::RepeatingCallback<void (const base::Location &)> >, 0UL, 1UL, 2UL> ./../../base/functional/bind_internal.h:1067:14 #15 0x5819993b0c25 in base::internal::Invoker<base::internal::FunctorTraits<void (*&&)(base::RunLoop*, base::Location const&, base::OnceCallback<void (base::Location const&)>), base::RunLoop*, base::Location&&, base::RepeatingCallback<void (base::Location const&)>&&>, base::internal::BindState<false, true, false, void (*)(base::RunLoop*, base::Location const&, base::OnceCallback<void (base::Location const&)>), base::internal::UnretainedWrapper<base::RunLoop, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0>, base::Location, base::RepeatingCallback<void (base::Location const&)>>, void ()>::RunOnce(base::internal::BindStateBase*) ./../../base/functional/bind_internal.h:980:12 #16 0x5819774ab4f8 in base::OnceCallback<void ()>::Run() && ./../../base/functional/callback.h:156:12 #17 0x58197f9e29d4 in void base::internal::CancelableCallbackImpl<base::OnceCallback<void ()>>::ForwardOnce<>() ./../../base/cancelable_callback.h:134:26 #18 0x58197f9e2f2e in Invoke<void (base::internal::CancelableCallbackImpl<base::OnceCallback<void ()> >::*)(), const base::WeakPtr<base::internal::CancelableCallbackImpl<base::OnceCallback<void ()> > > &> ./../../base/functional/bind_internal.h:738:12 #19 0x58197f9e2f2e in MakeItSo<void (base::internal::CancelableCallbackImpl<base::OnceCallback<void ()> >::*)(), std::__Cr::tuple<base::WeakPtr<base::internal::CancelableCallbackImpl<base::OnceCallback<void ()> > > > > ./../../base/functional/bind_internal.h:954:5 #20 0x58197f9e2f2e in void base::internal::Invoker<base::internal::FunctorTraits<void (base::internal::CancelableCallbackImpl<base::OnceCallback<void ()>>::*&&)(), base::WeakPtr<base::internal::CancelableCallbackImpl<base::OnceCallback<void ()>>>&&>, base::internal::BindState<true, true, false, void (base::internal::CancelableCallbackImpl<base::OnceCallback<void ()>>::*)(), base::WeakPtr<base::internal::CancelableCallbackImpl<base::OnceCallback<void ()>>>>, void ()>::RunImpl<void (base::internal::CancelableCallbackImpl<base::OnceCallback<void ()>>::*)(), std::__Cr::tuple<base::WeakPtr<base::internal::CancelableCallbackImpl<base::OnceCallback<void ()>>>>, 0ul>(void (base::internal::CancelableCallbackImpl<base::OnceCallback<void ()>>::*&&)(), std::__Cr::tuple<base::WeakPtr<base::internal::CancelableCallbackImpl<base::OnceCallback<void ()>>>>&&, std::__Cr::integer_sequence<unsigned long, 0ul>) ./../../base/functional/bind_internal.h:1067:14 #21 0x5819774ab4f8 in base::OnceCallback<void ()>::Run() && ./../../base/functional/callback.h:156:12 #22 0x58199942ad8c in base::TaskAnnotator::RunTaskImpl(base::PendingTask&) ./../../base/task/common/task_annotator.cc:202:34 #23 0x5819994d1609 in RunTask<(lambda at ../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:473:11)> ./../../base/task/common/task_annotator.h:98:5 #24 0x5819994d1609 in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(base::LazyNow*) ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:471:23 #25 0x5819994cf8ba in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:332:40 #26 0x5819994d2b5b in non-virtual thunk to base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:0:0 #27 0x5819996866c3 in base::MessagePumpGlib::HandleDispatch() ./../../base/message_loop/message_pump_glib.cc:649:46 #28 0x581999689959 in base::(anonymous namespace)::WorkSourceDispatch(_GSource*, int (*)(void*), void*) ./../../base/message_loop/message_pump_glib.cc:274:43 #29 0x703e1f8f4d3b in g_main_context_dispatch ??:0:0 #30 0x703e1f94a2b8 in g_io_channel_new_file ??:? #31 0x703e1f8f23e3 in g_main_context_iteration ??:0:0 #32 0x581999686cf0 in base::MessagePumpGlib::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_glib.cc:683:30 #33 0x5819994d3cb8 in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run(bool, base::TimeDelta) ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:641:12 #34 0x5819993a9020 in base::RunLoop::Run(base::Location const&) ./../../base/run_loop.cc:133:14 #35 0x58199909ac37 in Wait ./../../chrome/browser/preloading/preview/preview_test_util.cc:35:17 #36 0x58199909ac37 in test::PreviewTestHelper::WaitUntilLoadFinished() ./../../chrome/browser/preloading/preview/preview_test_util.cc:90:16 #37 0x58197f539b56 in PreviewBrowserTest_ErrorOnRedirectionToNonHttpsUrl_Test::RunTestOnMainThread() ./../../chrome/browser/preloading/preview/preview_browsertest.cc:309:12 #38 0x58199c3a39c1 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:955:9 #39 0x58199c3a81c4 in Invoke<void (content::BrowserTestBase::*)(), content::BrowserTestBase *> ./../../base/functional/bind_internal.h:738:12 #40 0x58199c3a81c4 in MakeItSo<void (content::BrowserTestBase::*)(), std::__Cr::tuple<base::internal::UnretainedWrapper<content::BrowserTestBase, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0> > > ./../../base/functional/bind_internal.h:930:12 #41 0x58199c3a81c4 in RunImpl<void (content::BrowserTestBase::*)(), std::__Cr::tuple<base::internal::UnretainedWrapper<content::BrowserTestBase, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0> >, 0UL> ./../../base/functional/bind_internal.h:1067:14 #42 0x58199c3a81c4 in base::internal::Invoker<base::internal::FunctorTraits<void (content::BrowserTestBase::*&&)(), content::BrowserTestBase*>, base::internal::BindState<true, true, false, void (content::BrowserTestBase::*)(), base::internal::UnretainedWrapper<content::BrowserTestBase, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0>>, void ()>::RunOnce(base::internal::BindStateBase*) ./../../base/functional/bind_internal.h:980:12 #43 0x5819774ab4f8 in base::OnceCallback<void ()>::Run() && ./../../base/functional/callback.h:156:12 #44 0x58198e84361a in InterceptMainMessageLoopRun ./../../content/browser/browser_main_loop.cc:1074:36 #45 0x58198e84361a in content::BrowserMainLoop::RunMainMessageLoop() ./../../content/browser/browser_main_loop.cc:1086:7 #46 0x58198e84c18d in content::BrowserMainRunnerImpl::Run() ./../../content/browser/browser_main_runner_impl.cc:156:15 #47 0x58198e839c99 in content::BrowserMain(content::MainFunctionParams) ./../../content/browser/browser_main.cc:34:28 #48 0x58199629a625 in content::RunBrowserProcessMain(content::MainFunctionParams, content::ContentMainDelegate*) ./../../content/app/content_main_runner_impl.cc:732:10 #49 0x58199629e5ed in content::ContentMainRunnerImpl::RunBrowser(content::MainFunctionParams, bool) ./../../content/app/content_main_runner_impl.cc:1311:10 #50 0x58199629da92 in content::ContentMainRunnerImpl::Run() ./../../content/app/content_main_runner_impl.cc:1162:12 #51 0x5819962977f3 in content::RunContentProcess(content::ContentMainParams, content::ContentMainRunner*) ./../../content/app/content_main.cc:356:36 #52 0x58199629805c in content::ContentMain(content::ContentMainParams) ./../../content/app/content_main.cc:369:10 #53 0x58199c3a1792 in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:622:3 #54 0x5819991ef1d3 in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:542:20 [444109:444109:1025/041658.647315:FATAL:preview_manager.cc(73)] Check failed: tab_. #0 0x5819773eb586 in ___interceptor_backtrace /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/asan/../sanitizer_common/sanitizer_common_interceptors.inc:4441:13 #1 0x58199963a688 in base::debug::CollectStackTrace(base::span<void const*, 18446744073709551615ul, void const**>) ./../../base/debug/stack_trace_posix.cc:1047:7 #2 0x5819995f1489 in base::debug::StackTrace::StackTrace(unsigned long) ./../../base/debug/stack_trace.cc:245:20 #3 0x5819992b1ece in logging::LogMessage::Flush() ./../../base/logging.cc:725:29 #4 0x5819992b196d in logging::LogMessage::~LogMessage() ./../../base/logging.cc:713:3 #5 0x58199926556b in ~CheckLogMessage ./../../base/check.cc:193:3 #6 0x58199926556b in logging::(anonymous namespace)::CheckLogMessage::~CheckLogMessage() ./../../base/check.cc:190:31 #7 0x581999264f30 in operator() ./../../third_party/libc++/src/include/__memory/unique_ptr.h:75:5 #8 0x581999264f30 in reset ./../../third_party/libc++/src/include/__memory/unique_ptr.h:297:7 #9 0x581999264f30 in logging::NotReachedError::~NotReachedError() ./../../base/check.cc:355:16 #10 0x58199a3afe8f in PreviewManager::GetWebContentsForPreviewTab() ./../../chrome/browser/preloading/preview/preview_manager.cc:73:3 #11 0x58197f539b87 in PreviewBrowserTest_ErrorOnRedirectionToNonHttpsUrl_Test::RunTestOnMainThread() ./../../chrome/browser/preloading/preview/preview_browsertest.cc:312:16 #12 0x58199c3a39c1 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:955:9 #13 0x58199c3a81c4 in Invoke<void (content::BrowserTestBase::*)(), content::BrowserTestBase *> ./../../base/functional/bind_internal.h:738:12 #14 0x58199c3a81c4 in MakeItSo<void (content::BrowserTestBase::*)(), std::__Cr::tuple<base::internal::UnretainedWrapper<content::BrowserTestBase, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0> > > ./../../base/functional/bind_internal.h:930:12 #15 0x58199c3a81c4 in RunImpl<void (content::BrowserTestBase::*)(), std::__Cr::tuple<base::internal::UnretainedWrapper<content::BrowserTestBase, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0> >, 0UL> ./../../base/functional/bind_internal.h:1067:14 #16 0x58199c3a81c4 in base::internal::Invoker<base::internal::FunctorTraits<void (content::BrowserTestBase::*&&)(), content::BrowserTestBase*>, base::internal::BindState<true, true, false, void (content::BrowserTestBase::*)(), base::internal::UnretainedWrapper<content::BrowserTestBase, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0>>, void ()>::RunOnce(base::internal::BindStateBase*) ./../../base/functional/bind_internal.h:980:12 #17 0x5819774ab4f8 in base::OnceCallback<void ()>::Run() && ./../../base/functional/callback.h:156:12 #18 0x58198e84361a in InterceptMainMessageLoopRun ./../../content/browser/browser_main_loop.cc:1074:36 #19 0x58198e84361a in content::BrowserMainLoop::RunMainMessageLoop() ./../../content/browser/browser_main_loop.cc:1086:7 #20 0x58198e84c18d in content::BrowserMainRunnerImpl::Run() ./../../content/browser/browser_main_runner_impl.cc:156:15 #21 0x58198e839c99 in content::BrowserMain(content::MainFunctionParams) ./../../content/browser/browser_main.cc:34:28 #22 0x58199629a625 in content::RunBrowserProcessMain(content::MainFunctionParams, content::ContentMainDelegate*) ./../../content/app/content_main_runner_impl.cc:732:10 #23 0x58199629e5ed in content::ContentMainRunnerImpl::RunBrowser(content::MainFunctionParams, bool) ./../../content/app/content_main_runner_impl.cc:1311:10 #24 0x58199629da92 in content::ContentMainRunnerImpl::Run() ./../../content/app/content_main_runner_impl.cc:1162:12 #25 0x5819962977f3 in content::RunContentProcess(content::ContentMainParams, content::ContentMainRunner*) ./../../content/app/content_main.cc:356:36 #26 0x58199629805c in content::ContentMain(content::ContentMainParams) ./../../content/app/content_main.cc:369:10 #27 0x58199c3a1792 in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:622:3 #28 0x5819991ef1d3 in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:542:20 #29 0x581996ad3b19 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #30 0x581996ad3b19 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2723:3 #31 0x581996ad61c2 in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2874:11 #32 0x581996ad7d64 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:3052:30 #33 0x581996aff5b5 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5982:44 #34 0x581996afe64f in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #35 0x581996afe64f in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5561:10 #36 0x581999761d1c in base::TestSuite::Run() ./../../base/test/test_suite.cc:421:16 #37 0x5819a7cecba7 in RunTestSuiteInternal ./../../chrome/test/base/chrome_test_launcher.cc:99:22 #38 0x5819a7cecba7 in ChromeTestSuiteRunner::RunTestSuite(int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:104:10 #39 0x58199c576a7d in content::LaunchTestsInternal(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:409:31 #40 0x58199c577512 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:504:10 #41 0x5819a7ced449 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:338:10 #42 0x581998fed627 in main ./../../chrome/test/base/browser_tests_main.cc:60:10 #43 0x703e1da29d90 in __libc_start_call_main ./csu/../sysdeps/nptl/libc_start_call_main.h:58:16 #44 0x703e1da29e40 in __libc_start_main ./csu/../csu/libc-start.c:392:3 #45 0x5819773a502a in _start ??:0:0 Crash keys: ... [omitted rest] Original change's description: > Prerender: first impl to dry run painting on prerendering page > > This CL triggers tree build right after renderer parsed the main DOM > tree. CHCKEs on the browser side will guard the metric correctness. > (See Ifd788c4b04f06a6b98caff1bb9df55af5fb8f07a) > The following CLs will: > 1. only trigger it for DSE. > 2. add more metrics on the renderer side to verify the correctness. > > Bug: 40240492 > Change-Id: Icd94bad6a6ecfc5e492e4d9c4b4c227741c041d2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5912738 > Reviewed-by: Hiroki Nakagawa <[email protected]> > Reviewed-by: Taiyo Mizuhashi <[email protected]> > Commit-Queue: Lingqi Chi <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1373803} Bug: 40240492 Change-Id: I8729c84b4ceb1a77761c738f96c4c03675dfcdb0 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5966495 Commit-Queue: Mark Pearson <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Owners-Override: Mark Pearson <[email protected]> Auto-Submit: Mark Pearson <[email protected]> Cr-Commit-Position: refs/heads/main@{#1374047}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )