Add check if google-re2 is declared as dependency (apache#33240)

For providers that are using google-re2 it should be declared as dependency. Follow up after apache#33237
joeknize-bc · Aug 9, 2023 · c7e6914 · c7e6914
1 parent 0b528e2
commit c7e6914
Show file tree

Hide file tree

Showing 6 changed files with 170 additions and 62 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -364,6 +364,14 @@ repos:
         pass_filenames: true
         files: ^airflow/providers/.*\.py$
         additional_dependencies: ['rich>=12.4.4']
+      - id: check-google-re2-as-dependency
+        name: Check google-re2 is declared as dependency when needed
+        entry: ./scripts/ci/pre_commit/pre_commit_check_google_re2_imports.py
+        language: python
+        pass_filenames: true
+        require_serial: true
+        files: ^airflow/providers/.*\.py$
+        additional_dependencies: ['rich>=12.4.4']
       - id: update-local-yml-file
         name: Update mounts in the local yml file
         entry: ./scripts/ci/pre_commit/pre_commit_local_yml_mounts.py

diff --git a/STATIC_CODE_CHECKS.rst b/STATIC_CODE_CHECKS.rst
@@ -187,6 +187,8 @@ require Breeze Docker image to be built locally.
 +-----------------------------------------------------------+--------------------------------------------------------------+---------+
 | check-for-inclusive-language                              | Check for language that we do not accept as community        |         |
 +-----------------------------------------------------------+--------------------------------------------------------------+---------+
+| check-google-re2-as-dependency                            | Check google-re2 is declared as dependency when needed       |         |
++-----------------------------------------------------------+--------------------------------------------------------------+---------+
 | check-hooks-apply                                         | Check if all hooks apply to the repository                   |         |
 +-----------------------------------------------------------+--------------------------------------------------------------+---------+
 | check-incorrect-use-of-LoggingMixin                       | Make sure LoggingMixin is not used alone                     |         |

diff --git a/dev/breeze/src/airflow_breeze/pre_commit_ids.py b/dev/breeze/src/airflow_breeze/pre_commit_ids.py
@@ -47,6 +47,7 @@
     "check-extra-packages-references",
     "check-extras-order",
     "check-for-inclusive-language",
+    "check-google-re2-as-dependency",
     "check-hooks-apply",
     "check-incorrect-use-of-LoggingMixin",
     "check-init-decorator-arguments",

diff --git a/images/breeze/output-commands-hash.txt b/images/breeze/output-commands-hash.txt
@@ -62,7 +62,7 @@ setup:version:be116d90a21c2afe01087f7609774e1e
 setup:cdf58a9c27af2877dc5a658ed0a1d99c
 shell:87e7bdcebe1180395adfec86b2a065f5
 start-airflow:f7216a8126ecf14b033e2ea677e1a105
-static-checks:a6b76083afc49c0c80270facd5236b42
+static-checks:5ded21248cd4f5617779f58ecf6c554c
 testing:docker-compose-tests:0c810047fc66a0cfe91119e2d08b3507
 testing:helm-tests:8e491da2e01ebd815322c37562059d77
 testing:integration-tests:486e4d91449ecdb7630ef2a470d705a3