-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.1] Prevent deleting a parent template if children exist #36191
The head ref may contain hidden characters: "4.1-dev\u2014prevent-deleting-parent-if-there-are-children"
[4.1] Prevent deleting a parent template if children exist #36191
Conversation
b32afe7
to
de5b4ff
Compare
I have tested this item ✅ successfully on de5b4ff This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36191. |
I have tested this item ✅ successfully on de5b4ff This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36191. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36191. |
Yes, you're right the template was created for another PR (the wysiwyg tinyMCE) and I haven't updated it since. Probably I will since I want a base template with dark support... |
Thx |
joomla/joomla-cms#30522 + joomla/joomla-cms#32223 + joomla/joomla-cms#31675 + joomla/joomla-cms#35378 + joomla/joomla-cms#35612 + joomla/joomla-cms#35715 + joomla/joomla-cms#35610 + joomla/joomla-cms#35607 + joomla/joomla-cms#35788 + joomla/joomla-cms#35647 + joomla/joomla-cms#35143 + joomla/joomla-cms#36135 + joomla/joomla-cms#35998 + joomla/joomla-cms#36173 + joomla/joomla-cms#36212 + joomla/joomla-cms#36208 + joomla/joomla-cms#36206 + joomla/joomla-cms#36205 + joomla/joomla-cms#36203 + joomla/joomla-cms#36192 + joomla/joomla-cms#36191 + joomla/joomla-cms#36228 + joomla/joomla-cms#36211 + joomla/joomla-cms#36271 + joomla/joomla-cms#36270 + joomla/joomla-cms#36245 + joomla/joomla-cms#36294 + joomla/joomla-cms#36244 + joomla/joomla-cms#36242 + joomla/joomla-cms#36296 + joomla/joomla-cms#36190 + joomla/joomla-cms#36474 + joomla/joomla-cms#36297 + joomla/joomla-cms#36480 + joomla/joomla-cms#36479 + joomla/joomla-cms#36551 + joomla/joomla-cms#36366 + joomla/joomla-cms#36589 + joomla/joomla-cms#36583 + joomla/joomla-cms#36328 + joomla/joomla-cms#36515 + joomla/joomla-cms#36555 + joomla/joomla-cms#36653 + joomla/joomla-cms#36660 + joomla/joomla-cms#36657 + joomla/joomla-cms#36637 + joomla/joomla-cms#35983 + joomla/joomla-cms#36704 + joomla/joomla-cms#36708 + joomla/joomla-cms#36700 +
Pull Request for Issue # .
Summary of Changes
To prevent possible disaster (deleting a parent template but child still around and default) a simple check was added in the installer
Testing Instructions
Actual result BEFORE applying this Pull Request
The parent template will be removed
Expected result AFTER applying this Pull Request
Error message and parent template wasn't removed
Documentation Changes Required