Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.1] Prevent deleting a parent template if children exist #36191

Conversation

dgrammatiko
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

To prevent possible disaster (deleting a parent template but child still around and default) a simple check was added in the installer

Testing Instructions

Actual result BEFORE applying this Pull Request

The parent template will be removed

Expected result AFTER applying this Pull Request

Error message and parent template wasn't removed

Screenshot 2021-12-03 at 21 58 28

Documentation Changes Required

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.1-dev labels Dec 3, 2021
@dgrammatiko dgrammatiko force-pushed the 4.1-dev—prevent-deleting-parent-if-there-are-children branch from b32afe7 to de5b4ff Compare December 3, 2021 21:09
@khu5h1
Copy link
Contributor

khu5h1 commented Dec 4, 2021

I have tested this item ✅ successfully on de5b4ff


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36191.

@RickR2H
Copy link
Member

RickR2H commented Dec 5, 2021

I have tested this item ✅ successfully on de5b4ff

Patch works! @dgrammatiko Not related but probably good to mention. I noticed that the icons of the Cassy theme are missing. Also the CSS custom properties of the template styling are missing. Switching to Cassy theme will leave the header transparent.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36191.

@RickR2H
Copy link
Member

RickR2H commented Dec 5, 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36191.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 5, 2021
@dgrammatiko
Copy link
Contributor Author

Also the CSS custom properties of the template styling are missing. Switching to Cassy theme will leave the header transparent.

Yes, you're right the template was created for another PR (the wysiwyg tinyMCE) and I haven't updated it since. Probably I will since I want a base template with dark support...

@bembelimen bembelimen merged commit f7c66d0 into joomla:4.1-dev Dec 7, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 7, 2021
@bembelimen
Copy link
Contributor

Thx

@dgrammatiko dgrammatiko deleted the 4.1-dev—prevent-deleting-parent-if-there-are-children branch December 7, 2021 10:07
@Quy Quy added this to the Joomla 4.1 milestone Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants