Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.1] Fix Image Size Check with scheduler #36653

Merged
merged 10 commits into from
Jan 14, 2022

Conversation

bembelimen
Copy link
Contributor

@bembelimen bembelimen commented Jan 12, 2022

Summary of Changes

  • Fix the resizing of the image with the scheduler task
  • Improve the description to make aware, that the file will be overwritten

Testing Instructions

  • Create a task from the type "Image Size Check"
  • Run it

Actual result BEFORE applying this Pull Request

Image sizes are not changed.

Expected result AFTER applying this Pull Request

Image sizes are changed.

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.1-dev labels Jan 12, 2022
@brianteeman
Copy link
Contributor

I have tested this item 🔴 unsuccessfully on 4b49ad2

Resizes the first image found that is too big but then says its completed


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36653.

@chmst
Copy link
Contributor

chmst commented Jan 12, 2022

I have tested this item ✅ successfully on 4b49ad2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36653.

@bembelimen
Copy link
Contributor Author

I have tested this item red_circle unsuccessfully on 4b49ad2Resizes the first image found that is too big but then says its completed

It was always the intention to change one image per run to prevent any timeouts.

@brianteeman
Copy link
Contributor

Then it must be clearly documented otherwise it will appear to be broken.

Although I have to say if it only does one image per run then it is pretty useless

@bembelimen
Copy link
Contributor Author

Updated the PR to allow more than one image per run.

bembelimen and others added 3 commits January 13, 2022 17:44
…cms into 4.1/fix-filesize-task

# Conflicts:
#	administrator/language/en-GB/plg_task_checkfiles.ini
@chmst
Copy link
Contributor

chmst commented Jan 14, 2022

Now I get this error:
grafik

Folder Sample Data. Fresh installation of the full package.

@chmst
Copy link
Contributor

chmst commented Jan 14, 2022

Maybe only my local environment: ERROR Routine threw exception: The GD extension for PHP is not available.

@drmenzelit
Copy link
Contributor

I have tested this item ✅ successfully on 99bbefd

Tested with 1 image, it works. Changed the settings to maximum images = 3, uploaded 4 big images, 3 where changed successfully on the next run. The 4th image was changed too in the next run.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36653.

@chmst
Copy link
Contributor

chmst commented Jan 14, 2022

I have tested this item ✅ successfully on 99bbefd

Re-tested on web server and it works.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36653.

@drmenzelit
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36653.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 14, 2022
@bembelimen bembelimen merged commit 4e191c9 into joomla:4.1-dev Jan 14, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 14, 2022
@bembelimen
Copy link
Contributor Author

Thanks all for the feedback and the improvements.

@bembelimen bembelimen added this to the Joomla 4.1.0 milestone Jan 14, 2022
@bembelimen bembelimen deleted the 4.1/fix-filesize-task branch March 15, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants