Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.1] Request interval seconds #36660

Merged
merged 1 commit into from
Jan 14, 2022
Merged

Conversation

brianteeman
Copy link
Contributor

Adds the unit otherwise you have no way of knowing it is seconds and to be consistent to the task timeout label

After

image

Adds the unit otherwise you have no way of knowing it is seconds and to be consistent to the task timeout label
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.1-dev labels Jan 12, 2022
@Quy
Copy link
Contributor

Quy commented Jan 12, 2022

I have tested this item ✅ successfully on 97370d9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36660.

@tecpromotion
Copy link
Contributor

I have tested this item ✅ successfully on 97370d9

thanks


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36660.

@tecpromotion
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36660.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Jan 12, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36660.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 12, 2022
@C-Lodder
Copy link
Member

Just an FYI, you can add addonAfter="seconds" to the XML field so that it displays like so:

image

Note: Not saying it has to be done like this, but worth mentioning as not many know about this feature.

@bembelimen bembelimen merged commit a8eaaf4 into joomla:4.1-dev Jan 14, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 14, 2022
@bembelimen bembelimen added this to the Joomla 4.1.0 milestone Jan 14, 2022
@bembelimen
Copy link
Contributor

Thx

@brianteeman
Copy link
Contributor Author

thanks

@brianteeman brianteeman deleted the interval branch January 14, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants