Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0 dayone fixes (recreated) #397

Closed
wants to merge 35 commits into from

Conversation

minchinweb
Copy link
Contributor

This is a recreation of PR#350 as it no longer would cleanly merge into the 2.0-rc1 branch. That PR focused mainly on maintaining DayOne metadata and exposing that metadata to the YAML exporter.

This pull request builds on that by fixing an issue where the Markdown and YAML exporters were printing extra spaces. This also includes a fix for #222.

Close #350.

wren and others added 26 commits June 22, 2019 13:06
…ensuring the URLs are valid (except build badge)
[jrnl-orgGH-598] Changing references from jrnl-plus back to jrnl
[jrnl-orgGH-602] Add a code of conduct file (rather than adding to contributing)
[jrnl-orgGH-600] updating Travis build badge and restoring pypi badges
[jrnl-orgGH-605] mentioning lack of Day One support and relevant history in readme
@micahellison micahellison added the day one Issues related to Day One (dayoneapp.com) label Jul 7, 2019
@stale
Copy link

stale bot commented Jul 7, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 7, 2019
@wren wren removed the stale label Jul 29, 2019
@minchinweb minchinweb force-pushed the 2.0-dayone-fixes-merge branch from 060565c to e188b83 Compare August 2, 2019 03:44
@minchinweb
Copy link
Contributor Author

Closed in favour of #350, as new code is being pushed to master again.

@minchinweb minchinweb closed this Aug 2, 2019
@minchinweb minchinweb deleted the 2.0-dayone-fixes-merge branch August 2, 2019 03:46
@lock
Copy link

lock bot commented May 21, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the 🔒 Outdated label May 21, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
day one Issues related to Day One (dayoneapp.com) 🔒 Outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants