-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jsk_topic_tools] Add diagnostic transport to ConnectionBasedTransport #1711
Conversation
This class is a subclass of [`ConnectionBasedTransport`](python_connection_based_transport.html). | ||
Instances of this class can publish diagnostics messages. | ||
This is an abstruct class. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this feature is designed for human operator to observe the health of robot system on rqt_robot_monitor
?, please add image of diagnostic viewer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. I'll add it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -130,3 +134,47 @@ def advertise(self, *args, **kwargs): | |||
pub = rospy.Publisher(*args, **kwargs) | |||
self._publishers.append(pub) | |||
return pub | |||
|
|||
|
|||
class DiagnosticTransport(ConnectionBasedTransport): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of create new class, how about update ConnectionBasedTransport
and enable this feature when /use_vital_check_on_connection_based_transport
(or other good variable name) is true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good idea!
I merge diagnostic function to ConnectionBasedTransport
.
c8efdb1
Add _Publisher class to check last published time.
Fixed vital_rate document. Co-authored-by: Shingo Kitagawa <[email protected]>
What is this?
This PR has added the ability to output diagnostics to the
ConnectionBasedTransport
.Checking the node status by diagnostics
You can check diagnostics by setting
~enable_vital_check
totrue
.There is no one to subscribe to
/simple_image_transport/output
, so diagnostics is OK.If you subscribe to
/simple_image_transport/output
,it will change to the diagnostics message
/simple_image_transport is running
.When changing input for
simple_image_transport
by mux, the error message will change to/simple_image_transport is not running
.You can check if the node is running correctly like these.