Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsk_fetch_startup] Do not use ConnectionBasedTransport in correct_position.py #1499

Closed

Conversation

708yamaguchi
Copy link
Member

From knorth55#254

Since jsk-ros-pkg/jsk_common#1711 is merged, correct_position.py output the following diagnostics error.

"/Other/correct_position:  correct_position"
Other correct position:  correct position  correct position is not running for 1.0 sec

This is because correct_position.py does not publish /initialpose (in other words self.last_published_time is not updated) when fetch is un-docked.

With this PR, I suppress the diagnostics error by removing ConnectionBasedTransport from correct_position.py.
I think this PR does not increase fetch's CPU usage very much, because correct_position.py does not use CPU resource even if /initialpose is always published .

@knorth55
Copy link
Member

knorth55 commented Jun 3, 2022

I don't think it is a good idea to change the existing node and adopt to new feature.
This PR is needed because Timer publisher is not considered in the ConnectionBasedTransport, right.
Hmmm, it becomes more difficult to write node which works properly...

@708yamaguchi
Copy link
Member Author

Thank you for your advice.

Based on offline talk and jsk-ros-pkg/jsk_common#1740, move to #1500

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants