[jsk_fetch_startup] Do not use ConnectionBasedTransport in correct_position.py #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since jsk-ros-pkg/jsk_common#1711 is merged,
correct_position.pyoutput the following diagnostics error.This is because
correct_position.pydoes not publish/initialpose(in other wordsself.last_published_timeis not updated) when fetch is un-docked.With this PR, I suppress the diagnostics error by removing
ConnectionBasedTransportfromcorrect_position.py.I think this PR does not increase fetch's CPU usage very much, because
correct_position.pydoes not use CPU resource even if/initialposeis always published .