Code

Create/delete subscription#12

Code

Merged

tdelabro merged 41 commits intomasterkabocha-network/pallet_subscription:masterfrom eljo_subscription_create_deletekabocha-network/pallet_subscription:eljo_subscription_create_deleteCopy head branch name to clipboardAug 3, 2022

+3,570

Commits

Commits on Jun 14, 2022

• first build ideas

  gdnathan

  committed
  5c04026

  Copy full SHA for 5c04026

• updated with what we'll show

  gdnathan

  committed
  1f5ac65

  Copy full SHA for 1f5ac65

Commits on Jun 22, 2022

• save working progress

  herou

  committed
  e208fe8

  Copy full SHA for e208fe8

• Add subscribe extrinsic

  herou

  committed
  15468a6

  Copy full SHA for 15468a6

Commits on Jun 24, 2022

• Add unit tests for subscribe extrinsic

  herou

  committed
  da9f6b3

  Copy full SHA for da9f6b3

Commits on Jun 27, 2022

• PR review working progress

  herou

  committed
  fcd5b4a

  Copy full SHA for fcd5b4a

Commits on Jun 28, 2022

• PR review

  Show description for 4c5ba4a
  herou

  committed
  4c5ba4a

  Copy full SHA for 4c5ba4a

Commits on Jun 29, 2022

• PR review #3

  Show description for 26592cc
  herou

  committed
  26592cc

  Copy full SHA for 26592cc

Commits on Jul 1, 2022

• PR review

  Show description for f4b95bb
  herou

  committed
  f4b95bb

  Copy full SHA for f4b95bb

Commits on Jul 20, 2022

• fix: format code solved & tests passed

  guillaumebogard

  committed
  d6fbf8c

  Copy full SHA for d6fbf8c

• clean: changed u32 type to BlockNumber for block references, additionally removing code complexity

  guillaumebogard

  committed
  c85bd7f

  Copy full SHA for c85bd7f

• fix: added ensure verification for 'number_of_installment' and for subscription & subscribed accounts

  guillaumebogard

  committed
  ab8f314

  Copy full SHA for ab8f314

• clean: removed unused macro_export

  guillaumebogard

  committed
  b55251d

  Copy full SHA for b55251d

• fix: removed feature(is_some_with) unstable macro preventing compilation

  guillaumebogard

  committed
  16630d4

  Copy full SHA for 16630d4

• fix: remove .idea/ from git files & added it to .gitignore

  guillaumebogard

  committed
  e3df0ed

  Copy full SHA for e3df0ed

• fix: renamed 'subscribe_call.rs' to 'subscribe.rs', grouped 'mock.rs' & 'subscribe.rs' in a tests module

  guillaumebogard

  committed
  dffbc1d

  Copy full SHA for dffbc1d

• clean: removed specifications for versions on branches

  guillaumebogard

  committed
  dc7bfe2

  Copy full SHA for dc7bfe2

Commits on Jul 26, 2022

• feat: unsubscribe

  guillaumebogard

  committed
  0c4ceb4

  Copy full SHA for 0c4ceb4

Commits on Aug 1, 2022

• enhance: changed Hashing algorithm from Blake2_256 to Twox64Concat for Plans & Subscription types

  guillaumebogard

  committed
  1e86c55

  Copy full SHA for 1e86c55

• changed: renamed SubscriptionCreated & UnsubscriptionCreated events

  guillaumebogard

  committed
  0c22e9b

  Copy full SHA for 0c22e9b

• changed: Unsubscription event now holds data on the old subscription

  guillaumebogard

  committed
  7c27c60

  Copy full SHA for 7c27c60

• fix: number_of_installment value check in subscribe()

  guillaumebogard

  committed
  60c8966

  Copy full SHA for 60c8966

• enhance: reduced code for next_block_number getter

  guillaumebogard

  committed
  7d3c5ce

  Copy full SHA for 7d3c5ce

• changed: rewrote subscriptions vector set value

  guillaumebogard

  committed
  ec92f11

  Copy full SHA for ec92f11

• enhance: wrapped entry values into variables in tests

  guillaumebogard

  committed
  a921b7e

  Copy full SHA for a921b7e

• tests: added subscribe test for number_of_installment with None value

  guillaumebogard

  committed
  fe60de6

  Copy full SHA for fe60de6

Commits on Aug 2, 2022

• changed: using index instead of iterating in subscription vector for unsubscribe()

  guillaumebogard

  committed
  c1ec3ca

  Copy full SHA for c1ec3ca

• tests: added basic unsubscribe test

  guillaumebogard

  committed
  80188f9

  Copy full SHA for 80188f9

• tests: added edge cases tests for unsubscribe()

  guillaumebogard

  committed
  c4a727b

  Copy full SHA for c4a727b

• changed: temporarily changed weight for subscribe() & unsubscribe() calls to 1000

  guillaumebogard

  committed
  3031c0c

  Copy full SHA for 3031c0c

• clean: tests

  guillaumebogard

  committed
  eade88f

  Copy full SHA for eade88f

Commits on Aug 3, 2022

• changed: using simple add instead of saturating_add() call to get the next block

  guillaumebogard

  committed
  ce48d8f

  Copy full SHA for ce48d8f

• changed: Subscription event now holds 'number_of_installment' data

  guillaumebogard

  committed
  0466ac7

  Copy full SHA for 0466ac7

• changed: now using 'origin' instead of 'subscriber' argument for unsubscribe()

  guillaumebogard

  committed
  1dfa3d6

  Copy full SHA for 1dfa3d6

• changed: more explicit unsubscribe errors

  guillaumebogard

  committed
  7b7001c

  Copy full SHA for 7b7001c

• changed: better error names for unsubscribe() edge cases

  guillaumebogard

  committed
  226cfbd

  Copy full SHA for 226cfbd

• changed: now using the 'subscription' variable found in StorageMap for the event trigger at the end of unsubscribe()

  guillaumebogard

  committed
  58795ce

  Copy full SHA for 58795ce

• clean: code format & clippy solved

  guillaumebogard

  committed
  79cacb7

  Copy full SHA for 79cacb7

• changed: removed 'subscriber' from unsubscribe() arguments

  guillaumebogard

  committed
  ed42201

  Copy full SHA for ed42201

• clean: removed dead code in tests

  guillaumebogard

  committed
  c5f74b8

  Copy full SHA for c5f74b8

• removed: SubscriptionAtIndexDoesNotMatch event as we do not compare 'subscription' in arguments anymore

  guillaumebogard

  committed
  a380c83

  Copy full SHA for a380c83