Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create/delete subscription #12

Merged
merged 41 commits into from
Aug 3, 2022
Merged

Create/delete subscription #12

merged 41 commits into from
Aug 3, 2022

Conversation

herou
Copy link
Contributor

@herou herou commented Jun 17, 2022

Issue #1
Drafted PR for now.

@herou herou requested review from gdnathan and tdelabro June 17, 2022 20:37
@herou herou marked this pull request as draft June 17, 2022 20:37
@herou herou requested a review from decentration June 23, 2022 06:04
tdelabro
tdelabro requested changes Jun 26, 2022
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/tests.rs Outdated Show resolved Hide resolved
src/tests.rs Outdated Show resolved Hide resolved
src/tests.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
tdelabro
tdelabro requested changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@tdelabro tdelabro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add .idea to .gitignore

herou added 4 commits June 28, 2022 01:33
@herou
PR review working progress
fcd5b4a
@herou
PR review
4c5ba4a 
Add unit tests
Saving work progress of PR review
@herou
PR review #3
26592cc 
Modify tests
@herou
PR review
f4b95bb 
Split the mock from the test
tdelabro
tdelabro requested changes Jul 3, 2022
View reviewed changes
Copy link
Contributor

@tdelabro tdelabro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no unsubscribe external. It's supposed to be part of this PR.

Group your mock.rs and subscribe_call.rs files under a tests module

.idea/.gitignore Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
@guillaumebogard guillaumebogard force-pushed the eljo_subscription_create_delete branch from 51dd2f3 to d6fbf8c Compare July 20, 2022 09:06
@guillaumebogard guillaumebogard force-pushed the eljo_subscription_create_delete branch from 28b349b to 0c4ceb4 Compare July 26, 2022 14:59
tdelabro
tdelabro requested changes Jul 31, 2022
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/tests/subscribe.rs Outdated Show resolved Hide resolved
@guillaumebogard guillaumebogard force-pushed the eljo_subscription_create_delete branch from 7a52638 to 4e6d052 Compare August 1, 2022 12:16
@guillaumebogard guillaumebogard force-pushed the eljo_subscription_create_delete branch from 4e6d052 to a921b7e Compare August 1, 2022 12:28
@gdnathan gdnathan removed their request for review August 1, 2022 12:30
@guillaumebogard guillaumebogard force-pushed the eljo_subscription_create_delete branch from d2151f8 to c1ec3ca Compare August 2, 2022 13:48
@guillaumebogard guillaumebogard force-pushed the eljo_subscription_create_delete branch from 2fa9abb to 3031c0c Compare August 2, 2022 15:14
tdelabro
tdelabro requested changes Aug 3, 2022
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
@guillaumebogard guillaumebogard marked this pull request as ready for review August 3, 2022 10:58
@tdelabro tdelabro merged commit 33d3d94 into master Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdelabro tdelabro tdelabro requested changes

@guillaumebogard guillaumebogard guillaumebogard left review comments

@decentration decentration Awaiting requested review from decentration

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@herou @tdelabro @guillaumebogard @gdnathan