Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create/delete subscription #12

Merged
merged 41 commits into from
Aug 3, 2022
+3,570 −0
Merged

Create/delete subscription #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
5c04026
first build ideas
gdnathan Jun 14, 2022
1f5ac65
updated with what we'll show
gdnathan Jun 14, 2022
e208fe8
save working progress
herou Jun 22, 2022
15468a6
Add subscribe extrinsic
herou Jun 22, 2022
da9f6b3
Add unit tests for subscribe extrinsic
herou Jun 24, 2022
fcd5b4a
PR review working progress
herou Jun 27, 2022
4c5ba4a
PR review
herou Jun 28, 2022
26592cc
PR review #3
herou Jun 29, 2022
f4b95bb
PR review
herou Jul 1, 2022
d6fbf8c
fix: format code solved & tests passed
guillaumebogard Jul 20, 2022
c85bd7f
clean: changed u32 type to BlockNumber for block references, addition…
guillaumebogard Jul 20, 2022
ab8f314
fix: added ensure verification for 'number_of_installment' and for su…
guillaumebogard Jul 20, 2022
b55251d
clean: removed unused macro_export
guillaumebogard Jul 20, 2022
16630d4
fix: removed feature(is_some_with) unstable macro preventing compilation
guillaumebogard Jul 20, 2022
e3df0ed
fix: remove .idea/ from git files & added it to .gitignore
guillaumebogard Jul 20, 2022
dffbc1d
fix: renamed 'subscribe_call.rs' to 'subscribe.rs', grouped 'mock.rs'…
guillaumebogard Jul 20, 2022
dc7bfe2
clean: removed specifications for versions on branches
guillaumebogard Jul 20, 2022
0c4ceb4
feat: unsubscribe
guillaumebogard Jul 26, 2022
1e86c55
enhance: changed Hashing algorithm from Blake2_256 to Twox64Concat fo…
guillaumebogard Aug 1, 2022
0c22e9b
changed: renamed SubscriptionCreated & UnsubscriptionCreated events
guillaumebogard Aug 1, 2022
7c27c60
changed: Unsubscription event now holds data on the old subscription
guillaumebogard Aug 1, 2022
60c8966
fix: number_of_installment value check in subscribe()
guillaumebogard Aug 1, 2022
7d3c5ce
enhance: reduced code for next_block_number getter
guillaumebogard Aug 1, 2022
ec92f11
changed: rewrote subscriptions vector set value
guillaumebogard Aug 1, 2022
a921b7e
enhance: wrapped entry values into variables in tests
guillaumebogard Aug 1, 2022
fe60de6
tests: added subscribe test for number_of_installment with None value
guillaumebogard Aug 1, 2022
c1ec3ca
changed: using index instead of iterating in subscription vector for …
guillaumebogard Aug 2, 2022
80188f9
tests: added basic unsubscribe test
guillaumebogard Aug 2, 2022
c4a727b
tests: added edge cases tests for unsubscribe()
guillaumebogard Aug 2, 2022
3031c0c
changed: temporarily changed weight for subscribe() & unsubscribe() c…
guillaumebogard Aug 2, 2022
eade88f
clean: tests
guillaumebogard Aug 2, 2022
ce48d8f
changed: using simple add instead of saturating_add() call to get the…
guillaumebogard Aug 3, 2022
0466ac7
changed: Subscription event now holds 'number_of_installment' data
guillaumebogard Aug 3, 2022
1dfa3d6
changed: now using 'origin' instead of 'subscriber' argument for unsu…
guillaumebogard Aug 3, 2022
7b7001c
changed: more explicit unsubscribe errors
guillaumebogard Aug 3, 2022
226cfbd
changed: better error names for unsubscribe() edge cases
guillaumebogard Aug 3, 2022
58795ce
changed: now using the 'subscription' variable found in StorageMap fo…
guillaumebogard Aug 3, 2022
79cacb7
clean: code format & clippy solved
guillaumebogard Aug 3, 2022
ed42201
changed: removed 'subscriber' from unsubscribe() arguments
guillaumebogard Aug 3, 2022
c5f74b8
clean: removed dead code in tests
guillaumebogard Aug 3, 2022
a380c83
removed: SubscriptionAtIndexDoesNotMatch event as we do not compare '…
guillaumebogard Aug 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
target/
.idea/
Loading