Add gopass plugin to krew plugin index #208
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,22 @@ | ||||||
| apiVersion: krew.googlecontainertools.github.com/v1alpha2 | ||||||
| kind: Plugin | ||||||
| metadata: | ||||||
| name: gopass | ||||||
| spec: | ||||||
| version: "v0.0.3" | ||||||
| platforms: | ||||||
| - selector: | ||||||
| matchExpressions: | ||||||
| - {key: os, operator: In, values: [darwin, linux]} | ||||||
|
There was a problem hiding this comment. The script is in pure bash. I think it would also make sense to allow installation on Windows and mention bash as a pre-requisite (which you already do). Note: for windows, the script should have a There was a problem hiding this comment. Actually, windows has bash support in newest windows 10 build. I've enabled it. Not sure about the ending though. I will probably revisit later on as gopass support for windows itself is an ongoing topic. There was a problem hiding this comment. I'm a bit puzzled now. The manifest has a windows section which also make the CI test fail. Was that intentional? If you want to add support for windows later, that's fine with me. I was not aware that There was a problem hiding this comment. No it shouldn't fail. I made another attempt to fix the build. |
||||||
| uri: https://github.com/gopasspw/kubectl-gopass/archive/v0.0.3.zip | ||||||
| sha256: "ae4d2aa8ec061aa6916b2120fa3caf48d1cee328bab7cd263a03f8b1aeec22f8" | ||||||
| files: | ||||||
| - from: "/kubectl-gopass-*/kubectl-gopass" | ||||||
| to: "." | ||||||
| bin: "./kubectl-gopass" | ||||||
| shortDescription: Imports secrets from gopass | ||||||
|
There was a problem hiding this comment.
Suggested change
Making it a capital
|
||||||
| homepage: https://github.com/gopasspw/kubectl-gopass | ||||||
| caveats: | | ||||||
| This plugin requires bash and gopass to be set up correctly | ||||||
|
|
||||||
| description: | | ||||||
|
There was a problem hiding this comment. Most plugins also give some basic usage instructions and how to get help. There was a problem hiding this comment. I think it's ok if --help/-h works. There was a problem hiding this comment. I can copy / paste the usage output here, but not sure what you will gain. I think the usage is quite obvious for gopass users right? |
||||||
| This plugin allows applying and diffing secrets from gopass to k8s | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a version mismatch between this manifest and what is reported by
kubectl gopass version(see https://github.com/gopasspw/kubectl-gopass/blob/59315e46389540624cca8c6ecb45694ed1dc3e87/kubectl-gopass#L140). Have you considered to generate deployment artifacts with a script?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, I added a small helper to create the tags and extracted the version as variable in the script.