Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up inactive members - Jan 2021 #2456

Closed
mrbobbytables opened this issue Jan 24, 2021 · 17 comments
Closed

Clean up inactive members - Jan 2021 #2456

mrbobbytables opened this issue Jan 24, 2021 · 17 comments
Labels
area/github-membership Requesting membership in a Kubernetes GitHub Organization or Team help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Milestone
v1.21

Comments

@mrbobbytables
Copy link
Member

mrbobbytables commented Jan 24, 2021 •
edited by nikhita
Loading

This is the list of inactive members that are slated to be removed from our Github Orgs. They have had no devstats recorded since July 1 2019.

Inactive Members:

Repos with inactive owners:

Kubernetes Org

Kubernetes SIGs Org

Kubernetes client Org
@mrbobbytables mrbobbytables added the area/github-membership Requesting membership in a Kubernetes GitHub Organization or Team label Jan 24, 2021
@mrbobbytables mrbobbytables mentioned this issue Jan 24, 2021
Merged
@dims
Copy link
Member

dims commented Jan 24, 2021

+1 from me!

@mrbobbytables
Copy link
Member Author

There is a limit on pings per post, this is the remainder that did not get pinged above:

@heckj
Copy link

heckj commented Jan 25, 2021

@mrbobbytables 👋 Ola - yes, unfortunately inactive when it comes to Kubernetes. Not sure what you need from me or what this entails, but I thought I'd confirm at least myself for you.

@mrbobbytables
Copy link
Member Author

mrbobbytables commented Jan 25, 2021 •
edited
Loading

No action needed, it was more an FYI ping 👍

@mrbobbytables
Copy link
Member Author

/help
For cleaning up the owners files.
For previous examples of what the clean up PRs look like please see the previous cleanups:
#2013
#2076

@k8s-ci-robot
Copy link
Contributor

@mrbobbytables:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help
For cleaning up the owners files.
For previous examples of what the clean up PRs look like please see the previous cleanups:
#2013
#2076

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jan 26, 2021
@marpaia
Copy link

marpaia commented Jan 26, 2021

Hey, I'm actually working my way back into the release team for 1.21. Can you please leave me in the org for now?

@mrbobbytables
Copy link
Member Author

mrbobbytables commented Jan 26, 2021 •
edited
Loading

EDIT: @marpaia I just checked and it doesn't look like you're on the RT for 1.21. 😬
ref: https://github.com/kubernetes/sig-release/blob/master/releases/release-1.21/release-team.md
Are you getting involved in some other way?

@YouthLab
Copy link

Hi~ @mrbobbytables I'm planning keep working for the DOC-SIG team this new year. Can you please leave me in the org for now, too?

@mrbobbytables
Copy link
Member Author

@YouthLab we prefer to move to remove and re-add when the person becomes active again. Things change rapidly in the project and 1.5years with no activity it's easy to lose track of things. I went ahead on adding @marpaia back because I thought they were a part of the release team and already involved (just not reflected on GitHub yet) - that is ON ME for saying yes before looking into it and have asked for more info.

The long term plan is to eventually automate this process (members being removed won't receive a ping). We updated our community membership guidelines outlining who is defined as inactive and how it is counted. For reference, we use devstats as our means to measure inactivity as it takes into account different types of GitHub actions, not just PRs or issues - but edits, comments and more. A general community notification about this policy was then sent to the k-dev mailing list.

We want to limit access to people that are consistently remain active. Org membership grants permissions to Kubernetes project repos and our CI system. If those privileges aren’t being actively used, we remove them to ensure we don’t have security issues down the road.

Not being a member doesn't mean you can't contribute. Many of our contributions come from non-org members. If you're ramping back up within the project, our org membership process has been streamlined. With a few PRs and two sponsors, we can add you back as a member.

@YouthLab
Copy link

@mrbobbytables That is ok. This is reasonable, better for the k8s org. And thank you for your reply with good intentions and patience.:)

@chenopis
Copy link

chenopis commented Jan 28, 2021 via email

@sladyn98
Copy link

@mrbobbytables I would like to give this issue a shot, I read the comment on slack by @nikhita about updating the owners files. If yes do let me know if I can begin ?

@mrbobbytables
Copy link
Member Author

@sladyn98 You can, just be sure to reference this post when creating PRs doing so. You can see some of the examples linked in #2013 and #2076.

I would also avoid opening PRs up in kubernetes/kubernetes to start as things are a bit more complicated with owners files there.

One other FYI - if the person being removed was an approver, they should be added as an emeritus_approver.

This was referenced Feb 10, 2021
Merged
Closed
Merged
@sladyn98
Copy link

I opened some PRs for some of the files, I will continue creating pull requests once I know what I am doing is right :)

This was referenced Feb 14, 2021
Merged
Closed
@mrbobbytables
Copy link
Member Author

@sladyn98 They look good :) It might just take a little bit for them to get reviewed. 👍

This was referenced Feb 14, 2021
Merged
Closed
Closed
Merged
Merged
@nikhita nikhita mentioned this issue Feb 16, 2021
Merged
@nikhita nikhita mentioned this issue Feb 16, 2021
Merged
This was referenced Feb 21, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Feb 28, 2021
Merged
Merged
Merged
Merged
Merged
@nikhita
Copy link
Member

nikhita commented Mar 7, 2021

All PRs to clean up OWNERS files have merged. Closing!

@nikhita nikhita closed this as completed Mar 7, 2021
@spiffxp spiffxp added this to the v1.21 milestone Mar 10, 2021
@SergeyKanzhelev SergeyKanzhelev mentioned this issue Sep 17, 2021
Closed
@palnabarun palnabarun mentioned this issue Nov 12, 2021
Closed
4 tasks
@palnabarun palnabarun mentioned this issue Jan 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/github-membership Requesting membership in a Kubernetes GitHub Organization or Team help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
v1.21
Development

No branches or pull requests
10 participants
@dims @heckj @spiffxp @marpaia @YouthLab @mrbobbytables @nikhita @k8s-ci-robot @chenopis @sladyn98