Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate scheduling/kube-scheduler.md in Korean #19879

Merged
merged 1 commit into from
Apr 8, 2020
Merged

Translate scheduling/kube-scheduler.md in Korean #19879

merged 1 commit into from
Apr 8, 2020

Conversation

pjhwa
Copy link
Contributor

@pjhwa pjhwa commented Mar 27, 2020

from #19873

이전 작업과 겹치는 바람에 다시 PR 올립니다.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 27, 2020
@k8s-ci-robot k8s-ci-robot requested review from ianychoi and ysyukr March 27, 2020 06:33
@k8s-ci-robot k8s-ci-robot added language/ko Issues or PRs related to Korean language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Mar 27, 2020
@netlify
Copy link

netlify bot commented Mar 27, 2020 •
edited
Loading

Deploy preview for k8s-dev-ko ready!

Built with commit 077ca25

https://deploy-preview-19879--k8s-dev-ko.netlify.com

@jmyung
Copy link
Member

jmyung commented Mar 28, 2020

/assign @jmyung

jmyung
jmyung reviewed Mar 30, 2020
View reviewed changes
Copy link
Member

@jmyung jmyung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pjhwa

수고많으셨습니다. 👍
몇 가지 의견을 적어봤습니다.

content/ko/docs/concepts/scheduling/kube-scheduler.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/scheduling/kube-scheduler.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/scheduling/kube-scheduler.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/scheduling/kube-scheduler.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/scheduling/kube-scheduler.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/scheduling/kube-scheduler.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/scheduling/kube-scheduler.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/scheduling/kube-scheduler.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/scheduling/kube-scheduler.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/scheduling/kube-scheduler.md Outdated Show resolved Hide resolved
pjhwa
pjhwa commented Mar 30, 2020
View reviewed changes
Copy link
Contributor Author

@pjhwa pjhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmyung 리뷰 감사합니다!
이런 작업을 하면 늘 느끼는 거지만, 내가 한글 사용에 참 약하구나 하는 생각을 많이 하게 됩니다. :-)
제안하신 내용 중 kube-scheduler의 레벨을 제외하고 나머지는 다 적용하였습니다.

@jmyung
Copy link
Member

jmyung commented Mar 30, 2020

@pjhwa 수고하셨습니다.
리뷰건에 대한 commit들은 한 개의 commit으로 squash 해주시면 감사하겠습니다.

@pjhwa
Copy link
Contributor Author

pjhwa commented Mar 30, 2020

@jmyung 말씀하신대로 하나로 squash 했습니다. 제대로 된건지 모르겠네요. 감사합니다.

@jmyung
Copy link
Member

jmyung commented Mar 30, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 30, 2020
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 6, 2020
@pjhwa
Copy link
Contributor Author

pjhwa commented Apr 8, 2020

@jmyung 커밋들을 squash 해버렸더니 주신 lgtm label이 떨어져나갔네요. ^^;

@jmyung
Copy link
Member

jmyung commented Apr 8, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2020
@seokho-son
Copy link
Member

감사합니다 !
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seokho-son

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2020
@k8s-ci-robot k8s-ci-robot merged commit 4b9e096 into kubernetes:dev-1.18-ko.1 Apr 8, 2020
gochist added a commit that referenced this pull request Apr 9, 2020
@ysyukr @pjhwa
@bluefriday @seokho-son @coolguyhong @santachopa @jmyung @gochist
First Korean l10n Work For Release 1.18
cc88a78 
* Update to Outdated files in the dev-1.18-ko.1 branch (#19886)
* Translate reference/glossary/service-catalog.md in Korean (#20055)
* Translate storage/dynamic-provisioning.md in Korean (#19952)
* Translate extend-kubernetes/extend-cluster.md in Korean (#20031)
* Translate storage/persistent-volumes.md in Korean (#19906)
* Translate partners/_index.html in Korean (#19967)
* Translate extend-kubernetes/operator.md in Korean (#20037)
* Translate assign-pods-nodes to Korean (#20035)
* Translate scheduling/kube-scheduler.md in Korean (#19879)
* Translate concepts/containers/overview in Korean (#19885)
* Translate policy/pod-security-policy.md in Korean (#19922)
* Translate policy/limit-range.md in Korean (#19912)
* Translate policy/resource-quotas.md in Korean (#19931)
* Translate extend-kubernetes/api-extension/custom-resources.md in Korean (#20093)
* Translate reference/glossary/managed-service.md in Korean (#20150)

Co-authored-by: Jerry Park <[email protected]>
Co-authored-by: heechang lee <[email protected]>
Co-authored-by: Yuk, Yongsu <[email protected]>
Co-authored-by: Seokho Son <[email protected]>
Co-authored-by: coolguyhong <[email protected]>
Co-authored-by: santachopa <[email protected]>
Co-authored-by: Jesang Myung <[email protected]>
Co-authored-by: June Yi <[email protected]>
@gochist gochist mentioned this pull request Apr 9, 2020
Merged
gochist added a commit that referenced this pull request Apr 9, 2020
@ysyukr @pjhwa
@bluefriday @seokho-son @coolguyhong @santachopa @jmyung @gochist
First Korean l10n Work For Release 1.18
264869a 
* Update to Outdated files in the dev-1.18-ko.1 branch (#19886)
* Translate reference/glossary/service-catalog.md in Korean (#20055)
* Translate storage/dynamic-provisioning.md in Korean (#19952)
* Translate extend-kubernetes/extend-cluster.md in Korean (#20031)
* Translate storage/persistent-volumes.md in Korean (#19906)
* Translate partners/_index.html in Korean (#19967)
* Translate extend-kubernetes/operator.md in Korean (#20037)
* Translate assign-pods-nodes to Korean (#20035)
* Translate scheduling/kube-scheduler.md in Korean (#19879)
* Translate concepts/containers/overview in Korean (#19885)
* Translate policy/pod-security-policy.md in Korean (#19922)
* Translate policy/limit-range.md in Korean (#19912)
* Translate policy/resource-quotas.md in Korean (#19931)
* Translate extend-kubernetes/api-extension/custom-resources.md in Korean (#20093)
* Translate reference/glossary/managed-service.md in Korean (#20150)

Co-authored-by: Jerry Park <[email protected]>
Co-authored-by: heechang lee <[email protected]>
Co-authored-by: Yuk, Yongsu <[email protected]>
Co-authored-by: Seokho Son <[email protected]>
Co-authored-by: coolguyhong <[email protected]>
Co-authored-by: santachopa <[email protected]>
Co-authored-by: Jesang Myung <[email protected]>
Co-authored-by: June Yi <[email protected]>
jmyung added a commit to jmyung/website that referenced this pull request Apr 15, 2020
@ysyukr @pjhwa
@bluefriday @seokho-son @coolguyhong @santachopa @jmyung @gochist
First Korean l10n Work For Release 1.18
a503ea0 
* Update to Outdated files in the dev-1.18-ko.1 branch (kubernetes#19886)
* Translate reference/glossary/service-catalog.md in Korean (kubernetes#20055)
* Translate storage/dynamic-provisioning.md in Korean (kubernetes#19952)
* Translate extend-kubernetes/extend-cluster.md in Korean (kubernetes#20031)
* Translate storage/persistent-volumes.md in Korean (kubernetes#19906)
* Translate partners/_index.html in Korean (kubernetes#19967)
* Translate extend-kubernetes/operator.md in Korean (kubernetes#20037)
* Translate assign-pods-nodes to Korean (kubernetes#20035)
* Translate scheduling/kube-scheduler.md in Korean (kubernetes#19879)
* Translate concepts/containers/overview in Korean (kubernetes#19885)
* Translate policy/pod-security-policy.md in Korean (kubernetes#19922)
* Translate policy/limit-range.md in Korean (kubernetes#19912)
* Translate policy/resource-quotas.md in Korean (kubernetes#19931)
* Translate extend-kubernetes/api-extension/custom-resources.md in Korean (kubernetes#20093)
* Translate reference/glossary/managed-service.md in Korean (kubernetes#20150)

Co-authored-by: Jerry Park <[email protected]>
Co-authored-by: heechang lee <[email protected]>
Co-authored-by: Yuk, Yongsu <[email protected]>
Co-authored-by: Seokho Son <[email protected]>
Co-authored-by: coolguyhong <[email protected]>
Co-authored-by: santachopa <[email protected]>
Co-authored-by: Jesang Myung <[email protected]>
Co-authored-by: June Yi <[email protected]>
fancc pushed a commit to fancc/website that referenced this pull request Apr 26, 2020
@ysyukr @pjhwa
@bluefriday @seokho-son @coolguyhong @santachopa @jmyung @gochist @fancc
First Korean l10n Work For Release 1.18
583c90a 
* Update to Outdated files in the dev-1.18-ko.1 branch (kubernetes#19886)
* Translate reference/glossary/service-catalog.md in Korean (kubernetes#20055)
* Translate storage/dynamic-provisioning.md in Korean (kubernetes#19952)
* Translate extend-kubernetes/extend-cluster.md in Korean (kubernetes#20031)
* Translate storage/persistent-volumes.md in Korean (kubernetes#19906)
* Translate partners/_index.html in Korean (kubernetes#19967)
* Translate extend-kubernetes/operator.md in Korean (kubernetes#20037)
* Translate assign-pods-nodes to Korean (kubernetes#20035)
* Translate scheduling/kube-scheduler.md in Korean (kubernetes#19879)
* Translate concepts/containers/overview in Korean (kubernetes#19885)
* Translate policy/pod-security-policy.md in Korean (kubernetes#19922)
* Translate policy/limit-range.md in Korean (kubernetes#19912)
* Translate policy/resource-quotas.md in Korean (kubernetes#19931)
* Translate extend-kubernetes/api-extension/custom-resources.md in Korean (kubernetes#20093)
* Translate reference/glossary/managed-service.md in Korean (kubernetes#20150)

Co-authored-by: Jerry Park <[email protected]>
Co-authored-by: heechang lee <[email protected]>
Co-authored-by: Yuk, Yongsu <[email protected]>
Co-authored-by: Seokho Son <[email protected]>
Co-authored-by: coolguyhong <[email protected]>
Co-authored-by: santachopa <[email protected]>
Co-authored-by: Jesang Myung <[email protected]>
Co-authored-by: June Yi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmyung jmyung jmyung left review comments

@ianychoi ianychoi Awaiting requested review from ianychoi

@ysyukr ysyukr Awaiting requested review from ysyukr

Assignees

@jmyung jmyung

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pjhwa @jmyung @seokho-son @k8s-ci-robot