Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate extend-kubernetes/operator.md in Korean #20037

Merged
merged 1 commit into from
Apr 7, 2020
Merged

Translate extend-kubernetes/operator.md in Korean #20037

merged 1 commit into from
Apr 7, 2020

Conversation

pjhwa
Copy link
Contributor

@pjhwa pjhwa commented Apr 1, 2020

from #20036

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 1, 2020
@k8s-ci-robot k8s-ci-robot requested review from gochist and ysyukr April 1, 2020 10:55
@k8s-ci-robot k8s-ci-robot added language/ko Issues or PRs related to Korean language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 1, 2020
@netlify
Copy link

netlify bot commented Apr 1, 2020 •
edited
Loading

Deploy preview for k8s-dev-ko ready!

Built with commit ac6cf6d

https://deploy-preview-20037--k8s-dev-ko.netlify.com

@k8s-ci-robot
Copy link
Contributor

@pjhwa: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pjhwa
Copy link
Contributor Author

pjhwa commented Apr 1, 2020

Preview: https://deploy-preview-20037--k8s-dev-ko.netlify.com/ko/docs/concepts/extend-kubernetes/operator/

sftim
sftim reviewed Apr 1, 2020
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pjhwa

This looks great (I speak very little Korean, so I can't review the main text).

Here's some informal feedback with a few suggested tweaks.

content/ko/docs/concepts/extend-kubernetes/operator.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/extend-kubernetes/operator.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/extend-kubernetes/operator.md Outdated Show resolved Hide resolved
@pjhwa
Copy link
Contributor Author

pjhwa commented Apr 1, 2020

@sftim Thank you for your review. Please review again for my opinion. I will reflect them after your review. :-)

@claudiajkang
Copy link
Contributor

/assign @seokho-son

seokho-son
seokho-son reviewed Apr 3, 2020
View reviewed changes
Copy link
Member

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pjhwa 컨트리뷰션 감사합니다 :)
리뷰 완료하였습니다. 의견 참고하셔서 PR 업데이트 부탁 드립니다.

content/ko/docs/concepts/extend-kubernetes/operator.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/extend-kubernetes/operator.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/extend-kubernetes/operator.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/extend-kubernetes/operator.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/extend-kubernetes/operator.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/extend-kubernetes/operator.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/extend-kubernetes/operator.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/extend-kubernetes/operator.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/extend-kubernetes/operator.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/extend-kubernetes/operator.md Outdated Show resolved Hide resolved
@pjhwa
Copy link
Contributor Author

pjhwa commented Apr 3, 2020

@seokho-son 리뷰 감사합니다!
리뷰 내용 중에 의견을 드렸습니다. 검토 부탁드립니다.

@pjhwa pjhwa mentioned this pull request Apr 3, 2020
Merged
2 tasks
@seokho-son
Copy link
Member

@pjhwa Thank you ~ !
This PR looks nice to me !

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seokho-son

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2020
@k8s-ci-robot k8s-ci-robot merged commit d8b5c72 into kubernetes:dev-1.18-ko.1 Apr 7, 2020
gochist added a commit that referenced this pull request Apr 9, 2020
@ysyukr @pjhwa
@bluefriday @seokho-son @coolguyhong @santachopa @jmyung @gochist
First Korean l10n Work For Release 1.18
cc88a78 
* Update to Outdated files in the dev-1.18-ko.1 branch (#19886)
* Translate reference/glossary/service-catalog.md in Korean (#20055)
* Translate storage/dynamic-provisioning.md in Korean (#19952)
* Translate extend-kubernetes/extend-cluster.md in Korean (#20031)
* Translate storage/persistent-volumes.md in Korean (#19906)
* Translate partners/_index.html in Korean (#19967)
* Translate extend-kubernetes/operator.md in Korean (#20037)
* Translate assign-pods-nodes to Korean (#20035)
* Translate scheduling/kube-scheduler.md in Korean (#19879)
* Translate concepts/containers/overview in Korean (#19885)
* Translate policy/pod-security-policy.md in Korean (#19922)
* Translate policy/limit-range.md in Korean (#19912)
* Translate policy/resource-quotas.md in Korean (#19931)
* Translate extend-kubernetes/api-extension/custom-resources.md in Korean (#20093)
* Translate reference/glossary/managed-service.md in Korean (#20150)

Co-authored-by: Jerry Park <[email protected]>
Co-authored-by: heechang lee <[email protected]>
Co-authored-by: Yuk, Yongsu <[email protected]>
Co-authored-by: Seokho Son <[email protected]>
Co-authored-by: coolguyhong <[email protected]>
Co-authored-by: santachopa <[email protected]>
Co-authored-by: Jesang Myung <[email protected]>
Co-authored-by: June Yi <[email protected]>
@gochist gochist mentioned this pull request Apr 9, 2020
Merged
gochist added a commit that referenced this pull request Apr 9, 2020
@ysyukr @pjhwa
@bluefriday @seokho-son @coolguyhong @santachopa @jmyung @gochist
First Korean l10n Work For Release 1.18
264869a 
* Update to Outdated files in the dev-1.18-ko.1 branch (#19886)
* Translate reference/glossary/service-catalog.md in Korean (#20055)
* Translate storage/dynamic-provisioning.md in Korean (#19952)
* Translate extend-kubernetes/extend-cluster.md in Korean (#20031)
* Translate storage/persistent-volumes.md in Korean (#19906)
* Translate partners/_index.html in Korean (#19967)
* Translate extend-kubernetes/operator.md in Korean (#20037)
* Translate assign-pods-nodes to Korean (#20035)
* Translate scheduling/kube-scheduler.md in Korean (#19879)
* Translate concepts/containers/overview in Korean (#19885)
* Translate policy/pod-security-policy.md in Korean (#19922)
* Translate policy/limit-range.md in Korean (#19912)
* Translate policy/resource-quotas.md in Korean (#19931)
* Translate extend-kubernetes/api-extension/custom-resources.md in Korean (#20093)
* Translate reference/glossary/managed-service.md in Korean (#20150)

Co-authored-by: Jerry Park <[email protected]>
Co-authored-by: heechang lee <[email protected]>
Co-authored-by: Yuk, Yongsu <[email protected]>
Co-authored-by: Seokho Son <[email protected]>
Co-authored-by: coolguyhong <[email protected]>
Co-authored-by: santachopa <[email protected]>
Co-authored-by: Jesang Myung <[email protected]>
Co-authored-by: June Yi <[email protected]>
jmyung added a commit to jmyung/website that referenced this pull request Apr 15, 2020
@ysyukr @pjhwa
@bluefriday @seokho-son @coolguyhong @santachopa @jmyung @gochist
First Korean l10n Work For Release 1.18
a503ea0 
* Update to Outdated files in the dev-1.18-ko.1 branch (kubernetes#19886)
* Translate reference/glossary/service-catalog.md in Korean (kubernetes#20055)
* Translate storage/dynamic-provisioning.md in Korean (kubernetes#19952)
* Translate extend-kubernetes/extend-cluster.md in Korean (kubernetes#20031)
* Translate storage/persistent-volumes.md in Korean (kubernetes#19906)
* Translate partners/_index.html in Korean (kubernetes#19967)
* Translate extend-kubernetes/operator.md in Korean (kubernetes#20037)
* Translate assign-pods-nodes to Korean (kubernetes#20035)
* Translate scheduling/kube-scheduler.md in Korean (kubernetes#19879)
* Translate concepts/containers/overview in Korean (kubernetes#19885)
* Translate policy/pod-security-policy.md in Korean (kubernetes#19922)
* Translate policy/limit-range.md in Korean (kubernetes#19912)
* Translate policy/resource-quotas.md in Korean (kubernetes#19931)
* Translate extend-kubernetes/api-extension/custom-resources.md in Korean (kubernetes#20093)
* Translate reference/glossary/managed-service.md in Korean (kubernetes#20150)

Co-authored-by: Jerry Park <[email protected]>
Co-authored-by: heechang lee <[email protected]>
Co-authored-by: Yuk, Yongsu <[email protected]>
Co-authored-by: Seokho Son <[email protected]>
Co-authored-by: coolguyhong <[email protected]>
Co-authored-by: santachopa <[email protected]>
Co-authored-by: Jesang Myung <[email protected]>
Co-authored-by: June Yi <[email protected]>
fancc pushed a commit to fancc/website that referenced this pull request Apr 26, 2020
@ysyukr @pjhwa
@bluefriday @seokho-son @coolguyhong @santachopa @jmyung @gochist @fancc
First Korean l10n Work For Release 1.18
583c90a 
* Update to Outdated files in the dev-1.18-ko.1 branch (kubernetes#19886)
* Translate reference/glossary/service-catalog.md in Korean (kubernetes#20055)
* Translate storage/dynamic-provisioning.md in Korean (kubernetes#19952)
* Translate extend-kubernetes/extend-cluster.md in Korean (kubernetes#20031)
* Translate storage/persistent-volumes.md in Korean (kubernetes#19906)
* Translate partners/_index.html in Korean (kubernetes#19967)
* Translate extend-kubernetes/operator.md in Korean (kubernetes#20037)
* Translate assign-pods-nodes to Korean (kubernetes#20035)
* Translate scheduling/kube-scheduler.md in Korean (kubernetes#19879)
* Translate concepts/containers/overview in Korean (kubernetes#19885)
* Translate policy/pod-security-policy.md in Korean (kubernetes#19922)
* Translate policy/limit-range.md in Korean (kubernetes#19912)
* Translate policy/resource-quotas.md in Korean (kubernetes#19931)
* Translate extend-kubernetes/api-extension/custom-resources.md in Korean (kubernetes#20093)
* Translate reference/glossary/managed-service.md in Korean (kubernetes#20150)

Co-authored-by: Jerry Park <[email protected]>
Co-authored-by: heechang lee <[email protected]>
Co-authored-by: Yuk, Yongsu <[email protected]>
Co-authored-by: Seokho Son <[email protected]>
Co-authored-by: coolguyhong <[email protected]>
Co-authored-by: santachopa <[email protected]>
Co-authored-by: Jesang Myung <[email protected]>
Co-authored-by: June Yi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@seokho-son seokho-son seokho-son left review comments

@gochist gochist Awaiting requested review from gochist

@ysyukr ysyukr Awaiting requested review from ysyukr

Assignees

@seokho-son seokho-son

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pjhwa @k8s-ci-robot @claudiajkang @seokho-son @gochist @sftim