-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate policy/pod-security-policy.md in Korean #19922
Conversation
Deploy preview for k8s-dev-ko ready! Built with commit 665e4a4 |
/hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
line 0 ~ 334
/assign @claudiajkang -
line 335 ~ 618
/assign @seokho-son
리뷰가 완료되면 커밋들을 squash 하도록 하겠습니다. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pjhwa 리뷰 완료했습니다. 리뷰내용 확인 부탁드립니다. 리뷰가 늦어진 점 사과드립니다.
@claudiajkang 꼼꼼한 리뷰 감사합니다. |
@pjhwa 334라인까지 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pjhwa 장문의 문서 한글화에 감사드립니다.
리뷰를 완료하였습니다. 참고하셔서 PR 업데이트 부탁드립니다.
(문서 전반적으로 원문과 라인이 달라져 있습니다. 제가 일부 정정 요청을 드렸지만, 전체적으로 검토가 필요해 보입니다.)
## 파드 보안 정책이란? | ||
|
||
_Pod Security Policy_ 는 파드 명세의 보안 관련 측면을 제어하는 클러스터-레벨의 | ||
리소스이다. [PodSecurityPolicy](/docs/reference/generated/kubernetes-api/{{< param "version" >}}/#podsecuritypolicy-v1beta1-policy) 오브젝트는 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
한글화팀 회의 및 api-오브젝트-용어-한글화-관련-방침에 따르면
PodSecurityPolicy 도 한글화해야 하지 않을까요? (@claudiajkang @gochist @pjhwa )
PodSecurityPolicy 는 쿠버네티스 API 오브젝트로 보이고, 한글화 용어집에 등록된 바 없습니다.
다만, 문서 내에 PodSecurityPolicy가 코드(PodSecurityPolicy
)로 사용된 경우도 있고 평문으로 사용된 경우도 있다는 것을 알고 있습니다. 코드에 대해서도 수정해야 하는지에 대한 기준이 분명하지는 않은 것 같습니다.
보통 코드(PodSecurityPolicy
)로 작성된 내용은 한글화하지 않는 경향이 있습니다만 (코드는 일반적으로 커맨드에 붙여 넣기해서 사용하는 등의 상황을 고려) 항상 그에 따르지는 않습니다. 컨트리뷰터 및 리뷰어의 판단이 필요한 부분 입니다. (@pjhwa 혹시라도 좋은 의견 있으시면 개진해 주세요 ~ ! )
변경이 필요한 경우, 문서 전체적으로 반영이 필요합니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
안그래도 고민을 많이 했습니다. (한글화 용어집에 없는 용어들이 많다보니, 번역할 때 많은 고민에 빠지게 되더라고요. ^^)
다른 API 오브젝트들과 마찬가지로 "파드시큐리티폴리시"로 번역하고, 코드 PodSecurityPolicy
로 사용된 경우에는 원문 그대로 표기하는 것이 좋을 것 같습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
그러면... Pod Security Policy, PodSecurityPolicy 는 같은 용어로 한글화해야하겠지요?
이 경우에는 제목이 "파드 보안 정책"에서 "파드 시큐리티 폴리시"로 변경되어야겠네요.
@seokho-son 꼼꼼한 리뷰 감사합니다! |
|
@seokho-son 의견 반영해서 수정하겠습니다. 감사합니다! |
@pjhwa 신속하고 꼼꼼한 대응 감사합니다 !! 컨텐츠에 대해서는 lgtm 및 approve 입니다 ! /lgtm @claudiajkang PR간 의존성 해결이 안되었으므로, 일단 hold는 유지하도록 하겠습니다. |
@seokho-son policy/_index.md 파일에 관련있는 PR이 #19911 #19921 #19930 입니다. limit-range.md 파일의 원문이 변경되는 바람에 다 엮여버렸는데요, 말씀하신대로 여기에 _index.md 파일을 추가하면 #19930 까지 hold를 풀수있을 것 같습니다. 나중에 limit-range.md PR은 rebase하고 수정하도록 하겠습니다. @claudiajkang |
@seokho-son @claudiajkang policy/_index.md 파일을 추가하였습니다. 감사합니다. |
/lgtm |
/hold cancel |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: seokho-son The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Update to Outdated files in the dev-1.18-ko.1 branch (#19886) * Translate reference/glossary/service-catalog.md in Korean (#20055) * Translate storage/dynamic-provisioning.md in Korean (#19952) * Translate extend-kubernetes/extend-cluster.md in Korean (#20031) * Translate storage/persistent-volumes.md in Korean (#19906) * Translate partners/_index.html in Korean (#19967) * Translate extend-kubernetes/operator.md in Korean (#20037) * Translate assign-pods-nodes to Korean (#20035) * Translate scheduling/kube-scheduler.md in Korean (#19879) * Translate concepts/containers/overview in Korean (#19885) * Translate policy/pod-security-policy.md in Korean (#19922) * Translate policy/limit-range.md in Korean (#19912) * Translate policy/resource-quotas.md in Korean (#19931) * Translate extend-kubernetes/api-extension/custom-resources.md in Korean (#20093) * Translate reference/glossary/managed-service.md in Korean (#20150) Co-authored-by: Jerry Park <[email protected]> Co-authored-by: heechang lee <[email protected]> Co-authored-by: Yuk, Yongsu <[email protected]> Co-authored-by: Seokho Son <[email protected]> Co-authored-by: coolguyhong <[email protected]> Co-authored-by: santachopa <[email protected]> Co-authored-by: Jesang Myung <[email protected]> Co-authored-by: June Yi <[email protected]>
* Update to Outdated files in the dev-1.18-ko.1 branch (#19886) * Translate reference/glossary/service-catalog.md in Korean (#20055) * Translate storage/dynamic-provisioning.md in Korean (#19952) * Translate extend-kubernetes/extend-cluster.md in Korean (#20031) * Translate storage/persistent-volumes.md in Korean (#19906) * Translate partners/_index.html in Korean (#19967) * Translate extend-kubernetes/operator.md in Korean (#20037) * Translate assign-pods-nodes to Korean (#20035) * Translate scheduling/kube-scheduler.md in Korean (#19879) * Translate concepts/containers/overview in Korean (#19885) * Translate policy/pod-security-policy.md in Korean (#19922) * Translate policy/limit-range.md in Korean (#19912) * Translate policy/resource-quotas.md in Korean (#19931) * Translate extend-kubernetes/api-extension/custom-resources.md in Korean (#20093) * Translate reference/glossary/managed-service.md in Korean (#20150) Co-authored-by: Jerry Park <[email protected]> Co-authored-by: heechang lee <[email protected]> Co-authored-by: Yuk, Yongsu <[email protected]> Co-authored-by: Seokho Son <[email protected]> Co-authored-by: coolguyhong <[email protected]> Co-authored-by: santachopa <[email protected]> Co-authored-by: Jesang Myung <[email protected]> Co-authored-by: June Yi <[email protected]>
* Update to Outdated files in the dev-1.18-ko.1 branch (kubernetes#19886) * Translate reference/glossary/service-catalog.md in Korean (kubernetes#20055) * Translate storage/dynamic-provisioning.md in Korean (kubernetes#19952) * Translate extend-kubernetes/extend-cluster.md in Korean (kubernetes#20031) * Translate storage/persistent-volumes.md in Korean (kubernetes#19906) * Translate partners/_index.html in Korean (kubernetes#19967) * Translate extend-kubernetes/operator.md in Korean (kubernetes#20037) * Translate assign-pods-nodes to Korean (kubernetes#20035) * Translate scheduling/kube-scheduler.md in Korean (kubernetes#19879) * Translate concepts/containers/overview in Korean (kubernetes#19885) * Translate policy/pod-security-policy.md in Korean (kubernetes#19922) * Translate policy/limit-range.md in Korean (kubernetes#19912) * Translate policy/resource-quotas.md in Korean (kubernetes#19931) * Translate extend-kubernetes/api-extension/custom-resources.md in Korean (kubernetes#20093) * Translate reference/glossary/managed-service.md in Korean (kubernetes#20150) Co-authored-by: Jerry Park <[email protected]> Co-authored-by: heechang lee <[email protected]> Co-authored-by: Yuk, Yongsu <[email protected]> Co-authored-by: Seokho Son <[email protected]> Co-authored-by: coolguyhong <[email protected]> Co-authored-by: santachopa <[email protected]> Co-authored-by: Jesang Myung <[email protected]> Co-authored-by: June Yi <[email protected]>
* Update to Outdated files in the dev-1.18-ko.1 branch (kubernetes#19886) * Translate reference/glossary/service-catalog.md in Korean (kubernetes#20055) * Translate storage/dynamic-provisioning.md in Korean (kubernetes#19952) * Translate extend-kubernetes/extend-cluster.md in Korean (kubernetes#20031) * Translate storage/persistent-volumes.md in Korean (kubernetes#19906) * Translate partners/_index.html in Korean (kubernetes#19967) * Translate extend-kubernetes/operator.md in Korean (kubernetes#20037) * Translate assign-pods-nodes to Korean (kubernetes#20035) * Translate scheduling/kube-scheduler.md in Korean (kubernetes#19879) * Translate concepts/containers/overview in Korean (kubernetes#19885) * Translate policy/pod-security-policy.md in Korean (kubernetes#19922) * Translate policy/limit-range.md in Korean (kubernetes#19912) * Translate policy/resource-quotas.md in Korean (kubernetes#19931) * Translate extend-kubernetes/api-extension/custom-resources.md in Korean (kubernetes#20093) * Translate reference/glossary/managed-service.md in Korean (kubernetes#20150) Co-authored-by: Jerry Park <[email protected]> Co-authored-by: heechang lee <[email protected]> Co-authored-by: Yuk, Yongsu <[email protected]> Co-authored-by: Seokho Son <[email protected]> Co-authored-by: coolguyhong <[email protected]> Co-authored-by: santachopa <[email protected]> Co-authored-by: Jesang Myung <[email protected]> Co-authored-by: June Yi <[email protected]>
from #19921
Translated the following file:
Copied the following files from en/examples/policy directory for pod-security-policy.md:
I didn't added policy/_index.md file because I've already added it from #19912