Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix BZ 1856447 #700

Merged
merged 2 commits into from
Jul 14, 2020
Merged

Fix BZ 1856447 #700

merged 2 commits into from
Jul 14, 2020

Conversation

nunnatsa
Copy link
Collaborator

@nunnatsa nunnatsa commented Jul 13, 2020 •
edited
Loading

Fix error that if all the components are running, but not all of them are with the latest version, HCO reports "ready" but it should not.

This fix make sure that HCO only set ready for successful upgrade, when all the operators are with the right version

Signed-off-by: Nahshon Unna-Tsameret [email protected]

Release note:

Fix bug 1856447

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 13, 2020
@ovirt-infra
Copy link

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow Manage kubevirt CR from sdk generated code #3 option )
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

@nunnatsa
Fix BZ 1856447
4e20aff 
    Fix error that if all the components are running, but not all of them are with the latest version, HCO reports "ready" but it should not.

    This fix make sure that HCO only set ready for successful upgrade, when all the operators are with the right version

Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
@nunnatsa nunnatsa requested review from tiraboschi and orenc1 and removed request for rthallisey July 13, 2020 18:12
@nunnatsa
Copy link
Collaborator Author

travis failed. Close and re-open to re-run it

@nunnatsa nunnatsa closed this Jul 13, 2020
@nunnatsa nunnatsa reopened this Jul 13, 2020
@nunnatsa nunnatsa closed this Jul 13, 2020
@nunnatsa nunnatsa reopened this Jul 13, 2020
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 13, 2020
@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2020
@tiraboschi
Copy link
Member

The issue reported by travis is

ERROR: CSV.spec.crd.owned.version isnot in CRD.spec.versions list [1.2.0/kubevirt-hyperconverged-operator.v1.2.0.clusterserviceversion.yaml]

which is probably:
operator-framework/operator-courier#188
so maybe a regression on the operator-courier

@tiraboschi
Copy link
Member

tiraboschi commented Jul 13, 2020 •
edited
Loading

operator-framework/operator-courier#189 should fix it

in the meanwhile we can pin travis to operator-courier 2.1.7 which is not affected (pip3 install --upgrade operator-courier==2.1.7)

@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2020
@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2020
@tiraboschi
Copy link
Member

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2020
@kubevirt-bot kubevirt-bot merged commit 233dc61 into kubevirt:master Jul 14, 2020
@nunnatsa nunnatsa deleted the fix-1856447 branch July 14, 2020 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orenc1 orenc1 orenc1 approved these changes

@tiraboschi tiraboschi tiraboschi approved these changes

@yuvalturg yuvalturg Awaiting requested review from yuvalturg

Assignees

@tiraboschi tiraboschi

@orenc1 orenc1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nunnatsa @ovirt-infra @tiraboschi @kubevirt-bot @orenc1