Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly validate crd.spec.versions #189

Merged
merged 1 commit into from
Jul 20, 2020
Merged

Correctly validate crd.spec.versions #189

merged 1 commit into from
Jul 20, 2020

Conversation

tiraboschi
Copy link
Contributor

@tiraboschi tiraboschi commented Jul 13, 2020 •
edited
Loading

Correctly validate crd.spec.versions

crd.spec.version got deprecated for crd.spec.versions
but in this case we are going to access a list of
dictionaries where the relevant value
is in the name field.

Fix all the validations on spec.versions and add
additional validations.

Fix also its test.

Signed-off-by: Simone Tiraboschi [email protected]

Fixes: #188

@openshift-ci-robot
Copy link

Hi @tiraboschi. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 13, 2020
@tiraboschi
Copy link
Contributor Author

/ok-to-test

@openshift-ci-robot
Copy link

@tiraboschi: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi tiraboschi mentioned this pull request Jul 13, 2020
Closed
@kevinrizza
Copy link
Member

/ok-to-test
/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 13, 2020
@tiraboschi tiraboschi mentioned this pull request Jul 13, 2020
Merged
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2020
@gallettilance
Copy link
Member

/retest

@huzefa51
Copy link

Hello,
I am trying to push the manifest but getting below error.

ERROR: CSV.spec.crd.owned.version isnot in CRD.spec.versions list [manifests/myapp-operator.clusterserviceversion.yaml]

operator-courier --version

2.1.8

@eguzki eguzki mentioned this pull request Jul 15, 2020
Merged
@gallettilance
Copy link
Member

/retest

@tiraboschi
Copy link
Contributor Author

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2020
@tiraboschi
Correctly validate crd.spec.versions
6183101 
crd.spec.version got deprecated for crd.spec.versions
but in this case we are going to access a list of
dictionaries where the relevant value
is in the name field.

Fix all the validations on spec.versions and add
additional validations.

Fix also its test.

Signed-off-by: Simone Tiraboschi [email protected]
Fixes: operator-framework#188
@tiraboschi
Copy link
Contributor Author

/unhold

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2020
@tiraboschi
Copy link
Contributor Author

I updated https://github.com/tiraboschi/operator-courier/tree/fix_188 but strangely I still my latest changes here

@jmazzitelli
Copy link

I updated https://github.com/tiraboschi/operator-courier/tree/fix_188 but strangely I still my latest changes here

Github is having problems - I saw similar odd behavior in unrelated PRs - just have to wait for them to fix the infrastructure: https://www.githubstatus.com/

@tiraboschi tiraboschi force-pushed the fix_188 branch 2 times, most recently from fd59384 to 6183101 Compare July 15, 2020 17:08
@jhrozek
Copy link

jhrozek commented Jul 16, 2020

btw the patch works for me, thank you for the work!

@dinhxuanvu
Copy link
Member

/retest

1 similar comment
@dmesser
Copy link

dmesser commented Jul 20, 2020

/retest

This was referenced Jul 20, 2020
Merged
Merged
@gallettilance
Copy link
Member

/retest

@kevinrizza kevinrizza merged commit fa7b1bf into operator-framework:master Jul 20, 2020
@tiraboschi tiraboschi deleted the fix_188 branch July 21, 2020 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmazzitelli jmazzitelli jmazzitelli left review comments

@waynesun09 waynesun09 waynesun09 left review comments

@anik120 anik120 Awaiting requested review from anik120

@kevinrizza kevinrizza Awaiting requested review from kevinrizza

Assignees

@kevinrizza kevinrizza

Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[regression?] operator-courier 2.1.8 falsely(?) fails --ui_validate_io check
10 participants
@tiraboschi @openshift-ci-robot @kevinrizza @gallettilance @huzefa51 @jmazzitelli @jhrozek @dinhxuanvu @dmesser @waynesun09