Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loading of fixtures mappings securities in admin controller #252

Merged
merged 12 commits into from
Mar 25, 2019

Conversation

Aschen
Copy link
Contributor

@Aschen Aschen commented Mar 7, 2019

What does this PR do?

Adds documentation for kuzzleio/kuzzle#1255

Other changes

  • fix missing arguments for admin:reset* actions

@kuzzle
Copy link
Contributor

kuzzle commented Mar 7, 2019

Snippets tests reports

SDK Version Tests overview
v6 ✔️
v5 ✔️
v1 ✔️
v1 ✔️
v1 ✔️
v1 ✔️

* Field definitions follow the [Elasticsearch](https://www.elastic.co/guide/en/elasticsearch/reference/5.6/mapping.html) mapping format.
* If an index or collection does not exist, it will be created automatically.
* Mappings are loaded sequentially, one index/collection pair at a time. If a failure occurs, Kuzzle immediately interrupts the sequence.
* Mappings can be replayed as you want, as long as they do not change in-between.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove this last sentence.

src/api/1/controller-admin/load-mappings/index.md Outdated Show resolved Hide resolved
@Aschen Aschen requested a review from benoitvidis March 19, 2019 14:05
alexandrebouthinon pushed a commit to kuzzleio/kuzzle that referenced this pull request Mar 19, 2019
What does this PR do ?

Expose the functionalities that allows to load fixtures, mapping and securities at Kuzzle startup through the API.
The format remain unchanged.

I also add the corresponding CLI commands:

bin/kuzzle loadMappings mappings.json
bin/kuzzle loadFixtures fixtures.json
bin/kuzzle loadSecurities securities.json

Documentation: kuzzleio/documentation#252
src/api/1/controller-admin/load-fixtures/index.md Outdated Show resolved Hide resolved
src/api/1/controller-admin/load-fixtures/index.md Outdated Show resolved Hide resolved
src/api/1/controller-admin/load-fixtures/index.md Outdated Show resolved Hide resolved

## Response

Returns a confirmation that the command is being executed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.... weird, considering what has been said in the notes above: how do I know if there has been a failure?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to wait the fixtures loading with refresh: 'wait_for'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I still get acnkowledge: true as a response with that option?

Copy link
Contributor Author

@Aschen Aschen Mar 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, like index:create route

src/api/1/controller-admin/load-securities/index.md Outdated Show resolved Hide resolved
src/api/1/controller-admin/load-securities/index.md Outdated Show resolved Hide resolved
src/api/1/controller-admin/load-securities/index.md Outdated Show resolved Hide resolved

## Response

Returns a confirmation that the command is being executed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same remark than for loadFixtures: how do I know if a failure has occured?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same response: you have to wait the fixtures loading with refresh: 'wait_for'

src/api/1/controller-admin/reset-cache/index.md Outdated Show resolved Hide resolved
@benoitvidis benoitvidis merged commit 2f21c8b into 2-dev Mar 25, 2019
@scottinet scottinet mentioned this pull request Mar 26, 2019
scottinet added a commit that referenced this pull request Mar 26, 2019
# [2.1.0](https://github.com/kuzzleio/documentation/releases/tag/2.1.0) (2019-03-26)


#### Bug fixes

- [ [#251](#251) ] Fix ssl option name for android   ([jenow](https://github.com/jenow))

#### New features

- [ [#164](#164) ] KZL-861 Getting started with Webpack   ([xbill82](https://github.com/xbill82))

#### Enhancements

- [ [#252](#252) ] Add loading of fixtures mappings securities in admin controller   ([Aschen](https://github.com/Aschen))
- [ [#253](#253) ] Plugin embedded sdk   ([Aschen](https://github.com/Aschen))
- [ [#249](#249) ] Better example for SearchResult.next   ([Aschen](https://github.com/Aschen))

#### Others

- [ [#262](#262) ] [API] new auth:refreshToken API route documentation   ([scottinet](https://github.com/scottinet))
- [ [#257](#257) ] KZL-1054 Fix Node.js SDK Getting Started subscription   ([xbill82](https://github.com/xbill82))
- [ [#263](#263) ] [debug] Print standard output on an assertion error   ([scottinet](https://github.com/scottinet))
---
@xbill82 xbill82 deleted the add-fixtures-mappings-securities-admin-controller branch February 10, 2020 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants