-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin embedded sdk #253
Merged
Merged
Plugin embedded sdk #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitvidis
suggested changes
Mar 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job.
I personally would try to impersonate the introduction a little (avoid we
and you
) to make it more neutral.
scottinet
suggested changes
Mar 20, 2019
alexandrebouthinon
pushed a commit
to kuzzleio/kuzzle
that referenced
this pull request
Mar 20, 2019
Adds a method to use the original request user inside the requests sent by the embedded SDK. The main purpose of this feature is to properly set Kuzzle metadata (author and updater) on documents. Call to sdk.as(user) method will instantiate a new SDK with a FunnelProcotol that takes the user in the constructor and inject it in the request context before passing the request to theFunnel. // This will create a document with `author` metadata to `null` this.context.accessors.sdk.document.create(...); // This will create a document with `author` metadata to the original request user this.context.accessors.sdk.as(request.context.user).document.create(...); // This will throw a PluginImplementationError, no user impersonation for now this.context.accessors.sdk.as({ user: { _id: 'gordon' } }).document.create(...); Documentation: kuzzleio/documentation#253
Co-Authored-By: Aschen <[email protected]>
Co-Authored-By: Aschen <[email protected]>
Co-Authored-By: Aschen <[email protected]>
Co-Authored-By: Aschen <[email protected]>
Co-Authored-By: Aschen <[email protected]>
Co-Authored-By: Aschen <[email protected]>
scottinet
suggested changes
Mar 22, 2019
Co-Authored-By: Aschen <[email protected]>
scottinet
approved these changes
Mar 25, 2019
benoitvidis
approved these changes
Mar 25, 2019
Merged
scottinet
added a commit
that referenced
this pull request
Mar 26, 2019
# [2.1.0](https://github.com/kuzzleio/documentation/releases/tag/2.1.0) (2019-03-26) #### Bug fixes - [ [#251](#251) ] Fix ssl option name for android ([jenow](https://github.com/jenow)) #### New features - [ [#164](#164) ] KZL-861 Getting started with Webpack ([xbill82](https://github.com/xbill82)) #### Enhancements - [ [#252](#252) ] Add loading of fixtures mappings securities in admin controller ([Aschen](https://github.com/Aschen)) - [ [#253](#253) ] Plugin embedded sdk ([Aschen](https://github.com/Aschen)) - [ [#249](#249) ] Better example for SearchResult.next ([Aschen](https://github.com/Aschen)) #### Others - [ [#262](#262) ] [API] new auth:refreshToken API route documentation ([scottinet](https://github.com/scottinet)) - [ [#257](#257) ] KZL-1054 Fix Node.js SDK Getting Started subscription ([xbill82](https://github.com/xbill82)) - [ [#263](#263) ] [debug] Print standard output on an assertion error ([scottinet](https://github.com/scottinet)) ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds documentation about the embedded SDK for plugins
Other changes
Plugin context: <entry>
(eg:Plugin context: accessors
)