KZL-1054 Fix Node.js SDK Getting Started subscription #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottinet
approved these changes
Mar 14, 2019
Aschen
approved these changes
Mar 14, 2019
Snippets tests reports
|
benoitvidis
approved these changes
Mar 14, 2019
[first steps] fix titles to make them appear in the right nav pane
⚠️ depends on kuzzleio/sdk-cpp#70 Please restart the CI once the C++ SDK is updated. # Description Add the missing `kuzzleio::` namespace, required by the now fixed C++ SDK (see kuzzleio/sdk-cpp#70) # Other changes * C++ Getting Started guides: * fix typos in comments * use our standard formatting convention (2 spaces, 80 chars columns, ...) * fix the memleaked WebSocket pointer * add missing `disconnect` call, and missing pointer deletions * remove`#define` pragmas for data index and collection, as they made the code examples harder to follow, at least from my point of view * add missing `disconnect` call, and missing pointer deletions in C++ test templates
|
@xbill82 > Travis says that your change doesn't seem to work. Can you take a look at it? |
# Description Add a note in the manual installation section, instructing users to check their `ulimit -n` value on the server hosting Kuzzle instances
…#255) ## What does this PR do? Document missing getters in the C++ Kuzzle class about offline queue and reconnection options. Depends on kuzzleio/sdk-cpp#71
# Description Solve a code snippet resulting in a dangling pointer.
|
@xbill82 Maybe you can use the same mechanism as for the other realtime example: https://github.com/kuzzleio/documentation/blob/c87a51c66e555ef0334745be28f05e5f3cf4f26e/test/templates/realtime.tpl.js |
Merged
scottinet
added a commit
that referenced
this pull request
Mar 26, 2019
# [2.1.0](https://github.com/kuzzleio/documentation/releases/tag/2.1.0) (2019-03-26) #### Bug fixes - [ [#251](#251) ] Fix ssl option name for android ([jenow](https://github.com/jenow)) #### New features - [ [#164](#164) ] KZL-861 Getting started with Webpack ([xbill82](https://github.com/xbill82)) #### Enhancements - [ [#252](#252) ] Add loading of fixtures mappings securities in admin controller ([Aschen](https://github.com/Aschen)) - [ [#253](#253) ] Plugin embedded sdk ([Aschen](https://github.com/Aschen)) - [ [#249](#249) ] Better example for SearchResult.next ([Aschen](https://github.com/Aschen)) #### Others - [ [#262](#262) ] [API] new auth:refreshToken API route documentation ([scottinet](https://github.com/scottinet)) - [ [#257](#257) ] KZL-1054 Fix Node.js SDK Getting Started subscription ([xbill82](https://github.com/xbill82)) - [ [#263](#263) ] [debug] Print standard output on an assertion error ([scottinet](https://github.com/scottinet)) ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix subscription by moving the
kuzzle.disconnect()to the callback so that the program has to wait for it to quit.How should this be manually tested?
Follow the Node.js SDK Getting Started tutorial.
Other changes