Fix fusesoc dependency breakage using python-requirements.txt #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #302, azure-pipelines.yml was modified to ensure that attrs 19.1.0 is installed. This is because 19.2.0 breaks FuseSoC via the simplesat dependency (see enthought/sat-solver#270). While the edits to azure-pipelines.yml fixed CI, users following the getting started guide are still going to run into this issue. This commit addresses the problem in an alternative way - by specifying the version of attrs to use in python-requirements.txt. Introducing a constraints.txt could have advantages, but that is more intrusive and would require further doc updates. I feel that would be overkill for a quick fix workaround that we hope to remove quite rapidly.
|
Thanks Alex, that's the right workaround for this. |
imphil
approved these changes
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #302, azure-pipelines.yml was modified to ensure that attrs 19.1.0 is
installed. This is because 19.2.0 breaks FuseSoC via the simplesat
dependency (see enthought/sat-solver#270).
While the edits to azure-pipelines.yml fixed CI, users following the
getting started guide are still going to run into this issue. This
commit addresses the problem in an alternative way - by specifying the
version of attrs to use in python-requirements.txt.
Introducing a constraints.txt could have advantages, but that is more
intrusive and would require further doc updates. I feel that would be
overkill for a quick fix workaround that we hope to remove quite
rapidly.
This patch intends to be a quick fix - hopefully upstream simplesat will be fixed soon, or alternatively we can depend on a forked simplesat repo that contains the fix.