Fabo/1873 big mergeroo #1883
Merged
Fabo/1873 big mergeroo #1883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karoly Albert Szabo <[email protected]>
- move yarn update to a separate check. - update yarn and node Signed-off-by: Karoly Albert Szabo <[email protected]>
Signed-off-by: Karoly Albert Szabo <[email protected]>
Signed-off-by: Karoly Albert Szabo <[email protected]>
Signed-off-by: Karoly Albert Szabo <[email protected]>
* removed several electron references * basic sign in working * added scripts for backend * fixed missing tmdataloading on tabparameters * update to latest tendermint lib * added ssl cert creation readme * correct wait for connection on app start * updated webpack dev server * import genesis at build time * fixed tmfield * added networks to dev server * fixed pageview * fixed bug on LiProposal * increased timeout for waiting for blocks to proof connection * refactor keystore * made analytics not global * cleanup package scripts and deps * fixes signin feedback * enable transactions in prod mode * removed config.toml * removed browserified dependencies * tests refactored * remove build test * override write to clipboard in test * override copy to clipboard in test for btncopy * fixed app menu test * add gos genesis * added proxy * removed network config folder getter script * added tests for keystore and wallet * added salt * remove e2e tests for now * removed dependency ref * reenable console error safe guard * fixed snapshots * fixed session import * switched proxy * add new generate_only logic * better start scripts * added skip rebuild * fixed send snapshot * moved to latest SDK * make not creating the nodes the default * working gen and post * remove mnemonic from wallet * stripped console log * fixed lcdClient + tests * fixed send tests * added send tests * remove caddy binary * reenable error handlers * removed navigator mock * fix session sign up * refactored waiting for node * made default gas a config value * fixed gas config * catch wrong password * fixed tmformmsg * added coverage for getKey * ignore some lines from coverage * increase coverage user.js * refactored request postprocessors * ignore coverage for network.js * added test for main * ignore coverage in google analytics script * disable e2e tests for now * fixed gas for proposal generation * Switch to photinos * fix outputs and add verbose mode * removed display of secondary accounts
Signed-off-by: Karoly Albert Szabo <[email protected]>
Signed-off-by: Karoly Albert Szabo <[email protected]>
Signed-off-by: Karoly Albert Szabo <[email protected]>
Signed-off-by: Karoly Albert Szabo <[email protected]>
Fix: align snapshots -> WEB
Add yarn audit check -> WEB
Signed-off-by: Karoly Albert Szabo <[email protected]>
Signed-off-by: Karoly Albert Szabo <[email protected]>
Fix security audit
* reconnect is working * changelog * linted * fixed tests * fixed rpcwrapper tests * removed node halted * Update app/src/renderer/vuex/modules/connection.js Co-Authored-By: faboweb <[email protected]>
* removed several electron references * basic sign in working * added scripts for backend * fixed sign in * fied missing tmdataloading on tabparameters * update to latest tendermint lib * added ssl cert creation readme * use nilyra node * correct wait for connection on app start * updated webpack * linted * updated webpack dev server to work again * import genesis at build time * readd google analytics * fied tmfield * added networks to dev server * fixed pageview * reconnect on signin * Revert "reconnect on signin" This reverts commit a9e29b2. * fixed bug on LiProposal * increased timeout for waiting for blocks to proof connection * Update app/src/renderer/components/common/TmSessionSignIn.vue Co-Authored-By: faboweb <[email protected]> * refactor keystore * fixed keystore issues * made analytics not global * cleanup package scripts * cleanup deps * fixes signin feedback * enable transactions in prod mode * removed config.toml * code cleanup * removed browserified dependencies * several * several tests refactored * several * several * several * remove build test * override write to clipboard in test * more * override copy to clipboard in test for btncopy * fixed app menu test * add gos genesis * added proxy * added to start script * remove logging in prxy * refactored connection tests * fixed tests * removed network config folder getter script * refactored tests * linted * add wallet test * added tests for keystroe and wallet * added salt * linted * remove e2e tests for now * Revert "remove e2e tests for now" This reverts commit 2e0fd07. * removed dependency ref * changelog * reenable console error safe guard * fixed snapshots * fixed session import * redo local testnet creation * switched proxy * migrate to latest SDK * add new generate_only logic * Revert "redo local testnet creation" This reverts commit 85f9b0c. * reenable testnet logic * revert to working SDK * better start scripts * added skip rebuild * fixed send snapshot * linted * moved to latest SDK * make not creating the nodes the default * working gen and post * working * comments * remove mnemonic from wallet * stripped console log * fixed lcdClient + tests * fixed send tests * fix keystore tests * added send tests * remove caddy binary * latest working SDK patch * reenable error handlers * removed commented lines * removed naviagtor mock * fix session sign up * cleanup of config * refactored waiting for node * made default gas a config value * fixed typo * a * refactor of keystore test * fixed gas config * catch wrong password * fixed tests * fixed tmformmsg * added coverage for getKey * ignore some lines from coverage * increase coverage user.js * refactored request postprocessors * ignore coverage for network.js * removed more theme * added test for main * ignore coverage in google analytics script * removed more theme stuff * disable e2e tests for now * go with 2 nodes as the third node fails currently * updating header correctly and provide liquidAtoms getter * Update test/unit/specs/components/governance/PageGovernance.spec.js Co-Authored-By: faboweb <[email protected]> * removed comments * fixed pagevalidator test * updated tablevalidator jest * added coverage * update balance correct after sending * implemented feedback by Karoly * fixed integration test * tally bug * fixed serialization of txs * fix circleci audit job Signed-off-by: Karoly Albert Szabo <[email protected]> * fixed tally prop * fixed tests
faboweb
commented
Jan 25, 2019
| { | ||
| "name": "Cosmos Voyager", | ||
| "default_network": "local-testnet", | ||
| "denoms": ["stake", "photino"], |
There was a problem hiding this comment.
instead of relying on a genesis, fixing the denoms for now
Codecov Report
@@ Coverage Diff @@
## develop #1883 +/- ##
===========================================
- Coverage 94.95% 94.52% -0.44%
===========================================
Files 125 118 -7
Lines 2896 2467 -429
Branches 117 116 -1
===========================================
- Hits 2750 2332 -418
+ Misses 137 125 -12
- Partials 9 10 +1
|
fedekunze
reviewed
Jan 25, 2019
fedekunze
reviewed
Jan 25, 2019
jbibla
reviewed
Jan 25, 2019
| @@ -25,7 +24,9 @@ export default { | |||
| } | |||
| }, | |||
| data: () => ({ | |||
| showSuccess: false | |||
| showSuccess: false, | |||
| /* istanbul ignore next */ | |||
There was a problem hiding this comment.
istanbul is responsible for code coverage. this tells it to exclude the following statement from the coverage report
sabau
reviewed
Jan 28, 2019
sabau
reviewed
Jan 28, 2019
| @@ -357,7 +357,7 @@ let state = { | |||
| voting_start_time: `2018-11-23T13:29:24.66404Z`, | |||
| voting_end_time: `2018-11-25T13:29:24.66404Z`, | |||
| proposal_status: `Passed`, | |||
| tally_result: { | |||
| final_tally_result: { | |||
There was a problem hiding this comment.
let's double check why at some point it changes name (comes from old PR)
sabau
reviewed
Jan 28, 2019
sabau
reviewed
Jan 28, 2019
sabau
reviewed
Jan 28, 2019
sabau
reviewed
Jan 28, 2019
fedekunze
previously approved these changes
Jan 28, 2019
sabau
reviewed
Jan 28, 2019
sabau
reviewed
Jan 28, 2019
| @@ -164,13 +165,15 @@ export default ({ node }) => { | |||
| }) | |||
|
|
|||
| // optimistic update the atoms of the user before we get the new values from chain | |||
| commit(`setAtoms`, user.atoms - amount) | |||
| commit(`updateWalletBalance`, { | |||
sabau
reviewed
Jan 28, 2019
sabau
reviewed
Jan 28, 2019
sabau
reviewed
Jan 28, 2019
sabau
reviewed
Jan 28, 2019
sabau
reviewed
Jan 28, 2019
Co-Authored-By: faboweb <[email protected]>
added 2 commits
January 28, 2019 17:50
…yager into fabo/1873-big-mergeroo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1873
Description:
❤️ Thank you!
CHANGELOG.mdwith issue # and GitHub usernameFiles changedin the github PR explorer