Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

feat(tab-bar): Add tab bar #3229

Merged
merged 59 commits into from
Jul 27, 2018
Merged

feat(tab-bar): Add tab bar #3229

merged 59 commits into from
Jul 27, 2018

Conversation

patrickrodee
Copy link
Contributor

No description provided.

kfranqueiro and others added 30 commits April 16, 2018 15:55
…#2570)

The layoutFooterRipples dialog adapter API is no longer used and can be removed.
#2573)

Fixes #2558

Closure Compiler removed the `LEGACY` value for `--module_resolution`. It now defaults to `BROWSER` instead.

That change was made in google/closure-compiler@c2cd433

I ran `npm run test:closure` on this PR and `master` and compared their generated `.closure-tmp` directories. [Beyond Compare](https://www.scootersoftware.com/) found no diffs.
@mdc-web-bot
Copy link
Collaborator

All 128 screenshot tests passed for commit da10d84 vs. feat/tabs/tabs! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 128 screenshot tests passed for commit 9bf7b60 vs. feat/tabs/tabs! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 128 screenshot tests passed for commit 1f016cd vs. feat/tabs/tabs! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 128 screenshot tests passed for commit f3174f1 vs. feat/tabs/tabs! 💯🎉

1 similar comment
@mdc-web-bot
Copy link
Collaborator

All 128 screenshot tests passed for commit f3174f1 vs. feat/tabs/tabs! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 128 screenshot tests passed for commit b933372 vs. feat/tabs/tabs! 💯🎉

@codecov-io
Copy link

codecov-io commented Jul 27, 2018

Codecov Report

Merging #3229 into feat/tabs/tabs will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           feat/tabs/tabs    #3229      +/-   ##
==================================================
+ Coverage           98.28%   98.35%   +0.06%     
==================================================
  Files                 114      117       +3     
  Lines                4832     5037     +205     
  Branches              604      636      +32     
==================================================
+ Hits                 4749     4954     +205     
  Misses                 83       83
Impacted Files Coverage Δ
packages/mdc-tab-bar/foundation.js 100% <100%> (ø)
packages/mdc-tab-bar/index.js 100% <100%> (ø)
packages/mdc-tab-bar/constants.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44c9261...0c7f132. Read the comment docs.

@mdc-web-bot
Copy link
Collaborator

All 128 screenshot tests passed for commit 5fe2fbd vs. feat/tabs/tabs! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 128 screenshot tests passed for commit 8d15570 vs. feat/tabs/tabs! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 128 screenshot tests passed for commit cb25074 vs. feat/tabs/tabs! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 128 screenshot tests passed for commit 26eab8e vs. feat/tabs/tabs! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 128 screenshot tests passed for commit 7869fdd vs. feat/tabs/tabs! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 128 screenshot tests passed for commit 0c7f132 vs. feat/tabs/tabs! 💯🎉

@patrickrodee patrickrodee merged commit eb23e22 into feat/tabs/tabs Jul 27, 2018
kfranqueiro pushed a commit that referenced this pull request Jul 27, 2018
WIP fixed bg coloring of icons

fix(tab-indicator): Use absolute positioning (#2547)

WIP start of tab scroller

WIP fixed transition duration

WIP progress on scroller

WIP added demos back

chore(tabs): Removed tab scroller

feat(tabs): Add tab indicator inside tab (#2565)

feat(tab-scroller): Add tab scroller (#2577)

Merge master into feat/tabs/tabs (#3096)

feat(tab): Update tab color and typography (#3108)

docs(tabs): Update metadata and synopses (#3117)

feat(tab): Add MDCTabDimensions computation (#3122)

feat(tab): Emit selection and activation events (#3139)

docs(tabs): Update new READMEs to match standard (#3142)

feat(tab): Give focus to tab when activated (#3164)

feat(tab): Add mixin for parent positioning; Use mixin in tab scroller (#3179)

fix(tabs): Suppress area occupied by scrollbar on platforms that show it (#3149)

fix(tab): Remove extraneous padding from the stacked text label in LTR (#3193)

feat(tabs): Add missing docs and create helper util API (#3194)

Merge master into feat/tabs/tabs (#3227)

feat(tab): Update layout; Add fixed-width mixin; Add min-width class (#3220)

fix(tab-scroller): Fix incorrect animation stopping scroll value in RTL (#3237)

feat(tab-scroller): Add scroll content width method for use in tab bar (#3222)

feat(tab): Remove activation event emitting (#3242)

feat(tab-bar): Add tab bar (#3229)
@kfranqueiro kfranqueiro deleted the feat/tabs/tab-bar1 branch August 1, 2018 16:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants