Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dropping installed filters #670

Merged
merged 13 commits into from
Dec 13, 2023

Conversation

Artemka374
Copy link
Contributor

@Artemka374 Artemka374 commented Dec 12, 2023

What ❔

Fix dropping installed filters:

  • use LRU instead of HashMap for InstalledFIlters

Why ❔

Sometimes filters are dropped very quickly.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via cargo spellcheck --cfg=./spellcheck/era.cfg --code 1.

@Artemka374 Artemka374 changed the title [WIP]fix: dropping installed filters fix: dropping installed filters[WIP] Dec 12, 2023
@Artemka374 Artemka374 changed the title fix: dropping installed filters[WIP] fix: dropping installed filters Dec 12, 2023
…ed-filters' into afo-pla-671-fix-dropping-installed-filters
@Artemka374 Artemka374 marked this pull request as ready for review December 12, 2023 14:58
@Artemka374 Artemka374 requested a review from slowli December 12, 2023 21:35
@Artemka374 Artemka374 added this pull request to the merge queue Dec 13, 2023
Merged via the queue into main with commit 985c737 Dec 13, 2023
23 checks passed
@Artemka374 Artemka374 deleted the afo-pla-671-fix-dropping-installed-filters branch December 13, 2023 10:30
github-merge-queue bot pushed a commit that referenced this pull request Dec 13, 2023
🤖 I have created a release *beep* *boop*
---


##
[18.8.0](core-v18.7.0...core-v18.8.0)
(2023-12-13)


### Features

* **api:** Sunset API translator
([#675](#675))
([846fd33](846fd33))
* **core:** Merge bounded and unbounded gas adjuster
([#678](#678))
([f3c3bf5](f3c3bf5))
* **dal:** Make ConnectionPoolBuilder owned
([#676](#676))
([1153c42](1153c42))
* Implemented 1 validator consensus for the main node
([#554](#554))
([9c59838](9c59838))
* **merkle tree:** Snapshot recovery in metadata calculator
([#607](#607))
([f49418b](f49418b))


### Bug Fixes

* dropping installed filters
([#670](#670))
([985c737](985c737))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants