Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dal): Make ConnectionPoolBuilder owned #676

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Conversation

popzxc
Copy link
Member

@popzxc popzxc commented Dec 13, 2023

What ❔

Removes lifetime in the ConnectionPoolBuilder

Why ❔

To make it easier to store the builder in long-living structures.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via cargo spellcheck --cfg=./spellcheck/era.cfg --code 1.

@popzxc popzxc requested a review from slowli December 13, 2023 07:27
core/lib/dal/src/connection/mod.rs Show resolved Hide resolved
@popzxc popzxc added this pull request to the merge queue Dec 13, 2023
Merged via the queue into main with commit 1153c42 Dec 13, 2023
24 checks passed
@popzxc popzxc deleted the popzxc-owned-pool-creator branch December 13, 2023 08:36
github-merge-queue bot pushed a commit that referenced this pull request Dec 13, 2023
🤖 I have created a release *beep* *boop*
---


##
[18.8.0](core-v18.7.0...core-v18.8.0)
(2023-12-13)


### Features

* **api:** Sunset API translator
([#675](#675))
([846fd33](846fd33))
* **core:** Merge bounded and unbounded gas adjuster
([#678](#678))
([f3c3bf5](f3c3bf5))
* **dal:** Make ConnectionPoolBuilder owned
([#676](#676))
([1153c42](1153c42))
* Implemented 1 validator consensus for the main node
([#554](#554))
([9c59838](9c59838))
* **merkle tree:** Snapshot recovery in metadata calculator
([#607](#607))
([f49418b](f49418b))


### Bug Fixes

* dropping installed filters
([#670](#670))
([985c737](985c737))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants