-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): Sunset API translator #675
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popzxc
force-pushed
the
popzxc-sunset-translator
branch
from
December 13, 2023 08:13
663b85f
to
59ac146
Compare
AnastasiiaVashchuk
previously approved these changes
Dec 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pub fn enable_request_translator(mut self) -> Self {
tracing::info!("Logs request translator enabled");
self.logs_translator_enabled = true;
self
}
should we removed as well
AnastasiiaVashchuk
approved these changes
Dec 13, 2023
also, we need to not forget to remove configs from gitops repo. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 13, 2023
🤖 I have created a release *beep* *boop* --- ## [18.8.0](core-v18.7.0...core-v18.8.0) (2023-12-13) ### Features * **api:** Sunset API translator ([#675](#675)) ([846fd33](846fd33)) * **core:** Merge bounded and unbounded gas adjuster ([#678](#678)) ([f3c3bf5](f3c3bf5)) * **dal:** Make ConnectionPoolBuilder owned ([#676](#676)) ([1153c42](1153c42)) * Implemented 1 validator consensus for the main node ([#554](#554)) ([9c59838](9c59838)) * **merkle tree:** Snapshot recovery in metadata calculator ([#607](#607)) ([f49418b](f49418b)) ### Bug Fixes * dropping installed filters ([#670](#670)) ([985c737](985c737)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
zks_getLogsWithVirtualBlocks
method, and related no-longer-needed code.Why ❔
Checklist
zk fmt
andzk lint
.cargo spellcheck --cfg=./spellcheck/era.cfg --code 1
.