Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tree): Make failure to provide id-compressor a usage error #20282

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

Abe27342
Copy link
Contributor

@Abe27342 Abe27342 commented Mar 22, 2024

Description

Converts an assert in SharedTree to a UsageError, as we expect it to primarily be hit by misconfigured applications.

@Abe27342 Abe27342 requested a review from taylorsw04 March 22, 2024 19:14
@Abe27342 Abe27342 requested a review from a team as a code owner March 22, 2024 19:14
@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: tree base: main PRs targeted against main branch labels Mar 22, 2024
@msfluid-bot
Copy link
Collaborator

@fluid-example/bundle-size-tests: +115 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 514.76 KB 514.76 KB No change
azureClient.js 605.82 KB 605.82 KB No change
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 249.19 KB 249.19 KB No change
fluidFramework.js 340.84 KB 340.9 KB +58 Bytes
loader.js 127.97 KB 127.97 KB No change
map.js 41.35 KB 41.35 KB No change
matrix.js 143.61 KB 143.61 KB No change
odspClient.js 574.28 KB 574.28 KB No change
odspDriver.js 97.49 KB 97.49 KB No change
odspPrefetchSnapshot.js 41.91 KB 41.91 KB No change
sharedString.js 161.38 KB 161.38 KB No change
sharedTree.js 330.97 KB 331.03 KB +57 Bytes
Total Size 3.3 MB 3.3 MB +115 Bytes

Baseline commit: f54faf1

Generated by 🚫 dangerJS against ff7faaf

@Abe27342 Abe27342 requested a review from noencke March 25, 2024 18:06
@Abe27342 Abe27342 merged commit 404c0bb into microsoft:main Mar 25, 2024
33 checks passed
@Abe27342 Abe27342 deleted the make-id-compressor-usage-error branch March 25, 2024 18:38
tianzhu007 added a commit that referenced this pull request Mar 25, 2024
* main: (36 commits)
  feat(tree): create refreshers during delta visit (#20303)
  Lint against import of @fluidframework/datastore in e2e tests (#20307)
  server: cover edge cases for scrubbed checkpoint users (#20259)
  refactor: Update dev dep on package 'start-server-and-test' (#20298)
  ci: Move templates out of the 1ES folder (#20056)
  Added unit tests to check usage of IRedisClientConnectionManager for Historian and Gitrest (#20306)
  build(test-snapshots): use node16 module resolution (#20233)
  Forbid import of @fluidframework/aqueduct in e2e tests (#20261)
  fix(tree): Make failure to provide id-compressor a usage error (#20282)
  fix(api-markdown-documenter): Reduce package version to correct next version (#20302)
  Added customization for gitrest and historian (#20243)
  fix(build-tools): mixed internal range detection (#18828)
  Removing 'paused session' path from SessionResult Metric (#20294)
  fix(fluid-build): limit Biome config tracking to repo (#20296)
  refactor: Update webpack-dev-server dependency (#20278)
  Create framework for safe rollout of back-compatible runtime document schema changes (#20174)
  Test enabling IdCompressor in RC2 (#20256)
  refactor(tree): Extract leaf schemas into their own module (#20289)
  build(client,build-tools): Upgrade biome to 1.6.2 (#20285)
  feat(build-cli): Add `modify fluid-imports` command (#20006)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds: tree area: dds Issues related to distributed data structures base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants