Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tree): create refreshers during delta visit #20303

Merged
merged 6 commits into from
Mar 25, 2024
Merged

feat(tree): create refreshers during delta visit #20303

merged 6 commits into from
Mar 25, 2024

Conversation

jenn-le
Copy link
Contributor

@jenn-le jenn-le commented Mar 25, 2024

  • creates refresher data when visiting a delta
  • only creates refreshers when needed

@jenn-le jenn-le requested a review from a team as a code owner March 25, 2024 17:52
@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: tree base: main PRs targeted against main branch labels Mar 25, 2024
yann-achard-MS
yann-achard-MS reviewed Mar 25, 2024
View reviewed changes
packages/dds/tree/src/core/tree/visitDelta.ts Outdated Show resolved Hide resolved
packages/dds/tree/src/core/tree/visitDelta.ts Outdated Show resolved Hide resolved
packages/dds/tree/src/test/tree/visitDelta.spec.ts Outdated Show resolved Hide resolved
packages/dds/tree/src/test/tree/visitDelta.spec.ts Outdated Show resolved Hide resolved
@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Mar 25, 2024 •
edited
Loading

⯅ @fluid-example/bundle-size-tests: +971 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 520.09 KB 520.09 KB ■ No change
azureClient.js 611.22 KB 611.22 KB ■ No change
connectionState.js 680 Bytes 680 Bytes ■ No change
containerRuntime.js 254.53 KB 254.53 KB ■ No change
fluidFramework.js 341 KB 341.48 KB ⯅ +487 Bytes
loader.js 127.97 KB 127.97 KB ■ No change
map.js 41.35 KB 41.35 KB ■ No change
matrix.js 143.61 KB 143.61 KB ■ No change
odspClient.js 579.68 KB 579.68 KB ■ No change
odspDriver.js 97.49 KB 97.49 KB ■ No change
odspPrefetchSnapshot.js 41.91 KB 41.91 KB ■ No change
sharedString.js 161.38 KB 161.38 KB ■ No change
sharedTree.js 331.13 KB 331.6 KB ⯅ +484 Bytes
Total Size 3.32 MB 3.32 MB ⯅ +971 Bytes

Baseline commit: 9b3ec59

Generated by 🚫 dangerJS against 3ed88c3

@jenn-le jenn-le merged commit c401449 into microsoft:main Mar 25, 2024
31 checks passed
@jenn-le jenn-le deleted the refresher-delta-visit branch March 25, 2024 21:25
tianzhu007 added a commit that referenced this pull request Mar 25, 2024
@tianzhu007
Merge branch 'main' into test/tianzhu/add-ip
f4f1a4d 
* main: (36 commits)
  feat(tree): create refreshers during delta visit (#20303)
  Lint against import of @fluidframework/datastore in e2e tests (#20307)
  server: cover edge cases for scrubbed checkpoint users (#20259)
  refactor: Update dev dep on package 'start-server-and-test' (#20298)
  ci: Move templates out of the 1ES folder (#20056)
  Added unit tests to check usage of IRedisClientConnectionManager for Historian and Gitrest (#20306)
  build(test-snapshots): use node16 module resolution (#20233)
  Forbid import of @fluidframework/aqueduct in e2e tests (#20261)
  fix(tree): Make failure to provide id-compressor a usage error (#20282)
  fix(api-markdown-documenter): Reduce package version to correct next version (#20302)
  Added customization for gitrest and historian (#20243)
  fix(build-tools): mixed internal range detection (#18828)
  Removing 'paused session' path from SessionResult Metric (#20294)
  fix(fluid-build): limit Biome config tracking to repo (#20296)
  refactor: Update webpack-dev-server dependency (#20278)
  Create framework for safe rollout of back-compatible runtime document schema changes (#20174)
  Test enabling IdCompressor in RC2 (#20256)
  refactor(tree): Extract leaf schemas into their own module (#20289)
  build(client,build-tools): Upgrade biome to 1.6.2 (#20285)
  feat(build-cli): Add `modify fluid-imports` command (#20006)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yann-achard-MS yann-achard-MS yann-achard-MS approved these changes

Assignees
No one assigned
Labels
area: dds: tree area: dds Issues related to distributed data structures base: main PRs targeted against main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jenn-le @msfluid-bot @yann-achard-MS