Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick debugpy connect/listen fix to release #10644

Merged
merged 1 commit into from
Mar 18, 2020

Conversation

karthiknadig
Copy link
Member

No description provided.

* Ensure local host only if connection not available

* Add news item
@karthiknadig karthiknadig requested a review from int19h March 18, 2020 19:16
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-io
Copy link

codecov-io commented Mar 18, 2020

Codecov Report

Merging #10644 into release-2020.03 will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release-2020.03   #10644      +/-   ##
===================================================
- Coverage            60.85%   60.83%   -0.02%     
===================================================
  Files                  579      579              
  Lines                31297    31296       -1     
  Branches              4450     4449       -1     
===================================================
- Hits                 19045    19039       -6     
- Misses               11289    11292       +3     
- Partials               963      965       +2     
Impacted Files Coverage Δ
src/client/debugger/types.ts 100.00% <ø> (ø)
...bugger/extension/configuration/resolvers/attach.ts 81.66% <100.00%> (ø)
src/datascience-ui/react-common/arePathsSame.ts 75.00% <0.00%> (-12.50%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️
src/client/constants.ts 100.00% <0.00%> (+16.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7cf79b...3722cef. Read the comment docs.

@karthiknadig karthiknadig merged commit 31cd1f2 into microsoft:release-2020.03 Mar 18, 2020
karthiknadig added a commit that referenced this pull request Mar 26, 2020
* Davidkutu/port intellisense fix (#10531)

* Jupyter autocompletion will only show up on empty lines,
instead of appearing in functions.

* filter out magic commands instead of
ignoring all the jupyter intellisense.

* moved the new code to a function and created tests

* removed pressCtrlSpace function

* added comments

* update changelog and delete news file

* Rename datascience to datascience_modules (#10525) (#10528)

* Rename datascience to datascience_modules (#10525)

* Rename datascience to datascience_modules

* Change name to something even harder to get wrong

* Fix unit test failure for release

* Ensure local host only if connection not available (#10600) (#10644)

* Ensure local host only if connection not available

* Add news item

* Fix #10437: Update launch.json handling to support "listen" and "connect" (#10517) (#10654)

Co-authored-by: Pavel Minaev <[email protected]>

* Update version and change log (#10662)

* Update version and change log

* Fix flakey file system tests (#10541)

Co-authored-by: Rich Chiodo <[email protected]>

Co-authored-by: David Kutugata <[email protected]>
Co-authored-by: Rich Chiodo <[email protected]>
Co-authored-by: Pavel Minaev <[email protected]>
@lock lock bot locked as resolved and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants