This updates the topic cards on Product landing and AAQ #6456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
smithellis
commented
Jan 16, 2025
smithellis
commented
- A utility function builds the topics_context for the cards
- Article and Topic links are corrected
- This addresses:
- 500 error when trying to access a product solutions page sumo#2128 - 500 error
- Articles displayed inside the topic cards are redirecting the user to the product landing page instead of the actual article page sumo#2134 - Links wrong
- Top articles are not listed inside the topic cards sumo#2130 - Articles not listed
- Inconsistencies in the number of articles displayed inside the topic cards sumo#2133 - Number of articles displayed
* A utility function builds the topics_context for the cards
* Article and Topic links are corrected
* This addresses:
* mozilla/sumo#2128 - 500 error
* mozilla/sumo#2134 - Links wrong
* mozilla/sumo#2130 - Articles not listed
* mozilla/sumo#2133 - Number of articles
displayed
This was referenced Jan 17, 2025
akatsoulas
requested changes
Jan 17, 2025
* Improved query to go easier on db * Get a document count() before processing documents * Only process document objects if I don't have enough featured articles
smithellis
force-pushed
the
topic-cards-revised
branch
from
f6a04ad to
ff5b134
Compare
akatsoulas
requested changes
Jan 20, 2025
smithellis
force-pushed
the
topic-cards-revised
branch
from
0007a48 to
2889414
Compare
smithellis
force-pushed
the
topic-cards-revised
branch
from
2889414 to
889fc2b
Compare
escattone
requested changes
Jan 21, 2025
* Use query annoation in `utils.py` to gather topics * Use `chain` and `islice` to ensure proper doc order and count
smithellis
force-pushed
the
topic-cards-revised
branch
from
a998164 to
c7cdfa9
Compare
|
Closing in favor of new consolidated PR #6471 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.