Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instrument All Redis Client Methods #576

Merged
merged 9 commits into from
Jun 27, 2022
Merged

Instrument All Redis Client Methods #576

merged 9 commits into from
Jun 27, 2022

Conversation

TimPansino
Copy link
Contributor

Overview

  • Add additional instrumentation points for all new client methods in Redis, as well as Redis Modules.

TimPansino and others added 2 commits June 23, 2022 11:23
@TimPansino
Initial test files
2ac8882
@TimPansino @umaannamalai
@ccedacero-nr @Nayuken
Fully instrument uninstrumented redis client methods
f97fb3c 
Co-authored-by: Uma Annamalai <[email protected]>
Co-authored-by: ccedacero-nr <[email protected]>
Co-authored-by: Nyenty Ayuk <[email protected]>
@TimPansino TimPansino changed the base branch from main to develop-aioredis June 23, 2022 20:17
@TimPansino TimPansino marked this pull request as ready for review June 23, 2022 20:18
@TimPansino TimPansino requested a review from a team June 23, 2022 20:18
@github-actions
Copy link

github-actions bot commented Jun 23, 2022 •
edited
Loading

MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON bandit 18 0 0.97s
✅ PYTHON black 18 15 0 2.92s
❌ PYTHON flake8 18 32 0.97s
✅ PYTHON isort 18 15 0 0.24s
✅ PYTHON pylint 18 0 9.11s
✅ YAML prettier 1 1 0 0.99s
✅ YAML v8r 1 0 1.34s
✅ YAML yamllint 1 0 0.35s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

umaannamalai
umaannamalai approved these changes Jun 24, 2022
View reviewed changes
tests/datastore_redis/test_uninstrumented_methods.py Outdated
"response_callbacks",
"RESPONSE_CALLBACKS",
"sentinel",
"sentinel",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "sentinel" supposed to be an ignored method and in the redis_client_methods list? It is in this list twice as well

@umaannamalai umaannamalai added this to the v7.14.0.177 milestone Jun 27, 2022
@umaannamalai umaannamalai merged commit 7eba295 into develop-aioredis Jun 27, 2022
@umaannamalai umaannamalai deleted the fix-redis-client-methods branch June 27, 2022 17:38
TimPansino added a commit that referenced this pull request Jun 28, 2022
@umaannamalai @TimPansino
@Nayuken @ccedacero-nr
Add support for aioredis. (#577)
77c5909 
* Add aioredis Instrumentation (#567)

* Add aioredis instrumentation

Co-authored-by: Uma Annamalai <[email protected]>
Co-authored-by: Nyenty Ayuk <[email protected]>
Co-authored-by: ccedacero-nr <[email protected]>

* [Mega-Linter] Apply linters fixes

* Bump Tests

* Fix double wrapping

Co-authored-by: Uma Annamalai <[email protected]>
Co-authored-by: Nyenty Ayuk <[email protected]>
Co-authored-by: ccedacero-nr <[email protected]>
Co-authored-by: TimPansino <[email protected]>

* Add aioredis test infrastructure. (#568)

* Add aioredis test infra.

* Fix flake8 errors.

* Aredis concurrency bug reproduction. (#569)

Co-authored-by: Uma Annamalai <[email protected]>

Co-authored-by: Uma Annamalai <[email protected]>

* Add aioredis tests (#573)

* Add get and set tests.

* Add more testing for aioredis.

* Add aioredis testing.

Co-authored-by: Tim Pansino <[email protected]>
Co-authored-by: Cristian Cedacero <[email protected]>
Co-authored-by: Nyenty Ayuk-Enow <[email protected]>

* Patch broken tests

* Final aioredis testing cleanup

Co-authored-by: Nyenty Ayuk <[email protected]>
Co-authored-by: ccedacero-nr <[email protected]>
Co-authored-by: Uma Annamalai <[email protected]>

* Parametrize multiple db tests.

* Add missing arg.

* Fix typo.

* Add missing comma.

* Add background_task decorator.

* Parametrize instance info tests.

* Fix formatting

Co-authored-by: Tim Pansino <[email protected]>
Co-authored-by: Cristian Cedacero <[email protected]>
Co-authored-by: Nyenty Ayuk-Enow <[email protected]>
Co-authored-by: Tim Pansino <[email protected]>
Co-authored-by: ccedacero-nr <[email protected]>
Co-authored-by: Uma Annamalai <[email protected]>
Co-authored-by: Timothy Pansino <[email protected]>

* Fix AIORedis Concurrency Bug (#574)

* Add test for concurrency bug

* Fix aioredis concurrency

* Fix func signature

* Fix ARedis Concurrency Bug (#570)

* Patch aredis concurrency bug

* Remove xfail marker

* Format

* Move fixture import

Co-authored-by: Uma Annamalai <[email protected]>

* Increase concurrency of redis tests (#575)

* Instrument All Redis Client Methods (#576)

* Initial test files

* Fully instrument uninstrumented redis client methods

Co-authored-by: Uma Annamalai <[email protected]>
Co-authored-by: ccedacero-nr <[email protected]>
Co-authored-by: Nyenty Ayuk <[email protected]>

* Fix older redis client tests

* Fix missing redis client method

* Remove sentinel from commands list

* Fix sentinels again

Co-authored-by: Uma Annamalai <[email protected]>
Co-authored-by: ccedacero-nr <[email protected]>
Co-authored-by: Nyenty Ayuk <[email protected]>

* Add aioredis v1 support (#579)

* Add aioredis v1 tests

* Fix aioredis v1

Co-authored-by: Uma Annamalai <[email protected]>

* Adjust multiple dbs tests

* Fix megalinter default base

* Fix megalinter base take two

* Fix aioredis version parser

* Uncomment instance info tests

* Fix import issues

Co-authored-by: Uma Annamalai <[email protected]>

Co-authored-by: Timothy Pansino <[email protected]>
Co-authored-by: Uma Annamalai <[email protected]>
Co-authored-by: Nyenty Ayuk <[email protected]>
Co-authored-by: ccedacero-nr <[email protected]>
Co-authored-by: TimPansino <[email protected]>
Co-authored-by: Tim Pansino <[email protected]>
Co-authored-by: Cristian Cedacero <[email protected]>
Co-authored-by: Tim Pansino <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umaannamalai umaannamalai umaannamalai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v7.14.0.177
Development

Successfully merging this pull request may close these issues.
2 participants
@TimPansino @umaannamalai