Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for aioredis. #577

Merged
merged 9 commits into from
Jun 28, 2022
Merged

Add support for aioredis. #577

merged 9 commits into from
Jun 28, 2022

Conversation

umaannamalai
Copy link
Contributor

This PR adds instrumentation and testing for aioredis. It also expands the list of currently instrumented commands in the aredis and redis libraries.

TimPansino and others added 8 commits June 14, 2022 16:04
* Add aioredis instrumentation

Co-authored-by: Uma Annamalai <[email protected]>
Co-authored-by: Nyenty Ayuk <[email protected]>
Co-authored-by: ccedacero-nr <[email protected]>

* [Mega-Linter] Apply linters fixes

* Bump Tests

* Fix double wrapping

Co-authored-by: Uma Annamalai <[email protected]>
Co-authored-by: Nyenty Ayuk <[email protected]>
Co-authored-by: ccedacero-nr <[email protected]>
Co-authored-by: TimPansino <[email protected]>
* Add aioredis test infra.

* Fix flake8 errors.
Co-authored-by: Uma Annamalai <[email protected]>

Co-authored-by: Uma Annamalai <[email protected]>
* Add get and set tests.

* Add more testing for aioredis.

* Add aioredis testing.

Co-authored-by: Tim Pansino <[email protected]>
Co-authored-by: Cristian Cedacero <[email protected]>
Co-authored-by: Nyenty Ayuk-Enow <[email protected]>

* Patch broken tests

* Final aioredis testing cleanup

Co-authored-by: Nyenty Ayuk <[email protected]>
Co-authored-by: ccedacero-nr <[email protected]>
Co-authored-by: Uma Annamalai <[email protected]>

* Parametrize multiple db tests.

* Add missing arg.

* Fix typo.

* Add missing comma.

* Add background_task decorator.

* Parametrize instance info tests.

* Fix formatting

Co-authored-by: Tim Pansino <[email protected]>
Co-authored-by: Cristian Cedacero <[email protected]>
Co-authored-by: Nyenty Ayuk-Enow <[email protected]>
Co-authored-by: Tim Pansino <[email protected]>
Co-authored-by: ccedacero-nr <[email protected]>
Co-authored-by: Uma Annamalai <[email protected]>
Co-authored-by: Timothy Pansino <[email protected]>
* Add test for concurrency bug

* Fix aioredis concurrency

* Fix func signature
* Patch aredis concurrency bug

* Remove xfail marker

* Format

* Move fixture import

Co-authored-by: Uma Annamalai <[email protected]>
* Initial test files

* Fully instrument uninstrumented redis client methods

Co-authored-by: Uma Annamalai <[email protected]>
Co-authored-by: ccedacero-nr <[email protected]>
Co-authored-by: Nyenty Ayuk <[email protected]>

* Fix older redis client tests

* Fix missing redis client method

* Remove sentinel from commands list

* Fix sentinels again

Co-authored-by: Uma Annamalai <[email protected]>
Co-authored-by: ccedacero-nr <[email protected]>
Co-authored-by: Nyenty Ayuk <[email protected]>
@umaannamalai umaannamalai requested a review from a team June 27, 2022 18:00
@github-actions
Copy link

github-actions bot commented Jun 27, 2022

MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON bandit 18 0 1.47s
✅ PYTHON black 18 8 0 4.26s
❌ PYTHON flake8 18 35 1.44s
✅ PYTHON isort 18 16 0 0.37s
✅ PYTHON pylint 18 0 14.0s
✅ YAML prettier 2 1 0 1.37s
✅ YAML v8r 2 0 2.05s
✅ YAML yamllint 2 0 0.53s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

* Add aioredis v1 tests

* Fix aioredis v1

Co-authored-by: Uma Annamalai <[email protected]>

* Adjust multiple dbs tests

* Fix megalinter default base

* Fix megalinter base take two

* Fix aioredis version parser

* Uncomment instance info tests

* Fix import issues

Co-authored-by: Uma Annamalai <[email protected]>
@TimPansino TimPansino merged commit 77c5909 into main Jun 28, 2022
@TimPansino TimPansino deleted the develop-aioredis branch June 28, 2022 20:40
@TimPansino TimPansino added this to the v7.14.0.177 milestone Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants