Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aioredis v1 support #579

Merged
merged 8 commits into from
Jun 28, 2022
Merged

Add aioredis v1 support #579

merged 8 commits into from
Jun 28, 2022

Conversation

TimPansino
Copy link
Contributor

@TimPansino TimPansino commented Jun 27, 2022 •
edited
Loading

Overview

  • Adjusts instrumentation and tests to support older versions of aioredis.
  • Adjust megalinter to target PR bases instead of main.

TimPansino and others added 2 commits June 27, 2022 11:59
@TimPansino TimPansino requested a review from a team June 27, 2022 21:16
@TimPansino TimPansino mentioned this pull request Jun 27, 2022
Closed
@TimPansino TimPansino changed the base branch from main to develop-aioredis June 27, 2022 21:17
@github-actions
Copy link

github-actions bot commented Jun 27, 2022 •
edited
Loading

MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON bandit 12 0 1.08s
✅ PYTHON black 12 4 0 3.11s
❌ PYTHON flake8 12 30 1.15s
✅ PYTHON isort 12 12 0 0.28s
✅ PYTHON pylint 12 0 10.25s
✅ YAML prettier 1 0 0 0.55s
✅ YAML v8r 1 0 1.27s
✅ YAML yamllint 1 0 0.12s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

@TimPansino TimPansino merged commit 6b14b87 into develop-aioredis Jun 28, 2022
@TimPansino TimPansino deleted the add-aioredis-v1-support branch June 28, 2022 20:38
TimPansino added a commit that referenced this pull request Jun 28, 2022
@umaannamalai @TimPansino
@Nayuken @ccedacero-nr
Add support for aioredis. (#577)
77c5909 
* Add aioredis Instrumentation (#567)

* Add aioredis instrumentation

Co-authored-by: Uma Annamalai <[email protected]>
Co-authored-by: Nyenty Ayuk <[email protected]>
Co-authored-by: ccedacero-nr <[email protected]>

* [Mega-Linter] Apply linters fixes

* Bump Tests

* Fix double wrapping

Co-authored-by: Uma Annamalai <[email protected]>
Co-authored-by: Nyenty Ayuk <[email protected]>
Co-authored-by: ccedacero-nr <[email protected]>
Co-authored-by: TimPansino <[email protected]>

* Add aioredis test infrastructure. (#568)

* Add aioredis test infra.

* Fix flake8 errors.

* Aredis concurrency bug reproduction. (#569)

Co-authored-by: Uma Annamalai <[email protected]>

Co-authored-by: Uma Annamalai <[email protected]>

* Add aioredis tests (#573)

* Add get and set tests.

* Add more testing for aioredis.

* Add aioredis testing.

Co-authored-by: Tim Pansino <[email protected]>
Co-authored-by: Cristian Cedacero <[email protected]>
Co-authored-by: Nyenty Ayuk-Enow <[email protected]>

* Patch broken tests

* Final aioredis testing cleanup

Co-authored-by: Nyenty Ayuk <[email protected]>
Co-authored-by: ccedacero-nr <[email protected]>
Co-authored-by: Uma Annamalai <[email protected]>

* Parametrize multiple db tests.

* Add missing arg.

* Fix typo.

* Add missing comma.

* Add background_task decorator.

* Parametrize instance info tests.

* Fix formatting

Co-authored-by: Tim Pansino <[email protected]>
Co-authored-by: Cristian Cedacero <[email protected]>
Co-authored-by: Nyenty Ayuk-Enow <[email protected]>
Co-authored-by: Tim Pansino <[email protected]>
Co-authored-by: ccedacero-nr <[email protected]>
Co-authored-by: Uma Annamalai <[email protected]>
Co-authored-by: Timothy Pansino <[email protected]>

* Fix AIORedis Concurrency Bug (#574)

* Add test for concurrency bug

* Fix aioredis concurrency

* Fix func signature

* Fix ARedis Concurrency Bug (#570)

* Patch aredis concurrency bug

* Remove xfail marker

* Format

* Move fixture import

Co-authored-by: Uma Annamalai <[email protected]>

* Increase concurrency of redis tests (#575)

* Instrument All Redis Client Methods (#576)

* Initial test files

* Fully instrument uninstrumented redis client methods

Co-authored-by: Uma Annamalai <[email protected]>
Co-authored-by: ccedacero-nr <[email protected]>
Co-authored-by: Nyenty Ayuk <[email protected]>

* Fix older redis client tests

* Fix missing redis client method

* Remove sentinel from commands list

* Fix sentinels again

Co-authored-by: Uma Annamalai <[email protected]>
Co-authored-by: ccedacero-nr <[email protected]>
Co-authored-by: Nyenty Ayuk <[email protected]>

* Add aioredis v1 support (#579)

* Add aioredis v1 tests

* Fix aioredis v1

Co-authored-by: Uma Annamalai <[email protected]>

* Adjust multiple dbs tests

* Fix megalinter default base

* Fix megalinter base take two

* Fix aioredis version parser

* Uncomment instance info tests

* Fix import issues

Co-authored-by: Uma Annamalai <[email protected]>

Co-authored-by: Timothy Pansino <[email protected]>
Co-authored-by: Uma Annamalai <[email protected]>
Co-authored-by: Nyenty Ayuk <[email protected]>
Co-authored-by: ccedacero-nr <[email protected]>
Co-authored-by: TimPansino <[email protected]>
Co-authored-by: Tim Pansino <[email protected]>
Co-authored-by: Cristian Cedacero <[email protected]>
Co-authored-by: Tim Pansino <[email protected]>
@TimPansino TimPansino modified the milestone: v7.14.0.177 Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umaannamalai umaannamalai umaannamalai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v7.14.0.177
Development

Successfully merging this pull request may close these issues.
2 participants
@TimPansino @umaannamalai