feat(store): warn on unhandled actions #1870

arturovt · 2022-06-22T23:08:14Z

No description provided.

bundlemon · 2022-06-22T23:16:14Z

BundleMon

Files updated (2)

Status	Path	Size	Limits
❌	fesm5/ngxs-store.js	143.11KB (+5.42KB +3.94%)	145KB / +0.5%
❌	fesm2015/ngxs-store.js	122.48KB (+4.07KB +3.43%)	125KB / +0.5%

Unchanged files (4)

Status	Path	Size	Limits
✅	fesm5/ngxs-store-operators.js	10.01KB	15KB / +0.5%
✅	fesm2015/ngxs-store-operators.js	9.87KB	15KB / +0.5%
✅	fesm5/ngxs-store-internals.js	6.58KB	20KB / +0.5%
✅	fesm2015/ngxs-store-internals.js	5.65KB	20KB / +0.5%

Total files change +9.48KB +3.29%

Groups updated (6)

Status	Path	Size	Limits
❌	@ngxs/store(esm5)[gzip] _{./esm5/*/.js}	187.46KB (+6.46KB +3.57%)	+1%
❌	@ngxs/store(esm2015)[gzip] _{./esm2015/*/.js}	180.24KB (+5.95KB +3.41%)	+1%
❌	@ngxs/store(umd)[gzip] _{./bundles/*.umd.js}	41.54KB (+1006B +2.42%)	+1%
❌	@ngxs/store(fesm5)[gzip] _./fesm5/*.js	30.81KB (+971B +3.18%)	+1%
❌	@ngxs/store(fesm2015)[gzip] _{./fesm2015/*.js}	28.07KB (+772B +2.76%)	+1%
❌	@ngxs/store(umd.min)[gzip] _{./bundles/*.umd.min.js}	14.03KB (+390B +2.79%)	+1%

Final result: ❌

View report in BundleMon website ➡️

Current branch size history | Target branch size history

bundlemon · 2022-06-22T23:25:38Z

BundleMon (NGXS Plugins)

Unchanged files (28)

Status	Path	Size	Limits
✅	Plugins(umd)[gzip] _{storage-plugin/bundles/ngxs-storage-plugin.um d.js}	7.98KB	+1%
✅	Plugins(umd)[gzip] _{router-plugin/bundles/ngxs-router-plugin.umd. js}	7.28KB	+1%
✅	Plugins(umd)[gzip] _{hmr-plugin/bundles/ngxs-hmr-plugin.umd.js}	6.96KB	+1%
✅	Plugins(umd)[gzip] _{websocket-plugin/bundles/ngxs-websocket-plugi n.umd.js}	6.87KB	+1%
✅	Plugins(umd)[gzip] _{devtools-plugin/bundles/ngxs-devtools-plugin. umd.js}	6.53KB	+1%
✅	Plugins(umd)[gzip] _{form-plugin/bundles/ngxs-form-plugin.umd.js}	6.44KB	+1%
✅	Plugins(umd)[gzip] _{logger-plugin/bundles/ngxs-logger-plugin.umd. js}	5.77KB	+1%
✅	Plugins(fesm5)[gzip] _{storage-plugin/fesm5/ngxs-storage-plugin.js}	4.67KB	+1%
✅	Plugins(fesm2015)[gzip] _{storage-plugin/fesm2015/ngxs-storage-plugin.j s}	4.35KB	+1%
✅	Plugins(fesm5)[gzip] _{router-plugin/fesm5/ngxs-router-plugin.js}	3.91KB	+1%
✅	Plugins(fesm5)[gzip] _{hmr-plugin/fesm5/ngxs-hmr-plugin.js}	3.62KB	+1%
✅	Plugins(fesm2015)[gzip] _{router-plugin/fesm2015/ngxs-router-plugin.js}	3.56KB	+1%
✅	Plugins(fesm5)[gzip] _{websocket-plugin/fesm5/ngxs-websocket-plugin. js}	3.53KB	+1%
✅	Plugins(fesm2015)[gzip] _{hmr-plugin/fesm2015/ngxs-hmr-plugin.js}	3.25KB	+1%
✅	Plugins(fesm5)[gzip] _{devtools-plugin/fesm5/ngxs-devtools-plugin.js}	3.21KB	+1%
✅	Plugins(fesm2015)[gzip] _{websocket-plugin/fesm2015/ngxs-websocket-plug in.js}	3.15KB	+1%
✅	Plugins(umd.min)[gzip] _{hmr-plugin/bundles/ngxs-hmr-plugin.umd.min.js}	3.1KB	+1%
✅	Plugins(fesm5)[gzip] _{form-plugin/fesm5/ngxs-form-plugin.js}	3.07KB	+1%
✅	Plugins(fesm2015)[gzip] _{devtools-plugin/fesm2015/ngxs-devtools-plugin .js}	3.03KB	+1%
✅	Plugins(fesm2015)[gzip] _{form-plugin/fesm2015/ngxs-form-plugin.js}	2.74KB	+1%
✅	Plugins(umd.min)[gzip] _{router-plugin/bundles/ngxs-router-plugin.umd. min.js}	2.72KB	+1%
✅	Plugins(umd.min)[gzip] _{storage-plugin/bundles/ngxs-storage-plugin.um d.min.js}	2.54KB	+1%
✅	Plugins(fesm5)[gzip] _{logger-plugin/fesm5/ngxs-logger-plugin.js}	2.48KB	+1%
✅	Plugins(umd.min)[gzip] _{form-plugin/bundles/ngxs-form-plugin.umd.min. js}	2.43KB	+1%
✅	Plugins(fesm2015)[gzip] _{logger-plugin/fesm2015/ngxs-logger-plugin.js}	2.37KB	+1%
✅	Plugins(umd.min)[gzip] _{websocket-plugin/bundles/ngxs-websocket-plugi n.umd.min.js}	2.18KB	+1%
✅	Plugins(umd.min)[gzip] _{logger-plugin/bundles/ngxs-logger-plugin.umd. min.js}	1.95KB	+1%
✅	Plugins(umd.min)[gzip] _{devtools-plugin/bundles/ngxs-devtools-plugin. umd.min.js}	1.86KB	+1%

No change in files bundle size

Unchanged groups (6)

Status	Path	Size	Limits
✅	All Plugins(esm5)[gzip] _{./-plugin/esm5/**/.js}	128.77KB	+1%
✅	All Plugins(esm2015)[gzip] _{./-plugin/esm2015/**/.js}	123.36KB	+1%
✅	All Plugins(umd)[gzip] _{./-plugin/bundles/.umd.js}	47.84KB	+1%
✅	All Plugins(fesm5)[gzip] _{./-plugin/fesm5/.js}	24.49KB	+1%
✅	All Plugins(fesm2015)[gzip] _{./-plugin/fesm2015/.js}	22.45KB	+1%
✅	All Plugins(umd.min)[gzip] _{./-plugin/bundles/.umd.min.js}	16.77KB	+1%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

bundlemon · 2022-06-22T23:25:41Z

BundleMon (Integration Projects)

Files updated (4)

Status	Path	Size	Limits
✅	Main bundles(Gzip) _{hello-world-ng11-ivy/dist-integration/main.(h ash).js}	71.32KB (+57B +0.08%)	+1%
✅	Main bundles(Gzip) _{hello-world-ng12-ivy/dist-integration/main.(h ash).js}	68.03KB (+57B +0.08%)	+1%
✅	Main bundles(Gzip) _{hello-world-ng13-ivy/dist-integration/main.(h ash).js}	69.94KB (+48B +0.07%)	+1%
✅	Main bundles(Gzip) _{hello-world-ng14-ivy/dist-integration/main.(h ash).js}	65.63KB (+46B +0.07%)	+1%

Total files change +208B +0.07%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

markwhitfeld · 2022-07-20T20:57:24Z

@arturovt Could you add a description for this PR and the motivation for the feature?

markwhitfeld

I think that the API for this needs to be revised.
See the last comment.

packages/store/src/public_api.ts

markwhitfeld · 2022-12-06T21:17:14Z

packages/store/tests/unhandled-actions.spec.ts

+    TestBed.configureTestingModule({
+      imports: [NgxsModule.forRoot([], { warnOnUnhandledActions })]
+    });


I propose a bit of a different API for this.
No config option, or ignoreActions utility, but rather a module that is provided:

Suggested change

TestBed.configureTestingModule({

imports: [NgxsModule.forRoot([], { warnOnUnhandledActions })]

});

TestBed.configureTestingModule({

imports: [

NgxsModule.forRoot([]),

ngDevMode && NgxsDevelopmentModule.forRoot({

warnOnUnhandledActions: true

/* or supply an object:

warnOnUnhandledActions: {

ignore: [ 'SomeActionType', FooActionClass ]

}

*/

})

]

});

This keeps the API consolidated and clear, and follows the existing conventions.

codeclimate · 2022-12-09T06:50:30Z

Code Climate has analyzed commit 63de3f6 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	1

The test coverage on the diff in this pull request is 97.3% (50% is the threshold).

This pull request will bring the total coverage in the repository to 96.9% (0.0% change).

View more on Code Climate.

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@ngxs/form-plugin](https://github.com/ngxs/store) | dependencies | minor | [`3.7.6` -> `3.8.0`](https://renovatebot.com/diffs/npm/@ngxs%2fform-plugin/3.7.6/3.8.0) | | [@ngxs/storage-plugin](https://github.com/ngxs/store) | dependencies | minor | [`3.7.6` -> `3.8.0`](https://renovatebot.com/diffs/npm/@ngxs%2fstorage-plugin/3.7.6/3.8.0) | | [@ngxs/store](https://github.com/ngxs/store) | dependencies | minor | [`3.7.6` -> `3.8.0`](https://renovatebot.com/diffs/npm/@ngxs%2fstore/3.7.6/3.8.0) | --- ### Release Notes <details> <summary>ngxs/store</summary> ### [`v3.8.0`](https://github.com/ngxs/store/blob/HEAD/CHANGELOG.md#380-2023-03-29) [Compare Source](ngxs/store@v3.7.6...v3.8.0) - Feature: Build packages in Ivy format [#1945](ngxs/store#1945) - Feature: Add advanced selector utilities [#1824](ngxs/store#1824) - Feature: Expose `ActionContext` and `ActionStatus` [#1766](ngxs/store#1766) - Feature: `ofAction*` methods should have strong types [#1808](ngxs/store#1808) - Feature: Improve contextual type inference for state operators [#1806](ngxs/store#1806) [#1947](ngxs/store#1947) - Feature: Enable warning on unhandled actions [#1870](ngxs/store#1870) [#1951](ngxs/store#1951) - Feature: Router Plugin - Provide more actions and navigation timing option [#1932](ngxs/store#1932) - Feature: Storage Plugin - Allow providing namespace for keys [#1841](ngxs/store#1841) - Feature: Storage Plugin - Enable providing storage engine individually [#1935](ngxs/store#1935) - Feature: Devtools Plugin - Add new options to the `NgxsDevtoolsOptions` interface [#1879](ngxs/store#1879) - Feature: Devtools Plugin - Add trace options to `NgxsDevtoolsOptions` [#1968](ngxs/store#1968) - Feature: Form Plugin - Allow `ngxsFormDebounce` to be string [#1972](ngxs/store#1972) - Performance: Tree-shake patch errors [#1955](ngxs/store#1955) - Fix: Get descriptor explicitly when it's considered as a class property [#1961](ngxs/store#1961) - Fix: Avoid delayed updates from state stream [#1981](ngxs/store#1981) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <[email protected]> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1837 Reviewed-by: Epsilon_02 <[email protected]> Co-authored-by: Calciumdibromid Bot <[email protected]> Co-committed-by: Calciumdibromid Bot <[email protected]>

arturovt force-pushed the warn-unhandled-actions branch from 434bcd8 to d42966e Compare June 22, 2022 23:14

arturovt force-pushed the warn-unhandled-actions branch from d42966e to 3aa3031 Compare June 23, 2022 15:47

arturovt force-pushed the warn-unhandled-actions branch from 3aa3031 to 4b44381 Compare August 1, 2022 19:04

arturovt marked this pull request as ready for review August 1, 2022 19:04

arturovt requested review from markwhitfeld, kuncevic, Carniatto, poloagustin, joaqcid and splincode as code owners August 1, 2022 19:04

arturovt force-pushed the warn-unhandled-actions branch from 4b44381 to 4ff52bd Compare September 4, 2022 21:01

arturovt added the type: feature label Nov 13, 2022

arturovt added this to the v3.8.0 milestone Nov 29, 2022

markwhitfeld requested changes Dec 6, 2022

View reviewed changes

arturovt force-pushed the warn-unhandled-actions branch from 4ff52bd to ce41941 Compare December 7, 2022 07:21

feat(store): warn on unhandled actions

15a402a

arturovt force-pushed the warn-unhandled-actions branch from ce41941 to 15a402a Compare December 7, 2022 17:28

Merge branch 'master' into warn-unhandled-actions

63de3f6

markwhitfeld approved these changes Dec 9, 2022

View reviewed changes

markwhitfeld merged commit 1bdb8c0 into master Dec 9, 2022

markwhitfeld deleted the warn-unhandled-actions branch December 9, 2022 06:53

markwhitfeld added the released label Mar 29, 2023

abdulrahman305 mentioned this pull request Jul 3, 2024

[Snyk] Upgrade: , , , , abdulrahman305/auptimizer#4

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(store): warn on unhandled actions #1870

feat(store): warn on unhandled actions #1870

arturovt commented Jun 22, 2022 •

edited

Loading

bundlemon bot commented Jun 22, 2022 •

edited

Loading

bundlemon bot commented Jun 22, 2022 •

edited

Loading

bundlemon bot commented Jun 22, 2022 •

edited

Loading

markwhitfeld commented Jul 20, 2022

markwhitfeld left a comment

markwhitfeld Dec 6, 2022

arturovt Dec 7, 2022

codeclimate bot commented Dec 9, 2022

-    TestBed.configureTestingModule({
-      imports: [NgxsModule.forRoot([], { warnOnUnhandledActions })]
-    });
+    TestBed.configureTestingModule({
+      imports: [
+        NgxsModule.forRoot([]),
+        ngDevMode && NgxsDevelopmentModule.forRoot({
+          warnOnUnhandledActions: true
+          /* or supply an object:
+            warnOnUnhandledActions: {
+              ignore: [ 'SomeActionType', FooActionClass ]
+            }
+          */
+        })
+      ]
+    });

feat(store): warn on unhandled actions #1870

feat(store): warn on unhandled actions #1870

Conversation

arturovt commented Jun 22, 2022 • edited Loading

bundlemon bot commented Jun 22, 2022 • edited Loading

BundleMon

bundlemon bot commented Jun 22, 2022 • edited Loading

BundleMon (NGXS Plugins)

bundlemon bot commented Jun 22, 2022 • edited Loading

BundleMon (Integration Projects)

markwhitfeld commented Jul 20, 2022

markwhitfeld left a comment

Choose a reason for hiding this comment

markwhitfeld Dec 6, 2022

Choose a reason for hiding this comment

arturovt Dec 7, 2022

Choose a reason for hiding this comment

codeclimate bot commented Dec 9, 2022

arturovt commented Jun 22, 2022 •

edited

Loading

bundlemon bot commented Jun 22, 2022 •

edited

Loading

bundlemon bot commented Jun 22, 2022 •

edited

Loading

bundlemon bot commented Jun 22, 2022 •

edited

Loading