feat(form-plugin): allow `ngxsFormDebounce` to be string #1972

arturovt · 2023-03-02T08:57:18Z

The ngxsFormDebounce is a static binding for now which means we're not watching its changes. We read it only once and provide to debounceTime. The change allows providing ngxsFormDebounce as a string, and not as a number so we extend possible values to be provided:

<form [ngxsFormDebounce]="300">...</form>
<form ngxsFormDebounce="300">...</form>

bundlemon · 2023-03-02T09:03:36Z

BundleMon

Files updated (1)

Status	Path	Size	Limits
✅	fesm2015/ngxs-store.js	93.68KB (-35B -0.04%)	125KB / +0.5%

Unchanged files (2)

Status	Path	Size	Limits
✅	fesm2015/ngxs-store-operators.js	6.23KB	15KB / +0.5%
✅	fesm2015/ngxs-store-internals.js	4.22KB	20KB / +0.5%

Total files change -35B -0.03%

Groups updated (3)

Status	Path	Size	Limits
✅	@ngxs/store(fesm2015)[gzip] _{./fesm2015/*.js}	25.03KB (+102B +0.4%)	+1%
✅	@ngxs/store(umd)[gzip] _{./bundles/*.umd.js}	36.53KB (+49B +0.13%)	+1%
✅	@ngxs/store(esm2015)[gzip] _{./esm2015/*/.js}	177.36KB (-3.16KB -1.75%)	+1%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

bundlemon · 2023-03-02T09:03:39Z

BundleMon (NGXS Plugins)

Files updated (2)

Status	Path	Size	Limits
✅	Plugins(umd)[gzip] _{form-plugin/bundles/ngxs-form-plugin.umd.js}	3.44KB (+26B +0.74%)	+1%
✅	Plugins(fesm2015)[gzip] _{form-plugin/fesm2015/ngxs-form-plugin.js}	2.67KB (+20B +0.74%)	+1%

Unchanged files (12)

Status	Path	Size	Limits
✅	Plugins(umd)[gzip] _{storage-plugin/bundles/ngxs-storage-plugin.um d.js}	7.96KB	+1%
✅	Plugins(umd)[gzip] _{router-plugin/bundles/ngxs-router-plugin.umd. js}	7.41KB	+1%
✅	Plugins(umd)[gzip] _{websocket-plugin/bundles/ngxs-websocket-plugi n.umd.js}	6.92KB	+1%
✅	Plugins(umd)[gzip] _{hmr-plugin/bundles/ngxs-hmr-plugin.umd.js}	6.89KB	+1%
✅	Plugins(fesm2015)[gzip] _{storage-plugin/fesm2015/ngxs-storage-plugin.j s}	3.64KB	+1%
✅	Plugins(fesm2015)[gzip] _{router-plugin/fesm2015/ngxs-router-plugin.js}	3.09KB	+1%
✅	Plugins(umd)[gzip] _{devtools-plugin/bundles/ngxs-devtools-plugin. umd.js}	2.75KB	+1%
✅	Plugins(fesm2015)[gzip] _{hmr-plugin/fesm2015/ngxs-hmr-plugin.js}	2.65KB	+1%
✅	Plugins(fesm2015)[gzip] _{websocket-plugin/fesm2015/ngxs-websocket-plug in.js}	2.59KB	+1%
✅	Plugins(umd)[gzip] _{logger-plugin/bundles/ngxs-logger-plugin.umd. js}	2.53KB	+1%
✅	Plugins(fesm2015)[gzip] _{devtools-plugin/fesm2015/ngxs-devtools-plugin .js}	2.17KB	+1%
✅	Plugins(fesm2015)[gzip] _{logger-plugin/fesm2015/ngxs-logger-plugin.js}	2.01KB	+1%

Total files change +46B +0.08%

Groups updated (3)

Status	Path	Size	Limits
✅	All Plugins(esm2015)[gzip] _{./-plugin/esm2015/**/.js}	108.71KB (+121B +0.11%)	+1%
✅	All Plugins(umd)[gzip] _{./-plugin/bundles/.umd.js}	37.91KB (+26B +0.07%)	+1%
✅	All Plugins(fesm2015)[gzip] _{./-plugin/fesm2015/.js}	18.82KB (+20B +0.1%)	+1%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

bundlemon · 2023-03-02T09:03:41Z

BundleMon (Integration Projects)

Files updated (1)

Status	Path	Size	Limits
✅	Main bundles(Gzip) _{hello-world-ng13-ivy/dist-integration/main.(h ash).js}	69.73KB (-17B -0.02%)	+1%

Unchanged files (2)

Status	Path	Size	Limits
✅	Main bundles(Gzip) _{hello-world-ng12-ivy/dist-integration/main.(h ash).js}	67.9KB	+1%
✅	Main bundles(Gzip) _{hello-world-ng14-ivy/dist-integration/main.(h ash).js}	64.81KB	+1%

Total files change -37B -0.02%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

markwhitfeld · 2023-03-20T19:23:16Z

@arturovt is there a related issue for this one?

markwhitfeld

Failing build

codeclimate · 2023-03-20T19:36:55Z

Code Climate has analyzed commit 62e8f65 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 87.5% (50% is the threshold).

This pull request will bring the total coverage in the repository to 97.0% (-0.2% change).

View more on Code Climate.

markwhitfeld

LGTM

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@ngxs/form-plugin](https://github.com/ngxs/store) | dependencies | minor | [`3.7.6` -> `3.8.0`](https://renovatebot.com/diffs/npm/@ngxs%2fform-plugin/3.7.6/3.8.0) | | [@ngxs/storage-plugin](https://github.com/ngxs/store) | dependencies | minor | [`3.7.6` -> `3.8.0`](https://renovatebot.com/diffs/npm/@ngxs%2fstorage-plugin/3.7.6/3.8.0) | | [@ngxs/store](https://github.com/ngxs/store) | dependencies | minor | [`3.7.6` -> `3.8.0`](https://renovatebot.com/diffs/npm/@ngxs%2fstore/3.7.6/3.8.0) | --- ### Release Notes <details> <summary>ngxs/store</summary> ### [`v3.8.0`](https://github.com/ngxs/store/blob/HEAD/CHANGELOG.md#380-2023-03-29) [Compare Source](ngxs/store@v3.7.6...v3.8.0) - Feature: Build packages in Ivy format [#1945](ngxs/store#1945) - Feature: Add advanced selector utilities [#1824](ngxs/store#1824) - Feature: Expose `ActionContext` and `ActionStatus` [#1766](ngxs/store#1766) - Feature: `ofAction*` methods should have strong types [#1808](ngxs/store#1808) - Feature: Improve contextual type inference for state operators [#1806](ngxs/store#1806) [#1947](ngxs/store#1947) - Feature: Enable warning on unhandled actions [#1870](ngxs/store#1870) [#1951](ngxs/store#1951) - Feature: Router Plugin - Provide more actions and navigation timing option [#1932](ngxs/store#1932) - Feature: Storage Plugin - Allow providing namespace for keys [#1841](ngxs/store#1841) - Feature: Storage Plugin - Enable providing storage engine individually [#1935](ngxs/store#1935) - Feature: Devtools Plugin - Add new options to the `NgxsDevtoolsOptions` interface [#1879](ngxs/store#1879) - Feature: Devtools Plugin - Add trace options to `NgxsDevtoolsOptions` [#1968](ngxs/store#1968) - Feature: Form Plugin - Allow `ngxsFormDebounce` to be string [#1972](ngxs/store#1972) - Performance: Tree-shake patch errors [#1955](ngxs/store#1955) - Fix: Get descriptor explicitly when it's considered as a class property [#1961](ngxs/store#1961) - Fix: Avoid delayed updates from state stream [#1981](ngxs/store#1981) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <[email protected]> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1837 Reviewed-by: Epsilon_02 <[email protected]> Co-authored-by: Calciumdibromid Bot <[email protected]> Co-committed-by: Calciumdibromid Bot <[email protected]>

arturovt requested review from markwhitfeld, kuncevic, Carniatto, poloagustin, joaqcid and splincode as code owners March 2, 2023 08:57

arturovt force-pushed the feat/form-debounce-string branch from f1fb3e7 to 2887c2b Compare March 2, 2023 08:58

arturovt force-pushed the feat/form-debounce-string branch 2 times, most recently from ac34aa1 to 49ebb5b Compare March 2, 2023 20:04

arturovt force-pushed the feat/form-debounce-string branch 2 times, most recently from c0df3f7 to 09e580c Compare March 20, 2023 14:35

markwhitfeld approved these changes Mar 20, 2023

View reviewed changes

markwhitfeld requested changes Mar 20, 2023

View reviewed changes

arturovt force-pushed the feat/form-debounce-string branch from 09e580c to 5827d74 Compare March 20, 2023 19:32

feat(form-plugin): allow ngxsFormDebounce to be string

62e8f65

arturovt force-pushed the feat/form-debounce-string branch from 5827d74 to 62e8f65 Compare March 20, 2023 19:33

arturovt merged commit 6835a28 into master Mar 20, 2023

arturovt deleted the feat/form-debounce-string branch March 20, 2023 19:41

markwhitfeld reviewed Mar 20, 2023

View reviewed changes

markwhitfeld added this to the v3.8.0 milestone Mar 29, 2023

abdulrahman305 mentioned this pull request Jul 3, 2024

[Snyk] Upgrade: , , , , abdulrahman305/auptimizer#4

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(form-plugin): allow `ngxsFormDebounce` to be string #1972

feat(form-plugin): allow `ngxsFormDebounce` to be string #1972

arturovt commented Mar 2, 2023 •

edited

Loading

bundlemon bot commented Mar 2, 2023 •

edited

Loading

bundlemon bot commented Mar 2, 2023 •

edited

Loading

bundlemon bot commented Mar 2, 2023 •

edited

Loading

markwhitfeld commented Mar 20, 2023

markwhitfeld left a comment

codeclimate bot commented Mar 20, 2023

markwhitfeld left a comment

feat(form-plugin): allow ngxsFormDebounce to be string #1972

feat(form-plugin): allow ngxsFormDebounce to be string #1972

Conversation

arturovt commented Mar 2, 2023 • edited Loading

bundlemon bot commented Mar 2, 2023 • edited Loading

BundleMon

bundlemon bot commented Mar 2, 2023 • edited Loading

BundleMon (NGXS Plugins)

bundlemon bot commented Mar 2, 2023 • edited Loading

BundleMon (Integration Projects)

markwhitfeld commented Mar 20, 2023

markwhitfeld left a comment

Choose a reason for hiding this comment

codeclimate bot commented Mar 20, 2023

markwhitfeld left a comment

Choose a reason for hiding this comment

feat(form-plugin): allow `ngxsFormDebounce` to be string #1972

feat(form-plugin): allow `ngxsFormDebounce` to be string #1972

arturovt commented Mar 2, 2023 •

edited

Loading

bundlemon bot commented Mar 2, 2023 •

edited

Loading

bundlemon bot commented Mar 2, 2023 •

edited

Loading

bundlemon bot commented Mar 2, 2023 •

edited

Loading